devs/libstrophe-gh
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

conn: fixed memory leak

Browse Source 
Memory leak appeared when xmpp_connect_client() was called for a
connection more than once. In this case conn->domain wasn't freed.
This commit is contained in:
Dmitry Podgorny
2015-10-23 01:28:19 +03:00
parent a54def3e92
commit 01af2deed9
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/conn.c
View File

@@ -403,6 +403,8 @@ int xmpp_connect_client(xmpp_conn_t * const conn,
if (conn->state != XMPP_STATE_DISCONNECTED) if (conn->state != XMPP_STATE_DISCONNECTED)
return -1; return -1;
if (conn->domain != NULL)
xmpp_free(conn->ctx, conn->domain);
conn->type = XMPP_CLIENT; conn->type = XMPP_CLIENT;
conn->secured = 0; conn->secured = 0;
@@ -487,6 +489,8 @@ int xmpp_connect_component(xmpp_conn_t * const conn, const char * const server,
if (conn->state != XMPP_STATE_DISCONNECTED) if (conn->state != XMPP_STATE_DISCONNECTED)
return -1; return -1;
if (conn->domain != NULL)
xmpp_free(conn->ctx, conn->domain);
conn->type = XMPP_COMPONENT; conn->type = XMPP_COMPONENT;
conn->secured = 0; conn->secured = 0;