devs/libstrophe-gh
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Only require session if it is not optional

Browse Source 
RFC6121 removes the precondition of establishing a session before a client
may exchange XML stanzas on an XMPP network.

This PR allows libstrophe to not request session where it is indicated
as optional by the server, saving a round trip.

https://tools.ietf.org/html/rfc6121#section-1.4
This commit is contained in:
Stu Tomlinson
2018-06-08 14:27:29 +00:00
parent 9a86efabe5
commit 0e6b0ef84d
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/auth.c
View File

@@ -888,8 +888,10 @@ static int _handle_features_sasl(xmpp_conn_t * const conn,
session = xmpp_stanza_get_child_by_name(stanza, "session"); session = xmpp_stanza_get_child_by_name(stanza, "session");
if (session && strcmp(xmpp_stanza_get_ns(session), XMPP_NS_SESSION) == 0) { if (session && strcmp(xmpp_stanza_get_ns(session), XMPP_NS_SESSION) == 0) {
/* session establishment required */ /* session establishment might be required */
conn->session_required = 1; xmpp_stanza_t *opt = xmpp_stanza_get_child_by_name(session, "optional");
if (!opt)
conn->session_required = 1;
} }
/* if bind is required, go ahead and start it */ /* if bind is required, go ahead and start it */