devs/libstrophe-gh
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sasl: remove unused argument

Browse Source 
_add_key() is a static function which is used only for DIGEST_MD5. Its
argument 'len' is not used and remains 0. Remove it.
This commit is contained in:
Dmitry Podgorny
2020-03-31 18:56:02 +03:00
parent 198bdd77d0
commit 3063d886bd
1 changed files with 11 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
src/sasl.c
View File

@@ -172,20 +172,14 @@ static void _digest_to_hex(const char *digest, char *hex)
} }
/** append 'key="value"' to a buffer, growing as necessary */ /** append 'key="value"' to a buffer, growing as necessary */
static char *_add_key(xmpp_ctx_t *ctx, static char *
hash_t *table, _add_key(xmpp_ctx_t *ctx, hash_t *table, const char *key, char *buf, int quote)
const char *key,
char *buf,
int *len,
int quote)
{ {
int olen, nlen; int olen, nlen;
int keylen, valuelen; int keylen, valuelen;
const char *value, *qvalue; const char *value, *qvalue;
char *c; char *c;
UNUSED(len);
/* allocate a zero-length string if necessary */ /* allocate a zero-length string if necessary */
if (buf == NULL) { if (buf == NULL) {
buf = xmpp_alloc(ctx, 1); buf = xmpp_alloc(ctx, 1);
@@ -242,7 +236,6 @@ char *sasl_digest_md5(xmpp_ctx_t *ctx,
char *node, *domain, *realm; char *node, *domain, *realm;
char *value; char *value;
char *response; char *response;
int rlen;
struct MD5Context MD5; struct MD5Context MD5;
unsigned char digest[16], HA1[16], HA2[16]; unsigned char digest[16], HA1[16], HA2[16];
char hex[32]; char hex[32];
@@ -358,16 +351,15 @@ char *sasl_digest_md5(xmpp_ctx_t *ctx,
/* construct reply */ /* construct reply */
result = NULL; result = NULL;
rlen = 0; result = _add_key(ctx, table, "username", result, 1);
result = _add_key(ctx, table, "username", result, &rlen, 1); result = _add_key(ctx, table, "realm", result, 1);
result = _add_key(ctx, table, "realm", result, &rlen, 1); result = _add_key(ctx, table, "nonce", result, 1);
result = _add_key(ctx, table, "nonce", result, &rlen, 1); result = _add_key(ctx, table, "cnonce", result, 1);
result = _add_key(ctx, table, "cnonce", result, &rlen, 1); result = _add_key(ctx, table, "nc", result, 0);
result = _add_key(ctx, table, "nc", result, &rlen, 0); result = _add_key(ctx, table, "qop", result, 0);
result = _add_key(ctx, table, "qop", result, &rlen, 0); result = _add_key(ctx, table, "digest-uri", result, 1);
result = _add_key(ctx, table, "digest-uri", result, &rlen, 1); result = _add_key(ctx, table, "response", result, 0);
result = _add_key(ctx, table, "response", result, &rlen, 0); result = _add_key(ctx, table, "charset", result, 0);
result = _add_key(ctx, table, "charset", result, &rlen, 0);
xmpp_free(ctx, node); xmpp_free(ctx, node);
xmpp_free(ctx, domain); xmpp_free(ctx, domain);