From 4b194b98cfa25b6f1ce617b3f964657f53dd8414 Mon Sep 17 00:00:00 2001 From: Sharjeel Aziz Date: Wed, 31 Jul 2013 10:33:52 -0400 Subject: [PATCH] Fixed a potential buffer overflow in xmpp_stanza_to_text when the stanza length was greater than the default buffer size of 1024. Tested on Windows only. --- src/stanza.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/stanza.c b/src/stanza.c index 4ecc558..3ffa825 100644 --- a/src/stanza.c +++ b/src/stanza.c @@ -398,7 +398,7 @@ int xmpp_stanza_to_text(xmpp_stanza_t *stanza, return XMPP_EMEM; } - ret = _render_stanza_recursive(stanza, buffer, length); + ret = _render_stanza_recursive(stanza, buffer, length - 1); if (ret < 0) return ret; if (ret > length - 1) {