From 6180bbcc0a14c28392a570edeb585f88555dd564 Mon Sep 17 00:00:00 2001
From: James Canete <jcanete@chesspark.com>
Date: Tue, 8 Nov 2005 05:03:18 +0000
Subject: [PATCH] Changed id handlers so they are removed if they do not return
 true.

---
 src/handler.c | 30 ++++++++++++++++++++++++------
 1 file changed, 24 insertions(+), 6 deletions(-)

diff --git a/src/handler.c b/src/handler.c
index 297fa98..3663097 100644
--- a/src/handler.c
+++ b/src/handler.c
@@ -34,12 +34,30 @@ void handler_fire_stanza(xmpp_conn_t * const conn,
     /* call id handlers */
     id = xmpp_stanza_get_id(stanza);
     if (id) {
-	item = (xmpp_handlist_t *)hash_get(conn->id_handlers, id);
-	for (; item; item = item->next) {
-	    if (item->user_handler && !conn->authenticated)
-		continue;
-	    
-	    ((xmpp_handler)(item->handler))(conn, stanza, item->userdata);
+	prev = NULL;
+ 	item = (xmpp_handlist_t *)hash_get(conn->id_handlers, id);
+	while (item) {
+	    xmpp_handlist_t *next = item->next;
+
+	    if (item->user_handler && !conn->authenticated) {
+		item = next;
+ 		continue;
+	    }
+
+	    if (!((xmpp_handler)(item->handler))(conn, stanza, item->userdata)) {
+		/* handler is one-shot, so delete it */
+		if (prev)
+		    prev->next = next;
+		else {
+		    hash_drop(conn->id_handlers, id);
+		    hash_add(conn->id_handlers, id, next);
+		}
+		xmpp_free(conn->ctx, item);
+		item = NULL;
+	    }
+	    if (item)
+		prev = item;
+	    item = next;
 	}
     }