devs/libstrophe-gh
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

stanza: fix xmpp_error_new() in #115

Browse Source 
* Don't set text to a tag stanza. It returns XMPP_INVOP.
 * Don't use stanza after releasing own reference.
This commit is contained in:
Dmitry Podgorny
2017-09-12 17:43:05 +03:00
parent f12d43989f
commit 6e6093ee7b
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/stanza.c
View File

@@ -1321,14 +1321,14 @@ xmpp_stanza_t *xmpp_error_new(xmpp_ctx_t *ctx, xmpp_error_type_t const type, cha
xmpp_stanza_t *error_text = xmpp_stanza_new(ctx); xmpp_stanza_t *error_text = xmpp_stanza_new(ctx);
xmpp_stanza_set_name(error_text, "text"); xmpp_stanza_set_name(error_text, "text");
xmpp_stanza_set_ns(error_text, XMPP_NS_STREAMS_IETF); xmpp_stanza_set_ns(error_text, XMPP_NS_STREAMS_IETF);
xmpp_stanza_set_text(error_text, text);
xmpp_stanza_add_child(error, error_text);
xmpp_stanza_release(error_text);
xmpp_stanza_t *content = xmpp_stanza_new(ctx); xmpp_stanza_t *content = xmpp_stanza_new(ctx);
xmpp_stanza_set_text(content, text); xmpp_stanza_set_text(content, text);
xmpp_stanza_add_child(error_text, content); xmpp_stanza_add_child(error_text, content);
xmpp_stanza_release(content); xmpp_stanza_release(content);
xmpp_stanza_add_child(error, error_text);
xmpp_stanza_release(error_text);
} }
return error; return error;