devs/libstrophe-gh
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

conn: don't hardcode buffer size

Browse Source 
Use sizeof instead of hardcoded size, so the buffer can be changed
easily.
This commit is contained in:
Dmitry Podgorny
2019-10-02 03:26:36 +03:00
parent 2bf5cc0e41
commit e25ca7719f
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/conn.c
View File

@@ -756,10 +756,10 @@ void xmpp_send_raw_string(xmpp_conn_t * const conn,
char *bigbuf; char *bigbuf;
va_start(ap, fmt); va_start(ap, fmt);
len = xmpp_vsnprintf(buf, 1024, fmt, ap); len = xmpp_vsnprintf(buf, sizeof(buf), fmt, ap);
va_end(ap); va_end(ap);
if (len >= 1024) { if (len >= sizeof(buf)) {
/* we need more space for this data, so we allocate a big /* we need more space for this data, so we allocate a big
* enough buffer and print to that */ * enough buffer and print to that */
len++; /* account for trailing \0 */ len++; /* account for trailing \0 */
@@ -780,7 +780,6 @@ void xmpp_send_raw_string(xmpp_conn_t * const conn,
xmpp_free(conn->ctx, bigbuf); xmpp_free(conn->ctx, bigbuf);
} else { } else {
xmpp_debug(conn->ctx, "conn", "SENT: %s", buf); xmpp_debug(conn->ctx, "conn", "SENT: %s", buf);
xmpp_send_raw(conn, buf, len); xmpp_send_raw(conn, buf, len);
} }
} }