devs/libstrophe-gh
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

stanza: handle errors better

Browse Source 
* Free memory on error in xmpp_stanza_set_attribute()
* Handle memory allocation error in xmpp_stanza_set_text()
This commit is contained in:
Dmitry Podgorny
2015-10-21 02:11:03 +03:00
parent 31582cac92
commit e475ca13ea
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/stanza.c
View File

@@ -583,7 +583,10 @@ int xmpp_stanza_set_attribute(xmpp_stanza_t * const stanza,
} }
val = xmpp_strdup(stanza->ctx, value); val = xmpp_strdup(stanza->ctx, value);
if (!val) return XMPP_EMEM; if (!val) {
hash_release(stanza->attributes);
return XMPP_EMEM;
}
hash_add(stanza->attributes, key, val); hash_add(stanza->attributes, key, val);
@@ -662,7 +665,7 @@ int xmpp_stanza_set_text(xmpp_stanza_t *stanza,
if (stanza->data) xmpp_free(stanza->ctx, stanza->data); if (stanza->data) xmpp_free(stanza->ctx, stanza->data);
stanza->data = xmpp_strdup(stanza->ctx, text); stanza->data = xmpp_strdup(stanza->ctx, text);
return XMPP_EOK; return stanza->data == NULL ? XMPP_EMEM : XMPP_EOK;
} }
/** Set the text data for a text stanza. /** Set the text data for a text stanza.