devs/profanity
2
0
Fork 0
mirror of https://git.jabber.space/devs/cproof.git synced 2026-07-19 18:46:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

fgets: buffer size

Browse Source
This commit is contained in:
Peter Vilim
2015-01-07 21:37:35 -06:00
parent b298994ce7
commit 0cb548683c
3 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/config/accounts.c
View File

@@ -230,9 +230,12 @@ accounts_get_account(const char * const name)
// Evaluate as shell command to retrieve password
if (eval_password != NULL) {
FILE *stream = popen(eval_password, "r");
// Limit to 100 bytes to prevent overflows in the case of a poorly chosen command
password = g_malloc(100);
password = fgets(password, 100, stream);
// Limit to READ_BUF_SIZE bytes to prevent overflows in the case of a poorly chosen command
password = g_malloc(READ_BUF_SIZE);
gchar *result = fgets(password, READ_BUF_SIZE, stream);
if (result != NULL) {
password = result;
}
}
gboolean enabled = g_key_file_get_boolean(accounts, name, "enabled", NULL);