devs/profanity
2
0
Fork 0
mirror of https://git.jabber.space/devs/cproof.git synced 2026-07-18 00:36:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(xmpp): guard NULL domain in autoping disco warning gate

Browse Source 
g_ascii_strcasecmp() is not NULL-safe (unlike the g_strcmp0 it replaced), and connection_get_domain() can be NULL (init NULL, FREE_SET_NULL on teardown). A disco#info response racing a disconnect would dereference NULL. Capture the domain and skip the check when it is NULL.
This commit is contained in:
jabber.developer2
2026-06-23 14:23:11 +03:00
parent 02e679c277
commit 15dfc2bdb4
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/xmpp/iq.c
View File

@@ -2432,7 +2432,8 @@ _disco_info_response_id_handler_onconnect(xmpp_stanza_t* const stanza, void* con
} }
// Prevent repetitions by avoiding checks of disco items (from connection_set_disco_items) // Prevent repetitions by avoiding checks of disco items (from connection_set_disco_items)
if (from && g_ascii_strcasecmp(from, connection_get_domain()) == 0) { const char* domain = connection_get_domain();
if (from && domain && g_ascii_strcasecmp(from, domain) == 0) {
_disco_autoping_warning_message(features); _disco_autoping_warning_message(features);
} }
} }