devs/profanity
2
0
Fork 0
mirror of https://git.jabber.space/devs/cproof.git synced 2026-07-27 08:36:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix memory leak in roster_update()

Browse Source 
current_name should not be const and should be freed.
This commit is contained in:
Michael Vetter
2019-07-22 14:42:43 +02:00
parent e540ccd50e
commit 41267ae1c5
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/xmpp/roster_list.c
View File

@@ -304,13 +304,14 @@ roster_update(const char *const barejid, const char *const name, GSList *groups,
p_contact_set_pending_out(contact, pending_out); p_contact_set_pending_out(contact, pending_out);
const char * const new_name = name; const char * const new_name = name;
const char * current_name = NULL; char * current_name = NULL;
if (p_contact_name(contact)) { if (p_contact_name(contact)) {
current_name = strdup(p_contact_name(contact)); current_name = strdup(p_contact_name(contact));
} }
p_contact_set_name(contact, new_name); p_contact_set_name(contact, new_name);
_replace_name(current_name, new_name, barejid); _replace_name(current_name, new_name, barejid);
free(current_name);
GSList *curr_new_group = groups; GSList *curr_new_group = groups;
while (curr_new_group) { while (curr_new_group) {