devs/profanity
2
0
Fork 0
mirror of https://git.jabber.space/devs/cproof.git synced 2026-07-24 04:56:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'master' into autocomplete-clear

Browse Source
This commit is contained in:
James Booth
2018-03-05 20:50:05 +00:00
parent ad76495267 ecd0736a09
commit 44cff47668
7 changed files with 164 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/command/cmd_funcs.c
View File

@@ -4500,11 +4500,15 @@ cmd_bookmark(ProfWin *window, const char *const command, gchar **args)
if (conn_status != JABBER_CONNECTED) {
cons_show("You are not currently connected.");
cons_alert();
return TRUE;
}
int num_args = g_strv_length(args);
gchar *cmd = args[0];
if (window->type == WIN_MUC && (cmd == NULL || g_strcmp0(cmd, "add") == 0)) {
if (window->type == WIN_MUC
&& num_args < 2
&& (cmd == NULL || g_strcmp0(cmd, "add") == 0)) {
// default to current nickname, password, and autojoin "on"
ProfMucWin *mucwin = (ProfMucWin*)window;
assert(mucwin->memcheck == PROFMUCWIN_MEMCHECK);
@@ -4519,7 +4523,9 @@ cmd_bookmark(ProfWin *window, const char *const command, gchar **args)
return TRUE;
}
if (window->type == WIN_MUC && g_strcmp0(cmd, "remove") == 0) {
if (window->type == WIN_MUC
&& num_args < 2
&& g_strcmp0(cmd, "remove") == 0) {
ProfMucWin *mucwin = (ProfMucWin*)window;
assert(mucwin->memcheck == PROFMUCWIN_MEMCHECK);
gboolean removed = bookmark_remove(mucwin->roomjid);
@@ -4533,6 +4539,7 @@ cmd_bookmark(ProfWin *window, const char *const command, gchar **args)
if (cmd == NULL) {
cons_bad_cmd_usage(command);
cons_alert();
return TRUE;
}
@@ -4547,6 +4554,7 @@ cmd_bookmark(ProfWin *window, const char *const command, gchar **args)
cons_bad_cmd_usage(command);
cons_show("");
}
cons_alert();
return TRUE;
}
@@ -4561,11 +4569,13 @@ cmd_bookmark(ProfWin *window, const char *const command, gchar **args)
if (jid == NULL) {
cons_bad_cmd_usage(command);
cons_show("");
cons_alert();
return TRUE;
}
if (strchr(jid, '@') == NULL) {
cons_show("Invalid room, must be of the form room@domain.tld");
cons_show("");
cons_alert();
return TRUE;
}
@@ -4576,6 +4586,7 @@ cmd_bookmark(ProfWin *window, const char *const command, gchar **args)
} else {
cons_show("No bookmark exists for %s.", jid);
}
cons_alert();
return TRUE;
}
@@ -4584,6 +4595,7 @@ cmd_bookmark(ProfWin *window, const char *const command, gchar **args)
if (!joined) {
cons_show("No bookmark exists for %s.", jid);
}
cons_alert();
return TRUE;
}
@@ -4594,6 +4606,7 @@ cmd_bookmark(ProfWin *window, const char *const command, gchar **args)
if (!parsed) {
cons_bad_cmd_usage(command);
cons_show("");
cons_alert();
return TRUE;
}
@@ -4603,6 +4616,7 @@ cmd_bookmark(ProfWin *window, const char *const command, gchar **args)
cons_bad_cmd_usage(command);
cons_show("");
options_destroy(options);
cons_alert();
return TRUE;
}
@@ -4617,6 +4631,7 @@ cmd_bookmark(ProfWin *window, const char *const command, gchar **args)
cons_show("Bookmark already exists, use /bookmark update to edit.");
}
options_destroy(options);
cons_alert();
return TRUE;
}
@@ -4628,11 +4643,13 @@ cmd_bookmark(ProfWin *window, const char *const command, gchar **args)
cons_show("No bookmark exists for %s.", jid);
}
options_destroy(options);
cons_alert();
return TRUE;
}
cons_bad_cmd_usage(command);
options_destroy(options);
cons_alert();
return TRUE;
}

2
src/config/theme.c
View File

@@ -402,6 +402,7 @@ _load_preferences(void)
_set_boolean_preference("roster.contacts", PREF_ROSTER_CONTACTS);
_set_boolean_preference("roster.unsubscribed", PREF_ROSTER_UNSUBSCRIBED);
_set_boolean_preference("roster.rooms", PREF_ROSTER_ROOMS);
_set_boolean_preference("roster.rooms.server", PREF_ROSTER_ROOMS_SERVER);
_set_boolean_preference("privileges", PREF_MUC_PRIVILEGES);
_set_boolean_preference("presence", PREF_PRESENCE);
_set_boolean_preference("intype", PREF_INTYPE);
@@ -427,7 +428,6 @@ _load_preferences(void)
_set_string_preference("roster.unread", PREF_ROSTER_UNREAD);
_set_string_preference("roster.rooms.order", PREF_ROSTER_ROOMS_ORDER);
_set_string_preference("roster.rooms.unread", PREF_ROSTER_ROOMS_UNREAD);
_set_string_preference("roster.rooms.server", PREF_ROSTER_ROOMS_SERVER);
_set_string_preference("roster.rooms.pos", PREF_ROSTER_ROOMS_POS);
_set_string_preference("roster.rooms.by", PREF_ROSTER_ROOMS_BY);
_set_string_preference("roster.private", PREF_ROSTER_PRIVATE);