devs/profanity
2
0
Fork 0
mirror of https://git.jabber.space/devs/cproof.git synced 2026-07-30 15:46:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix memleak in stanza_get_oldest_delay

Browse Source 
We need to unref the temp datetimes again.
This commit is contained in:
Michael Vetter
2020-02-25 15:54:44 +01:00
parent e9c5c1979d
commit 62730367d6
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/xmpp/stanza.c
View File

@@ -1286,15 +1286,27 @@ stanza_get_oldest_delay(xmpp_stanza_t *const stanza)
if (child_name && strcmp(child_name, STANZA_NAME_DELAY) == 0) { if (child_name && strcmp(child_name, STANZA_NAME_DELAY) == 0) {
GDateTime *tmp = _stanza_get_delay_timestamp_xep0203(child); GDateTime *tmp = _stanza_get_delay_timestamp_xep0203(child);
if (!oldest || g_date_time_compare(oldest, tmp) == 1) if (oldest == NULL) {
oldest = tmp; oldest = tmp;
} else if (g_date_time_compare(oldest, tmp) == 1) {
g_date_time_unref(oldest);
oldest = tmp;
} else {
g_date_time_unref(tmp);
}
} }
if (child_name && strcmp(child_name, STANZA_NAME_X) == 0) { if (child_name && strcmp(child_name, STANZA_NAME_X) == 0) {
GDateTime *tmp = _stanza_get_delay_timestamp_xep0091(child); GDateTime *tmp = _stanza_get_delay_timestamp_xep0091(child);
if (!oldest || g_date_time_compare(oldest, tmp) == 1) if (oldest == NULL) {
oldest = tmp; oldest = tmp;
} else if (g_date_time_compare(oldest, tmp) == 1) {
g_date_time_unref(oldest);
oldest = tmp;
} else {
g_date_time_unref(tmp);
}
} }
} }