devs/profanity
2
0
Fork 0
mirror of https://git.jabber.space/devs/cproof.git synced 2026-07-18 11:06:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

src/plugins/callbacks.c: drop redundant NULL pointer check

Browse Source 
gcc-12 detects redundant check against array of arrays as:

    src/plugins/callbacks.c: In function ‘_free_command_help’:
    src/plugins/callbacks.c:85:26: error: the comparison will always evaluate as ‘true’ for the address of ‘args’ will never be NULL [-Werror=address]
       85 |     while (help->args[i] != NULL && help->args[i][0] != NULL) {
          |                          ^~
    In file included from ./src/ui/ui.h:44,
                     from ./src/command/cmd_defs.h:42,
                     from src/plugins/callbacks.c:41:
    ./src/command/cmd_funcs.h:48:12: note: ‘args’ declared here
       48 |     gchar* args[128][2];
          |            ^~~~
This commit is contained in:
Sergei Trofimovich
2021-11-18 22:27:20 +00:00
parent 9a9122c148
commit 753d9dbbdb
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/callbacks.c
View File

@@ -82,7 +82,7 @@ _free_command_help(CommandHelp* help)
free(help->desc);
i = 0;
while (help->args[i] != NULL && help->args[i][0] != NULL) {
while (help->args[i][0] != NULL) {
free(help->args[i][0]);
free(help->args[i][1]);
i++;