From 776bc262d03ab29420e05f941afca9f2c5e5def2 Mon Sep 17 00:00:00 2001 From: Michael Vetter Date: Fri, 27 Feb 2026 20:17:41 +0100 Subject: [PATCH] refactor: change vcard_print() checks data is allocated via g_new0() so cannot be NULL here. And it was used before the check already so that didn't make any sense in the first place. --- src/xmpp/vcard.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/xmpp/vcard.c b/src/xmpp/vcard.c index 0311b05d..a2b9c70c 100644 --- a/src/xmpp/vcard.c +++ b/src/xmpp/vcard.c @@ -1229,10 +1229,8 @@ vcard_print(xmpp_ctx_t* ctx, ProfWin* window, char* jid) _userdata* data = g_new0(_userdata, 1); data->vcard = vcard_new(); - if (!data || !data->vcard) { - if (data) { - g_free(data); - } + if (!data->vcard) { + g_free(data); cons_show("vCard allocation failed"); return; @@ -1379,10 +1377,8 @@ vcard_photo(xmpp_ctx_t* ctx, char* jid, char* filename, int index, gboolean open _userdata* data = g_new0(_userdata, 1); data->vcard = vcard_new(); - if (!data || !data->vcard) { - if (data) { - free(data); - } + if (!data->vcard) { + g_free(data); cons_show("vCard allocation failed"); return;