devs/profanity
2
0
Fork 0
mirror of https://git.jabber.space/devs/cproof.git synced 2026-07-31 21:36:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed double free'ing in tests

Browse Source
This commit is contained in:
James Booth
2014-01-28 21:51:43 +00:00
parent c3ea8f8d0b
commit 788fc48b1d
3 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/test_cmd_alias.c
View File

@@ -105,7 +105,7 @@ void cmd_alias_add_shows_message_when_exists(void **state)
prefs_add_alias("hc", "/help commands"); prefs_add_alias("hc", "/help commands");
cmd_autocomplete_add("/hc"); cmd_autocomplete_add("/hc");
expect_cons_show("Command or alias /hc already exists."); expect_cons_show("Command or alias '/hc' already exists.");
gboolean result = cmd_alias(args, *help); gboolean result = cmd_alias(args, *help);
assert_true(result); assert_true(result);

4
tests/test_contact.c
View File

@@ -20,7 +20,7 @@ void contact_in_group(void **state)
assert_true(result); assert_true(result);
p_contact_free(contact); p_contact_free(contact);
g_slist_free(groups); // g_slist_free(groups);
} }
void contact_not_in_group(void **state) void contact_not_in_group(void **state)
@@ -35,7 +35,7 @@ void contact_not_in_group(void **state)
assert_false(result); assert_false(result);
p_contact_free(contact); p_contact_free(contact);
g_slist_free(groups); // g_slist_free(groups);
} }
void contact_name_when_name_exists(void **state) void contact_name_when_name_exists(void **state)

14
tests/testsuite.c
View File

@@ -386,9 +386,9 @@ int main(int argc, char* argv[]) {
unit_test_setup_teardown(console_doesnt_show_dnd_presence_when_set_online, unit_test_setup_teardown(console_doesnt_show_dnd_presence_when_set_online,
create_config_file, create_config_file,
delete_config_file), delete_config_file),
// unit_test_setup_teardown(console_shows_dnd_presence_when_set_all, unit_test_setup_teardown(console_shows_dnd_presence_when_set_all,
// create_config_file, create_config_file,
// delete_config_file), delete_config_file),
}; };
const UnitTest cmd_alias_tests[] = { const UnitTest cmd_alias_tests[] = {
@@ -399,9 +399,9 @@ int main(int argc, char* argv[]) {
unit_test_setup_teardown(cmd_alias_add_adds_alias, unit_test_setup_teardown(cmd_alias_add_adds_alias,
create_config_file, create_config_file,
delete_config_file), delete_config_file),
// unit_test_setup_teardown(cmd_alias_add_shows_message_when_exists, unit_test_setup_teardown(cmd_alias_add_shows_message_when_exists,
// create_config_file, create_config_file,
// delete_config_file), delete_config_file),
unit_test_setup_teardown(cmd_alias_remove_removes_alias, unit_test_setup_teardown(cmd_alias_remove_removes_alias,
create_config_file, create_config_file,
delete_config_file), delete_config_file),
@@ -413,7 +413,6 @@ int main(int argc, char* argv[]) {
delete_config_file), delete_config_file),
}; };
int bak, new; int bak, new;
fflush(stdout); fflush(stdout);
bak = dup(1); bak = dup(1);
@@ -442,6 +441,7 @@ int main(int argc, char* argv[]) {
fflush(stdout); fflush(stdout);
dup2(bak, 1); dup2(bak, 1);
close(bak); close(bak);
if (result > 0) { if (result > 0) {
return 1; return 1;
} else { } else {