devs/profanity
2
0
Fork 0
mirror of https://git.jabber.space/devs/cproof.git synced 2026-07-24 13:26:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cleanup: gchar as gchar instead of char

Browse Source 
Use gchar instead of char in most of the cases where gchar is intended.

Reason: improve compatibility and stability. Issue #1819

Minor refactoring.
This commit is contained in:
John Hernandez
2023-04-19 02:44:19 +02:00
parent faccf24c75
commit 7f3fca2bd0
26 changed files with 138 additions and 269 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
tests/unittests/test_cmd_join.c
View File

@@ -64,10 +64,10 @@ cmd_join_shows_error_message_when_invalid_room_jid(void** state)
void
cmd_join_uses_account_mucservice_when_no_service_specified(void** state)
{
char* account_name = g_strdup("an_account");
gchar* account_name = g_strdup("an_account");
char* room = "room";
char* nick = "bob";
char* account_service = g_strdup("conference.server.org");
gchar* account_service = g_strdup("conference.server.org");
char* expected_room = "room@conference.server.org";
gchar* args[] = { room, "nick", nick, NULL };
ProfAccount* account = account_new(account_name, g_strdup("user@server.org"), NULL, NULL,
@@ -94,7 +94,7 @@ cmd_join_uses_account_mucservice_when_no_service_specified(void** state)
void
cmd_join_uses_supplied_nick(void** state)
{
char* account_name = g_strdup("an_account");
gchar* account_name = g_strdup("an_account");
char* room = "room@conf.server.org";
char* nick = "bob";
gchar* args[] = { room, "nick", nick, NULL };
@@ -122,9 +122,9 @@ cmd_join_uses_supplied_nick(void** state)
void
cmd_join_uses_account_nick_when_not_supplied(void** state)
{
char* account_name = g_strdup("an_account");
gchar* account_name = g_strdup("an_account");
char* room = "room2@conf.server.org";
char* account_nick = g_strdup("a_nick");
gchar* account_nick = g_strdup("a_nick");
gchar* args[] = { room, NULL };
ProfAccount* account = account_new(account_name, g_strdup("user@server.org"), NULL, NULL,
TRUE, NULL, 0, g_strdup("laptop"), NULL, NULL, 0, 0, 0, 0, 0, NULL, account_nick, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, 0);
@@ -150,11 +150,11 @@ cmd_join_uses_account_nick_when_not_supplied(void** state)
void
cmd_join_uses_password_when_supplied(void** state)
{
char* account_name = g_strdup("an_account");
gchar* account_name = g_strdup("an_account");
char* room = "room";
char* password = "a_password";
char* account_nick = g_strdup("a_nick");
char* account_service = g_strdup("a_service");
gchar* account_nick = g_strdup("a_nick");
gchar* account_service = g_strdup("a_service");
char* expected_room = "room@a_service";
gchar* args[] = { room, "password", password, NULL };
ProfAccount* account = account_new(account_name, g_strdup("user@server.org"), NULL, NULL,

2
tests/unittests/test_cmd_otr.c
View File

@@ -194,7 +194,7 @@ void
cmd_otr_gen_generates_key_for_connected_account(void** state)
{
gchar* args[] = { "gen", NULL };
char* account_name = g_strdup("myaccount");
gchar* account_name = g_strdup("myaccount");
ProfAccount* account = account_new(account_name, g_strdup("me@jabber.org"), NULL, NULL,
TRUE, NULL, 0, NULL, NULL, NULL, 0, 0, 0, 0, 0, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, 0);

4
tests/unittests/test_common.c
View File

@@ -400,7 +400,7 @@ unique_filename_from_url_td(void** state)
{
enum table { num_tests = 15 };
char* pwd = g_get_current_dir();
auto_gchar gchar* pwd = g_get_current_dir();
unique_filename_from_url_t tests[num_tests] = {
(unique_filename_from_url_t){
@@ -506,8 +506,6 @@ unique_filename_from_url_td(void** state)
free(got_filename);
free(exp_filename);
}
g_free(pwd);
}
gboolean