devs/profanity
2
0
Fork 0
mirror of https://git.jabber.space/devs/cproof.git synced 2026-07-27 04:06:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

inp_readline() Correct slashguard feature

Browse Source 
Protect against invalid reads by checking the length.
This commit is contained in:
Michael Vetter
2020-04-21 16:47:18 +02:00
parent f27bd92731
commit 813fd637a1
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/ui/inputwin.c
View File

@@ -197,10 +197,12 @@ inp_readline(void)
if (inp_line) { if (inp_line) {
if (!get_password && prefs_get_boolean(PREF_SLASH_GUARD)) { if (!get_password && prefs_get_boolean(PREF_SLASH_GUARD)) {
char *res = (char*) memchr (inp_line+1, '/', 3); if (strlen(inp_line) > 1) {
if (res) { char *res = (char*) memchr (inp_line+1, '/', 3);
cons_show("Your text contains a slash in the first 4 characters"); if (res) {
return NULL; cons_show("Your text contains a slash in the first 4 characters");
return NULL;
}
} }
} }
return strdup(inp_line); return strdup(inp_line);