devs/profanity
2
0
Fork 0
mirror of https://git.jabber.space/devs/cproof.git synced 2026-07-21 11:56:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix potential memleak in stanza_create_caps_from_query_element()

Browse Source 
Each of those should only occur one time. But let's make sure we only
write/alloc one time to be on the safe side.
This commit is contained in:
Michael Vetter
2020-04-20 15:31:48 +02:00
parent 95b75a2948
commit 9e460973fa
1 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/xmpp/stanza.c
View File

@@ -1784,13 +1784,21 @@ stanza_create_caps_from_query_element(xmpp_stanza_t *query)
formField = field->data; formField = field->data;
if (formField->values) { if (formField->values) {
if (strcmp(formField->var, "software") == 0) { if (strcmp(formField->var, "software") == 0) {
software = strdup(formField->values->data); if (software == NULL) {
software = strdup(formField->values->data);
}
} else if (strcmp(formField->var, "software_version") == 0) { } else if (strcmp(formField->var, "software_version") == 0) {
software_version = strdup(formField->values->data); if (software_version == NULL) {
software_version = strdup(formField->values->data);
}
} else if (strcmp(formField->var, "os") == 0) { } else if (strcmp(formField->var, "os") == 0) {
os = strdup(formField->values->data); if (os == NULL) {
os = strdup(formField->values->data);
}
} else if (strcmp(formField->var, "os_version") == 0) { } else if (strcmp(formField->var, "os_version") == 0) {
os_version = strdup(formField->values->data); if (os_version == NULL) {
os_version = strdup(formField->values->data);
}
} }
} }
field = g_slist_next(field); field = g_slist_next(field);