devs/profanity
2
0
Fork 0
mirror of https://git.jabber.space/devs/cproof.git synced 2026-07-30 23:06:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Added test for jid validation on /bookmark add

Browse Source
This commit is contained in:
James Booth
2014-08-18 21:25:52 +01:00
parent e87eb4c40e
commit a564b0241f
3 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
tests/test_cmd_bookmark.c
View File

@@ -126,6 +126,24 @@ void cmd_bookmark_list_shows_bookmarks(void **state)
g_list_free_full(bookmarks, (GDestroyNotify)_free_bookmark); g_list_free_full(bookmarks, (GDestroyNotify)_free_bookmark);
} }
void cmd_bookmark_add_shows_message_when_invalid_jid(void **state)
{
mock_bookmark_add();
mock_cons_show();
char *jid = "room";
CommandHelp *help = malloc(sizeof(CommandHelp));
gchar *args[] = { "add", jid, NULL };
mock_connection_status(JABBER_CONNECTED);
expect_cons_show("Can't add bookmark with JID 'room'; should be 'room@domain.tld'");
gboolean result = cmd_bookmark(args, *help);
assert_true(result);
free(help);
}
void cmd_bookmark_add_adds_bookmark_with_jid(void **state) void cmd_bookmark_add_adds_bookmark_with_jid(void **state)
{ {
mock_bookmark_add(); mock_bookmark_add();
@@ -240,4 +258,4 @@ void cmd_bookmark_remove_shows_message_when_no_bookmark(void **state)
assert_true(result); assert_true(result);
free(help); free(help);
} }

1
tests/test_cmd_bookmark.h
View File

@@ -5,6 +5,7 @@ void cmd_bookmark_shows_message_when_started(void **state);
void cmd_bookmark_shows_message_when_undefined(void **state); void cmd_bookmark_shows_message_when_undefined(void **state);
void cmd_bookmark_shows_usage_when_no_args(void **state); void cmd_bookmark_shows_usage_when_no_args(void **state);
void cmd_bookmark_list_shows_bookmarks(void **state); void cmd_bookmark_list_shows_bookmarks(void **state);
void cmd_bookmark_add_shows_message_when_invalid_jid(void **state);
void cmd_bookmark_add_adds_bookmark_with_jid(void **state); void cmd_bookmark_add_adds_bookmark_with_jid(void **state);
void cmd_bookmark_add_adds_bookmark_with_jid_nick(void **state); void cmd_bookmark_add_adds_bookmark_with_jid_nick(void **state);
void cmd_bookmark_add_adds_bookmark_with_jid_autojoin(void **state); void cmd_bookmark_add_adds_bookmark_with_jid_autojoin(void **state);

1
tests/testsuite.c
View File

@@ -432,6 +432,7 @@ int main(int argc, char* argv[]) {
unit_test(cmd_bookmark_shows_message_when_undefined), unit_test(cmd_bookmark_shows_message_when_undefined),
unit_test(cmd_bookmark_shows_usage_when_no_args), unit_test(cmd_bookmark_shows_usage_when_no_args),
unit_test(cmd_bookmark_list_shows_bookmarks), unit_test(cmd_bookmark_list_shows_bookmarks),
unit_test(cmd_bookmark_add_shows_message_when_invalid_jid),
unit_test(cmd_bookmark_add_adds_bookmark_with_jid), unit_test(cmd_bookmark_add_adds_bookmark_with_jid),
unit_test(cmd_bookmark_add_adds_bookmark_with_jid_nick), unit_test(cmd_bookmark_add_adds_bookmark_with_jid_nick),
unit_test(cmd_bookmark_add_adds_bookmark_with_jid_autojoin), unit_test(cmd_bookmark_add_adds_bookmark_with_jid_autojoin),