From aa9dcf7b3a7434f1807c625c2afe834524ba7c8e Mon Sep 17 00:00:00 2001 From: Paul Fariello Date: Mon, 8 Apr 2019 11:20:12 +0200 Subject: [PATCH] Avoid use after free on default account Fix 1046 --- src/command/cmd_funcs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/command/cmd_funcs.c b/src/command/cmd_funcs.c index d280e6c8..b2f0ee7f 100644 --- a/src/command/cmd_funcs.c +++ b/src/command/cmd_funcs.c @@ -387,6 +387,7 @@ cmd_connect(ProfWin *window, const char *const command, gchar **args) } char *jid; + user = strdup(user); g_free(def); // connect with account @@ -413,7 +414,6 @@ cmd_connect(ProfWin *window, const char *const command, gchar **args) account->password = NULL; } else { cons_show("Error evaluating password, see logs for details."); - g_free(user); account_free(account); return TRUE; } @@ -444,6 +444,7 @@ cmd_connect(ProfWin *window, const char *const command, gchar **args) options_destroy(options); free(jid); + free(user); return TRUE; }