devs/profanity
2
0
Fork 0
mirror of https://git.jabber.space/devs/cproof.git synced 2026-07-27 11:06:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix yet another potential leak

Browse Source
This commit is contained in:
Will Song
2015-01-14 11:10:14 -06:00
parent b5d4a52dfa
commit dc43cc602c
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/command/commands.c
View File

@@ -138,6 +138,7 @@ cmd_connect(gchar **args, struct cmd_help_t help)
// Evaluate as shell command to retrieve password // Evaluate as shell command to retrieve password
GString *cmd = g_string_append(g_string_new(account->eval_password), " 2>/dev/null"); GString *cmd = g_string_append(g_string_new(account->eval_password), " 2>/dev/null");
FILE *stream = popen(cmd->str, "r"); FILE *stream = popen(cmd->str, "r");
g_string_free(cmd, TRUE);
if(stream){ if(stream){
// Limit to READ_BUF_SIZE bytes to prevent overflows in the case of a poorly chosen command // Limit to READ_BUF_SIZE bytes to prevent overflows in the case of a poorly chosen command
account->password = g_malloc(READ_BUF_SIZE); account->password = g_malloc(READ_BUF_SIZE);
@@ -158,7 +159,6 @@ cmd_connect(gchar **args, struct cmd_help_t help)
cons_show("Error evaluating password, see logs for details."); cons_show("Error evaluating password, see logs for details.");
return TRUE; return TRUE;
} }
g_string_free(cmd, TRUE);
} else if (!account->password) { } else if (!account->password) {
account->password = ui_ask_password(); account->password = ui_ask_password();
} }