Steffen Jaeckel
c0da36c48d
Rage-cleanup.
...
While trying to get the unit tests working again I stumbled over all those
things that I thought could be better^TM.
Now we also know "TODO: why does this make the test fail?" - because
the unit tests are brittle AF ... and we have to init the subsystems
we use in the test, otherwise the cleanup will fail...
BTW. you can now also only run a single test ... or a pattern or so ...
you'd have to read how `cmocka_set_test_filter()` works exactly.
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu >
2025-03-10 11:45:15 +01:00
Steffen Jaeckel
72b99ceb6d
Some minor improvements
...
* destroy/free/shutdown/close in reverse order of allocation
* more static/auto_Xfree
* less variables/strlen/GString
* properly `\0`-terminate string of testcase
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu >
2025-03-10 11:45:15 +01:00
John Hernandez
865a056315
Cleanup g_strfreev() to auto_gcharv
...
Include some additional minor cleanups
2023-07-13 17:05:07 +02:00
Sergei Trofimovich
753d9dbbdb
src/plugins/callbacks.c: drop redundant NULL pointer check
...
gcc-12 detects redundant check against array of arrays as:
src/plugins/callbacks.c: In function ‘_free_command_help’:
src/plugins/callbacks.c:85:26: error: the comparison will always evaluate as ‘true’ for the address of ‘args’ will never be NULL [-Werror=address]
85 | while (help->args[i] != NULL && help->args[i][0] != NULL) {
| ^~
In file included from ./src/ui/ui.h:44,
from ./src/command/cmd_defs.h:42,
from src/plugins/callbacks.c:41:
./src/command/cmd_funcs.h:48:12: note: ‘args’ declared here
48 | gchar* args[128][2];
| ^~~~
2021-11-18 22:27:20 +00:00
Michael Vetter
057c9ad776
Add config.h in files were it was missing
...
Related to https://github.com/profanity-im/profanity/issues/1512
2021-03-26 19:54:22 +01:00
Michael Vetter
a2726b6a7d
Apply coding style
2020-07-07 14:18:57 +02:00
Michael Vetter
a4cadf78fa
Revert "Apply coding style"
...
This reverts commit 9b55f2dec0 .
Sorting the includes creates some problems.
2020-07-07 13:53:30 +02:00
Michael Vetter
9b55f2dec0
Apply coding style
...
Regards https://github.com/profanity-im/profanity/issues/1396
2020-07-07 09:43:28 +02:00
Michael Vetter
46fd7150e5
Add vim modeline
2019-11-13 12:11:05 +01:00
Michael Vetter
d43bd8f253
Add comment about dead assignment in callback_add_timed
2019-08-23 10:13:45 +02:00
Michael Vetter
706af9a900
Update copyright to include 2019
2019-01-22 11:31:45 +01:00
James Booth
250e972b7a
Update copyright
2018-01-21 15:00:02 +00:00
James Booth
68a3daedb9
Update Copyright
2017-01-28 17:24:22 +00:00
James Booth
d485588a07
Remove hash table replace entry when adding plugin timed callbacks
...
fixes #869
2016-10-09 23:37:36 +01:00
James Booth
d5d04756ce
Fix memory leaks
2016-07-25 22:23:54 +01:00
James Booth
0a57c4de78
Tidy headers
2016-07-24 15:43:51 +01:00
James Booth
5bc38b6bc2
Moved window_list.c
2016-07-24 15:14:46 +01:00
James Booth
47dfa6c3fc
Merge branch 'master' into python3
...
Conflicts:
.gitignore
2016-07-24 01:22:29 +01:00
James Booth
e8fc80f5c1
Update GPL link in headers
2016-07-24 01:14:49 +01:00
James Booth
d2e237203c
Check for win callback hash before removing
2016-07-21 22:23:28 +01:00
James Booth
5f393a6d9f
Remove plugin window on /close
2016-07-12 02:16:12 +01:00
James Booth
1a7eb00763
Check for plugin win before creating
2016-07-12 01:51:27 +01:00
James Booth
1926ceea3d
Plugin unload remove cmd_acs and close window
2016-07-05 22:46:00 +01:00
James Booth
82458c9d96
Revert "Move adding plugins commands to autocompleters"
...
This reverts commit 97f7997025 .
2016-07-05 22:11:58 +01:00
James Booth
97f7997025
Move adding plugins commands to autocompleters
2016-07-05 22:10:41 +01:00
James Booth
fd218ac3e4
Pass plugin name to all autocompleter functions
2016-07-04 23:14:08 +01:00
James Booth
c8d09083a8
Remove plugin callbacks in plugin_destroy functions
2016-07-04 22:54:55 +01:00
James Booth
0d7b4cb4a7
Store plugin window callbacks by plugin name
2016-07-04 22:42:15 +01:00
James Booth
a779ad0764
Use hash table for plugin timed functions
2016-07-04 21:48:04 +01:00
James Booth
71879a3f64
Free plugins commands on quit
2016-07-04 00:41:29 +01:00
James Booth
606a860bdc
Rename callback execte and destroy functions
2016-07-03 01:03:05 +01:00
James Booth
29eb843d56
Revert "WIP - Unload plugin commands"
...
This reverts commit a01eb5d08e .
2016-06-30 22:37:52 +01:00
James Booth
a01eb5d08e
WIP - Unload plugin commands
2016-06-29 23:35:57 +01:00
James Booth
fb34785566
Rename command sources
2016-05-22 23:59:52 +01:00
James Booth
eaf2901b01
Add cmd_autocomplete.c
2016-05-20 00:19:03 +01:00
James Booth
c91ce78a04
Added missing include in callbacks.c
2016-03-31 20:16:53 +01:00
James Booth
1075f07ff5
Parse plugin args with freetext parser
...
Also allow adding to plugin autocompleters
2016-03-15 22:32:44 +00:00
James Booth
5cabcf9b79
Plugins: Added callbacks init and close functions
...
Included destroy function in PluginWindowCallback
2016-03-07 20:36:25 +00:00
James Booth
0ed3b53bd2
Integrated plugins with /help command
2016-02-18 21:53:20 +00:00
James Booth
a152d7fb8e
Added cmd_help_autocomplete_add
2016-02-18 21:14:12 +00:00
James Booth
a14b7815ae
Added new help format to c plugins WIP
2016-02-18 01:20:37 +00:00
James Booth
7945ef5277
Fix plugin command memleak
2016-02-15 00:09:51 +00:00
James Booth
3dd5c3b2c3
Updated copyright
2016-02-14 23:12:01 +00:00
James Booth
41fe8c22b1
Added C plugin code from plugins branch
2016-02-14 22:28:55 +00:00