Steffen Jaeckel 48ac88de08 Fix GError handling ...

Several users have reported segfaults when starting up profanity which
has OMEMO support, but OMEMO is not set up yet.

@StefanKropp has been able to reproduce this and tracked it down to
`_load_identity()` calling `omemo_known_devices_keyfile_save()`.
The latter then calls `save_keyfile()` which calls
`g_key_file_save_to_file()`. This can then fail if one of the first two
strings is NULL and won't set the `error` on return. In its error handling
`save_keyfile()` unconditionally dereferences `error` which leads to the
segfault.

Fix this and also go through the entire codebase and verify that the usage
of `GError` is done correctly.

Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>

2025-11-18 12:16:29 +01:00

..

ISSUE_TEMPLATE

Add feature request template

2025-08-21 09:26:17 +02:00

workflows

Fix GError handling

2025-11-18 12:16:29 +01:00

FUNDING.yml

Remove Patreon

2022-02-16 12:21:18 +01:00

pull_request_template.md

Minor changes

2023-10-04 17:02:10 +02:00