mirror of
https://git.jabber.space/devs/cproof.git
synced 2026-07-19 02:56:21 +00:00
Jabber Developer
72f4f186da
Sync with upstream profanity-im/profanity.
Major upstream changes incorporated:
Memory management
- Replace malloc+memset with g_new0 throughout codebase
- Adopt auto_gchar / auto_gcharv / auto_gerror / auto_jid cleanup macros
- Replace free() with g_free() for GAlloc'd memory
Editor rewrite
- Remove pthread-based async editor; use GChildWatch callback API
- New launch_editor(initial_content, callback, user_data) interface
- Proper signal handling (SIGINT, SIGTSTP, SIGPIPE reset in child)
- ui_suspend()/ui_resume() integration for TTY management
OMEMO improvements
- Dual backend support: libsignal-protocol-c and libomemo-c
- Proper pre-key removal after use (XEP-0384 compliance)
- Automatic pre-key regeneration when store drops below threshold
- New functions: omemo_is_device_active(), omemo_is_jid_trusted()
- omemo_get_jid_untrusted_fingerprints() for better error messages
- Fingerprint notifications on new device identity discovery
- Deterministic pre-key ID generation tracking max_pre_key_id
- omemo_trust_changed() UI updates on trust state changes
JID validation
- RFC 6122-compliant validation in jid_is_valid()
- Character-level checks (RFC 6122 forbidden chars: & ' / : < > @)
- Length limits: 1023 per component, 3071 total
- New jid_is_valid_user_jid() for user vs. service JID distinction
Database
- Schema migration v3: UNIQUE constraint on archive_id for deduplication
- Triggers for corrected message tracking (replaces_db_id / replaced_by_db_id)
- db_history_result_t return type, _truncate_datetime_suffix()
UI / console
- win_warn_needed() / win_warn_sent() warning deduplication hash table
- PAD_MIN_HEIGHT dynamic pad sizing with PAD_THRESHOLD auto-cleanup
- Spellcheck integration in input field with Unicode word detection
- cons_spellcheck_setting() for /settings ui output
- /[command]? shortcut for command help
Account config
- Account name sanitization for GKeyFile special chars ([ ] = # \n \r)
- Replace popen() with g_spawn_sync() for eval_password
- TLS policy: add "direct" option alongside legacy
Connection
- Port validation with g_assert (0–65535)
- SHA-256 certificate fingerprint support (XMPP_CERT_PUBKEY_FINGERPRINT_SHA256)
- "direct" TLS policy alias for legacy SSL
Common utilities
- str_xml_sanitize() for XML 1.0 illegal character removal
- string_matches_one_of() with formatted error messages
- valid_tls_policy_option() helper
- prof_date_time_format_iso8601() utility
- Improved strip_arg_quotes() with backslash unescaping
- prof_occurrences() uses g_slist_prepend + reverse for performance
PGP / OX
- Proper GPGME resource cleanup with goto-cleanup pattern
- g_string_free(xmppuri) leak fix in _ox_key_lookup
CSV export
- Use GString + g_file_set_contents instead of raw write() syscalls
Tests
- Restructured into subdirectories: command/, config/, xmpp/, ui/, omemo/, otr/, pgp/
- New test_cmd_ac.c for autocompleter unit tests
- Updated stubs for new UI suspend/resume functions
License headers
- Migrate to SPDX-3.0 identifiers (GPL-3.0-or-later WITH OpenSSL-exception)
────────────────────────────────────────────────────
cproof-specific preservations:
- XEP-0308 LMC: replace_id ?: id logic in message/stanza/omemo
- Force encryption: cmd_force_encryption, test_forced_encryption
- CWE-134: format string protection (cons_show("%s", ...))
- y_start_pos-based paging in window.c
- db_history_result_t return type, _truncate_datetime_suffix()
Merge-time fixes:
- common.c: format-security (-Werror) — cons_show(errmsg) → cons_show("%s", errmsg)
- database.c: null-deref guard — !msg->timestamp → msg && !msg->timestamp
- console.c: implicit size_t → int cast — (int)(maxlen + 1)
- tlscerts.c: %d for size_t — %zu
Build system:
- Kept autotools (Makefile.am, configure.ac); upstream uses Meson
- Restored deleted files: bootstrap.sh, autogen.sh, ax_valgrind_check.m4, configure-debug
- Updated Makefile.am test paths for subdirectory structure
- Added test_cmd_ac, test_forced_encryption to test sources
Functional tests:
- Use cproof version; upstream requires stbbr_for_xmlns from updated stabber
- Not yet available in devs/stabber fork
Closes #64
Merge author: jabber.developer2
Commits authors:
Michael Vetter <jubalh@iodoru.org>
& Steffen Jaeckel <s@jaeckel.eu>
87 lines
3.3 KiB
C
87 lines
3.3 KiB
C
/*
|
|
* window_list.h
|
|
* vim: expandtab:ts=4:sts=4:sw=4
|
|
*
|
|
* Copyright (C) 2012 - 2019 James Booth <boothj5@gmail.com>
|
|
*
|
|
* SPDX-License-Identifier: GPL-3.0-or-later WITH OpenSSL-exception
|
|
*/
|
|
|
|
#ifndef UI_WINDOW_LIST_H
|
|
#define UI_WINDOW_LIST_H
|
|
|
|
#include "ui/ui.h"
|
|
|
|
void wins_init(void);
|
|
|
|
ProfWin* wins_new_xmlconsole(void);
|
|
ProfWin* wins_new_chat(const char* const barejid);
|
|
ProfWin* wins_new_muc(const char* const roomjid);
|
|
ProfWin* wins_new_config(const char* const roomjid, DataForm* form, ProfConfWinCallback submit, ProfConfWinCallback cancel, const void* userdata);
|
|
ProfWin* wins_new_private(const char* const fulljid);
|
|
ProfWin* wins_new_plugin(const char* const plugin_name, const char* const tag);
|
|
ProfWin* wins_new_vcard(vCard* vcard);
|
|
|
|
gboolean wins_chat_exists(const char* const barejid);
|
|
GList* wins_get_private_chats(const char* const roomjid);
|
|
void wins_private_nick_change(const char* const roomjid, const char* const oldnick, const char* const newnick);
|
|
void wins_change_nick(const char* const barejid, const char* const oldnick, const char* const newnick);
|
|
void wins_remove_nick(const char* const barejid, const char* const oldnick);
|
|
|
|
ProfWin* wins_get_console(void);
|
|
ProfChatWin* wins_get_chat(const char* const barejid);
|
|
GList* wins_get_chat_unsubscribed(void);
|
|
ProfMucWin* wins_get_muc(const char* const roomjid);
|
|
ProfConfWin* wins_get_conf(const char* const roomjid);
|
|
ProfPrivateWin* wins_get_private(const char* const fulljid);
|
|
ProfPluginWin* wins_get_plugin(const char* const tag);
|
|
ProfXMLWin* wins_get_xmlconsole(void);
|
|
ProfVcardWin* wins_get_vcard(void);
|
|
gboolean wins_ai_exists(ProfAiWin* const aiwin);
|
|
|
|
void wins_close_plugin(char* tag);
|
|
|
|
ProfWin* wins_get_current(void);
|
|
|
|
void wins_set_current_by_num(int i);
|
|
|
|
ProfWin* wins_get_by_num(int i);
|
|
ProfWin* wins_get_by_string(const char* str);
|
|
|
|
ProfWin* wins_get_next(void);
|
|
ProfWin* wins_get_previous(void);
|
|
ProfWin* wins_get_next_unread(void);
|
|
ProfWin* wins_get_next_attention(void);
|
|
int wins_get_num(ProfWin* window);
|
|
int wins_get_current_num(void);
|
|
void wins_close_by_num(int i);
|
|
gboolean wins_is_current(ProfWin* window);
|
|
gboolean wins_do_notify_remind(void);
|
|
int wins_get_total_unread(void);
|
|
void wins_resize_all(void);
|
|
GSList* wins_get_chat_recipients(void);
|
|
GSList* wins_get_prune_wins(void);
|
|
void wins_lost_connection(void);
|
|
void wins_reestablished_connection(void);
|
|
void wins_omemo_trust_changed(const char* const jid);
|
|
gboolean wins_tidy(void);
|
|
GSList* wins_create_summary(gboolean unread);
|
|
GSList* wins_create_summary_attention();
|
|
void wins_destroy(void);
|
|
GList* wins_get_nums(void);
|
|
void wins_swap(int source_win, int target_win);
|
|
void wins_hide_subwin(ProfWin* window);
|
|
void wins_show_subwin(ProfWin* window);
|
|
|
|
char* win_autocomplete(const char* const search_str, gboolean previous, void* context);
|
|
void win_reset_search_attempts(void);
|
|
char* win_close_autocomplete(const char* const search_str, gboolean previous, void* context);
|
|
void win_close_reset_search_attempts(void);
|
|
|
|
void wins_add_urls_ac(const ProfWin* const win, const ProfMessage* const message, const gboolean flip);
|
|
char* wins_get_url(const char* const search_str, gboolean previous, void* context);
|
|
void wins_add_quotes_ac(const ProfWin* const win, const char* const message, const gboolean flip);
|
|
char* wins_get_quote(const char* const search_str, gboolean previous, void* context);
|
|
|
|
#endif
|