mirror of
https://git.jabber.space/devs/cproof.git
synced 2026-07-25 06:56:21 +00:00
jabber.developer2
4401e817d0
Apply fixes, refactors and test additions requested by reviewer on PR #105. Fixes: - database: warn and notify user on duplicate archive_id instead of silently debug-logging it (R05). - database: add missing '[' in "[DB Migration]" log prefix (R06). - xmpp/resource: NULL-out name/status after g_free to avoid double-free via roster_list.c cleanup path (R09, R23). - common: widen strtoi_range internal storage from int to long so that values in (INT_MAX, LONG_MAX] are rejected as out-of-range instead of being silently truncated on 64-bit platforms (R25). Refactors: - xmpp/message: extract _receive_omemo helper, removing three copies of the OMEMO receive block in groupchat / MUC-PM / chat handlers (R04). - omemo: flatten deeply nested device-list processing via guard-clause continues (R11). - tools/autocomplete: merge two nested ifs into a single && condition (R13). - ui/titlebar: extract _show_trust_indicator and inline _wprintw_withattr wrapper, collapsing three near-identical trust-indicator blocks (R22). - config/tlscerts: drop _checked_g_strdup wrapper; g_strdup is NULL-safe per glib documentation (R19). - ui/inputwin: use auto_gchar for spellcheck word instead of manual g_free (R20). - tools/editor: drop outdated "Deprecated synchronous" comment that no longer matches the callback-based implementation (R28). Tests: - tests/command/cmd_ac: rename segfaults_when_empty -> no_segfault_when_empty; expand cycling coverage to three files plus backward SHIFT-TAB traversal (R16, R17). - tests/common: add strtoi_range overflow/underflow and strtol-parsing consistency tests (R25). - tests/xmpp/jid: add test for '@' inside resourcepart per RFC 6122 section 2.4 (R26). Misc: - xmpp/omemo: change omemo_error_to_string return type from char* to gchar* for glib consistency (R01). - subprojects/libstrophe: point wrap-git at our fork at git.jabber.space/devs/libstrophe-gh (R24). - RELEASE_GUIDE: drop "Updating website" section referring to an upstream site that is not ours (R18).
373 lines
9.7 KiB
C
373 lines
9.7 KiB
C
#include "prof_cmocka.h"
|
|
#include <stdlib.h>
|
|
|
|
#include "xmpp/jid.h"
|
|
|
|
void
|
|
jid_create__returns__null_from_null(void** state)
|
|
{
|
|
Jid* result = jid_create(NULL);
|
|
assert_null(result);
|
|
}
|
|
|
|
void
|
|
jid_create__returns__null_from_empty_string(void** state)
|
|
{
|
|
Jid* result = jid_create("");
|
|
assert_null(result);
|
|
}
|
|
|
|
void
|
|
jid_create__returns__full_from_full(void** state)
|
|
{
|
|
Jid* result = jid_create("myuser@mydomain/laptop");
|
|
assert_string_equal("myuser@mydomain/laptop", result->fulljid);
|
|
jid_destroy(result);
|
|
}
|
|
|
|
void
|
|
jid_create__returns__bare_from_full(void** state)
|
|
{
|
|
Jid* result = jid_create("myuser@mydomain/laptop");
|
|
assert_string_equal("myuser@mydomain", result->barejid);
|
|
jid_destroy(result);
|
|
}
|
|
|
|
void
|
|
jid_create__returns__resourcepart_from_full(void** state)
|
|
{
|
|
Jid* result = jid_create("myuser@mydomain/laptop");
|
|
assert_string_equal("laptop", result->resourcepart);
|
|
jid_destroy(result);
|
|
}
|
|
|
|
void
|
|
jid_create__returns__localpart_from_full(void** state)
|
|
{
|
|
Jid* result = jid_create("myuser@mydomain/laptop");
|
|
assert_string_equal("myuser", result->localpart);
|
|
jid_destroy(result);
|
|
}
|
|
|
|
void
|
|
jid_create__returns__domainpart_from_full(void** state)
|
|
{
|
|
Jid* result = jid_create("myuser@mydomain/laptop");
|
|
assert_string_equal("mydomain", result->domainpart);
|
|
jid_destroy(result);
|
|
}
|
|
|
|
void
|
|
jid_create__returns__full_from_full_nolocal(void** state)
|
|
{
|
|
Jid* result = jid_create("mydomain/laptop");
|
|
assert_string_equal("mydomain/laptop", result->fulljid);
|
|
jid_destroy(result);
|
|
}
|
|
|
|
void
|
|
jid_create__returns__bare_from_full_nolocal(void** state)
|
|
{
|
|
Jid* result = jid_create("mydomain/laptop");
|
|
assert_string_equal("mydomain", result->barejid);
|
|
jid_destroy(result);
|
|
}
|
|
|
|
void
|
|
jid_create__returns__resourcepart_from_full_nolocal(void** state)
|
|
{
|
|
Jid* result = jid_create("mydomain/laptop");
|
|
assert_string_equal("laptop", result->resourcepart);
|
|
jid_destroy(result);
|
|
}
|
|
|
|
void
|
|
jid_create__returns__domainpart_from_full_nolocal(void** state)
|
|
{
|
|
Jid* result = jid_create("mydomain/laptop");
|
|
assert_string_equal("mydomain", result->domainpart);
|
|
jid_destroy(result);
|
|
}
|
|
|
|
void
|
|
jid_create__returns__null_localpart_from_full_nolocal(void** state)
|
|
{
|
|
Jid* result = jid_create("mydomain/laptop");
|
|
assert_null(result->localpart);
|
|
jid_destroy(result);
|
|
}
|
|
|
|
void
|
|
jid_create__returns__null_full_from_bare(void** state)
|
|
{
|
|
Jid* result = jid_create("myuser@mydomain");
|
|
assert_null(result->fulljid);
|
|
jid_destroy(result);
|
|
}
|
|
|
|
void
|
|
jid_create__returns__null_resource_from_bare(void** state)
|
|
{
|
|
Jid* result = jid_create("myuser@mydomain");
|
|
assert_null(result->resourcepart);
|
|
jid_destroy(result);
|
|
}
|
|
|
|
void
|
|
jid_create__returns__bare_from_bare(void** state)
|
|
{
|
|
Jid* result = jid_create("myuser@mydomain");
|
|
assert_string_equal("myuser@mydomain", result->barejid);
|
|
jid_destroy(result);
|
|
}
|
|
|
|
void
|
|
jid_create__returns__localpart_from_bare(void** state)
|
|
{
|
|
Jid* result = jid_create("myuser@mydomain");
|
|
assert_string_equal("myuser", result->localpart);
|
|
jid_destroy(result);
|
|
}
|
|
|
|
void
|
|
jid_create__returns__domainpart_from_bare(void** state)
|
|
{
|
|
Jid* result = jid_create("myuser@mydomain");
|
|
assert_string_equal("mydomain", result->domainpart);
|
|
jid_destroy(result);
|
|
}
|
|
|
|
void
|
|
jid_create_from_bare_and_resource__returns__room(void** state)
|
|
{
|
|
Jid* result = jid_create_from_bare_and_resource("room@conference.domain.org", "myname");
|
|
|
|
assert_string_equal("room@conference.domain.org", result->barejid);
|
|
jid_destroy(result);
|
|
}
|
|
|
|
void
|
|
jid_create_from_bare_and_resource__returns__nick(void** state)
|
|
{
|
|
Jid* result = jid_create_from_bare_and_resource("room@conference.domain.org", "myname");
|
|
|
|
assert_string_equal("myname", result->resourcepart);
|
|
jid_destroy(result);
|
|
}
|
|
|
|
void
|
|
jid_create__returns__correct_parts_with_slash_in_resource(void** state)
|
|
{
|
|
Jid* result = jid_create("room@conference.domain.org/my/nick");
|
|
|
|
assert_string_equal("room", result->localpart);
|
|
assert_string_equal("conference.domain.org", result->domainpart);
|
|
assert_string_equal("my/nick", result->resourcepart);
|
|
assert_string_equal("room@conference.domain.org", result->barejid);
|
|
assert_string_equal("room@conference.domain.org/my/nick", result->fulljid);
|
|
|
|
jid_destroy(result);
|
|
}
|
|
|
|
void
|
|
jid_create__returns__correct_parts_with_at_in_resource(void** state)
|
|
{
|
|
Jid* result = jid_create("room@conference.domain.org/my@nick");
|
|
|
|
assert_string_equal("room", result->localpart);
|
|
assert_string_equal("conference.domain.org", result->domainpart);
|
|
assert_string_equal("my@nick", result->resourcepart);
|
|
assert_string_equal("room@conference.domain.org", result->barejid);
|
|
assert_string_equal("room@conference.domain.org/my@nick", result->fulljid);
|
|
|
|
jid_destroy(result);
|
|
}
|
|
|
|
void
|
|
jid_create__returns__correct_parts_with_at_and_slash_in_resource(void** state)
|
|
{
|
|
Jid* result = jid_create("room@conference.domain.org/my@nick/something");
|
|
|
|
assert_string_equal("room", result->localpart);
|
|
assert_string_equal("conference.domain.org", result->domainpart);
|
|
assert_string_equal("my@nick/something", result->resourcepart);
|
|
assert_string_equal("room@conference.domain.org", result->barejid);
|
|
assert_string_equal("room@conference.domain.org/my@nick/something", result->fulljid);
|
|
|
|
jid_destroy(result);
|
|
}
|
|
|
|
void
|
|
jid_create__returns__correct_parts_with_trailing_slash(void** state)
|
|
{
|
|
Jid* result = jid_create("room@conference.domain.org/nick/");
|
|
|
|
assert_string_equal("room", result->localpart);
|
|
assert_string_equal("conference.domain.org", result->domainpart);
|
|
assert_string_equal("nick/", result->resourcepart);
|
|
assert_string_equal("room@conference.domain.org", result->barejid);
|
|
assert_string_equal("room@conference.domain.org/nick/", result->fulljid);
|
|
|
|
jid_destroy(result);
|
|
}
|
|
|
|
void
|
|
jid_fulljid_or_barejid__returns__fulljid_when_exists(void** state)
|
|
{
|
|
Jid* jid = jid_create("localpart@domainpart/resourcepart");
|
|
|
|
const gchar* result = jid_fulljid_or_barejid(jid);
|
|
|
|
assert_string_equal("localpart@domainpart/resourcepart", result);
|
|
|
|
jid_destroy(jid);
|
|
}
|
|
|
|
void
|
|
jid_fulljid_or_barejid__returns__barejid_when_fulljid_not_exists(void** state)
|
|
{
|
|
Jid* jid = jid_create("localpart@domainpart");
|
|
|
|
const gchar* result = jid_fulljid_or_barejid(jid);
|
|
|
|
assert_string_equal("localpart@domainpart", result);
|
|
|
|
jid_destroy(jid);
|
|
}
|
|
|
|
void
|
|
jid_create__returns__bare_from_trailing_slash(void** state)
|
|
{
|
|
Jid* result = jid_create("myuser@mydomain/");
|
|
assert_non_null(result);
|
|
assert_string_equal("myuser@mydomain", result->barejid);
|
|
assert_null(result->resourcepart);
|
|
jid_destroy(result);
|
|
}
|
|
|
|
void
|
|
jid_create__returns__null_from_invalid_localpart_chars(void** state)
|
|
{
|
|
// Space
|
|
Jid* result = jid_create("user name@domain.com");
|
|
assert_null(result);
|
|
|
|
// Double quote
|
|
result = jid_create("user\"name@domain.com");
|
|
assert_null(result);
|
|
|
|
// Ampersand
|
|
result = jid_create("user&name@domain.com");
|
|
assert_null(result);
|
|
|
|
// Single quote
|
|
result = jid_create("user'name@domain.com");
|
|
assert_null(result);
|
|
|
|
// Colon
|
|
result = jid_create("user:name@domain.com");
|
|
assert_null(result);
|
|
|
|
// Less than
|
|
result = jid_create("user<name@domain.com");
|
|
assert_null(result);
|
|
|
|
// Greater than
|
|
result = jid_create("user>name@domain.com");
|
|
assert_null(result);
|
|
}
|
|
|
|
void
|
|
jid_create__returns__null_from_empty_parts(void** state)
|
|
{
|
|
// Empty local
|
|
Jid* result = jid_create("@domain.com");
|
|
assert_null(result);
|
|
|
|
// Empty domain (trailing @)
|
|
result = jid_create("user@");
|
|
assert_null(result);
|
|
|
|
// Empty domain in full jid
|
|
result = jid_create("user@/resource");
|
|
assert_null(result);
|
|
}
|
|
|
|
void
|
|
jid_create__returns__null_from_multiple_at_in_bare(void** state)
|
|
{
|
|
Jid* result = jid_create("user@domain@other.com");
|
|
assert_null(result);
|
|
}
|
|
|
|
void
|
|
jid_create__returns__correct_parts_with_at_in_resource_only(void** state)
|
|
{
|
|
// domain.com/user@host (no localpart)
|
|
Jid* result = jid_create("domain.com/user@host");
|
|
assert_non_null(result);
|
|
assert_null(result->localpart);
|
|
assert_string_equal("domain.com", result->domainpart);
|
|
assert_string_equal("user@host", result->resourcepart);
|
|
jid_destroy(result);
|
|
}
|
|
|
|
void
|
|
jid_is_valid_user_jid__is__true_for_valid_user_jid(void** state)
|
|
{
|
|
assert_true(jid_is_valid_user_jid("myuser@mydomain/laptop"));
|
|
assert_true(jid_is_valid_user_jid("myuser@mydomain"));
|
|
}
|
|
|
|
void
|
|
jid_is_valid_user_jid__is__true_for_at_in_resource(void** state)
|
|
{
|
|
// RFC 6122 section 2.4: '@' is allowed in the resourcepart.
|
|
assert_true(jid_is_valid_user_jid("myuser@mydomain/user@laptop"));
|
|
assert_true(jid_is_valid_user_jid("room@conference.example.org/user@host.example.org"));
|
|
}
|
|
|
|
void
|
|
jid_is_valid_user_jid__is__false_for_domain_jid(void** state)
|
|
{
|
|
assert_false(jid_is_valid_user_jid("mydomain/laptop"));
|
|
assert_false(jid_is_valid_user_jid("mydomain"));
|
|
}
|
|
|
|
void
|
|
jid_is_valid_user_jid__is__false_for_invalid_jid(void** state)
|
|
{
|
|
assert_false(jid_is_valid_user_jid("@mydomain"));
|
|
assert_false(jid_is_valid_user_jid("/laptop"));
|
|
assert_false(jid_is_valid_user_jid(NULL));
|
|
assert_false(jid_is_valid_user_jid(""));
|
|
}
|
|
|
|
void
|
|
jid_is_valid__is__true_for_valid_jid(void** state)
|
|
{
|
|
assert_true(jid_is_valid("myuser@mydomain/laptop"));
|
|
assert_true(jid_is_valid("myuser@mydomain"));
|
|
assert_true(jid_is_valid("mydomain/laptop"));
|
|
assert_true(jid_is_valid("mydomain"));
|
|
}
|
|
|
|
void
|
|
jid_is_valid__is__false_for_invalid_jid(void** state)
|
|
{
|
|
assert_false(jid_is_valid("@mydomain"));
|
|
assert_false(jid_is_valid("/laptop"));
|
|
}
|
|
|
|
void
|
|
jid_is_valid__is__false_for_null(void** state)
|
|
{
|
|
assert_false(jid_is_valid(NULL));
|
|
}
|
|
|
|
void
|
|
jid_is_valid__is__false_for_empty_string(void** state)
|
|
{
|
|
assert_false(jid_is_valid(""));
|
|
}
|