jabber.developer

jabber.developer commented on pull request devs/cproof#63

2025-12-30 16:39:18 +00:00

fix/functional_tests

TODO: review actuality.

jabber.developer commented on pull request devs/cproof#63

2025-12-30 16:39:18 +00:00

fix/functional_tests

I suggest removing it. It feels rather unnecessary + no justification is provided for it.

jabber.developer commented on pull request devs/cproof#63

2025-12-30 16:39:18 +00:00

fix/functional_tests

Same as above.

jabber.developer commented on pull request devs/cproof#63

2025-12-30 16:39:18 +00:00

fix/functional_tests

same as above.

jabber.developer commented on pull request devs/cproof#63

2025-12-30 16:39:18 +00:00

fix/functional_tests

Out of scope? Or is it related to the tests? If it is, then it's within the scope.

jabber.developer commented on pull request devs/cproof#63

2025-12-30 16:39:18 +00:00

fix/functional_tests

Seems rather inefficient. Do we restart a client and a server for each test?

jabber.developer commented on pull request devs/cproof#63

2025-12-30 16:39:18 +00:00

fix/functional_tests

Great addition!

jabber.developer commented on pull request devs/cproof#63

2025-12-30 16:39:18 +00:00

fix/functional_tests

Can we use wait_for... method from the Stabber? If it lacks the method, maybe it deserves another issue?

jabber.developer commented on pull request devs/cproof#63

2025-12-30 16:39:18 +00:00

fix/functional_tests

Why is it commented out?

jabber.developer commented on pull request devs/cproof#63

2025-12-30 16:39:18 +00:00

fix/functional_tests

Here and around: why is it regex, when exact should suffice?

jabber.developer commented on pull request devs/cproof#63

2025-12-30 16:39:18 +00:00

fix/functional_tests

What do we test for then in such case? If server supports, then we should expect successful ping, otherwise error. We can't just accept both variants, as it would mean that we don't test functionality.

jabber.developer suggested changes for devs/cproof#63

2025-12-30 16:39:18 +00:00

fix/functional_tests

Generally LGTM with a few questions and issues.

jabber.developer pushed to fix/functional_tests at devs/cproof

2025-12-15 14:55:20 +00:00

9472662c05 Update .gitmodules

jabber.developer closed pull request devs/cproof#16

2025-12-02 16:37:22 +00:00

build: autoupdate

jabber.developer approved devs/cproof#45

2025-11-28 11:41:00 +00:00

Fix scroll/paging state and buffer handling

jabber.developer deleted branch feat/api/get_current_window from devs/cproof

2025-11-27 10:42:06 +00:00

jabber.developer deleted branch fix/autoping-autodisable from devs/cproof

2025-11-27 10:41:59 +00:00

jabber.developer deleted branch build/fix/arch from devs/cproof

2025-11-27 10:41:51 +00:00

jabber.developer deleted branch fix/time_command_fix from devs/cproof

2025-11-27 10:41:38 +00:00

jabber.developer merged pull request devs/cproof#62

2025-11-27 10:41:25 +00:00

fix(cmd): cmd_time: avoid extra loop iterations for single option