fix(ui,db): harden NULL handling, fix CWE-134, optimize iterations
Some checks failed
CI Code / Code Coverage (push) Failing after 10m34s
CI Code / Check spelling (push) Failing after 10m47s
CI Code / Check coding style (push) Failing after 11m4s
CI Code / Linux (ubuntu) (push) Failing after 11m19s
CI Code / Linux (debian) (push) Failing after 11m28s
CI Code / Linux (arch) (push) Failing after 11m38s
Some checks failed
CI Code / Code Coverage (push) Failing after 10m34s
CI Code / Check spelling (push) Failing after 10m47s
CI Code / Check coding style (push) Failing after 11m4s
CI Code / Linux (ubuntu) (push) Failing after 11m19s
CI Code / Linux (debian) (push) Failing after 11m28s
CI Code / Linux (arch) (push) Failing after 11m38s
security(CWE-134): fix format string injections + add CI check fix(ui): subwindow lifecycle, newwin/newpad guards, fallback timestamps fix(db): sqlite cleanup on failures, sqlite3_close_v2 fix(xmpp): queued_messages loop, barejid leak perf(core): g_hash_table_iter_init instead of g_hash_table_get_keys refactor(ui): CLAMP macro in _check_subwin_width test: XEP-0012 and XEP-0045 functional tests Author: jabber.developer2 Closes #58, #85
This commit is contained in:
@@ -345,14 +345,13 @@ p_gpg_list_keys(void)
|
||||
|
||||
// TODO: move autocomplete in other place
|
||||
autocomplete_clear(key_ac);
|
||||
GList* ids = g_hash_table_get_keys(result);
|
||||
GList* curr = ids;
|
||||
while (curr) {
|
||||
ProfPGPKey* key = g_hash_table_lookup(result, curr->data);
|
||||
autocomplete_add(key_ac, key->id);
|
||||
curr = curr->next;
|
||||
GHashTableIter iter;
|
||||
gpointer key, value;
|
||||
g_hash_table_iter_init(&iter, result);
|
||||
while (g_hash_table_iter_next(&iter, &key, &value)) {
|
||||
ProfPGPKey* pgp_key = (ProfPGPKey*)value;
|
||||
autocomplete_add(key_ac, pgp_key->id);
|
||||
}
|
||||
g_list_free(ids);
|
||||
|
||||
return result;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user