devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

refactor: change vcard_print() checks

Browse Source 
data is allocated via g_new0() so cannot be NULL here.
And it was used before the check already so that didn't make any sense
in the first place.
This commit is contained in:
Michael Vetter
2026-02-27 20:17:41 +01:00
parent 1ec536d343
commit 776bc262d0
1 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/xmpp/vcard.c
View File

@@ -1229,10 +1229,8 @@ vcard_print(xmpp_ctx_t* ctx, ProfWin* window, char* jid)
_userdata* data = g_new0(_userdata, 1);
data->vcard = vcard_new();
if (!data || !data->vcard) {
if (data) {
g_free(data);
}
if (!data->vcard) {
g_free(data);
cons_show("vCard allocation failed");
return;
@@ -1379,10 +1377,8 @@ vcard_photo(xmpp_ctx_t* ctx, char* jid, char* filename, int index, gboolean open
_userdata* data = g_new0(_userdata, 1);
data->vcard = vcard_new();
if (!data || !data->vcard) {
if (data) {
free(data);
}
if (!data->vcard) {
g_free(data);
cons_show("vCard allocation failed");
return;