devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

Clean up keys after using parse_options

Browse Source
This commit is contained in:
James Booth
2014-04-14 23:41:45 +01:00
parent 3e69d6b71e
commit 79088d0150
2 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/command/commands.c
View File

@@ -93,6 +93,7 @@ cmd_connect(gchar **args, struct cmd_help_t help)
}
options_destroy(options);
g_list_free(opt_keys);
char *user = args[0];
char *lower = g_utf8_strdown(user, -1);
@@ -1587,6 +1588,7 @@ cmd_join(gchar **args, struct cmd_help_t help)
passwd = g_hash_table_lookup(options, "password");
options_destroy(options);
g_list_free(opt_keys);
// In the case that a nick wasn't provided by the optional args...
if (nick == NULL) {

9
tests/test_parser.c
View File

@@ -521,6 +521,7 @@ parse_options_when_none_returns_empty_hasmap(void **state)
assert_true(res);
options_destroy(options);
g_list_free(keys);
}
void
@@ -539,6 +540,7 @@ parse_options_when_opt1_no_val_sets_error(void **state)
assert_false(res);
options_destroy(options);
g_list_free(keys);
}
void
@@ -559,6 +561,7 @@ parse_options_when_one_returns_map(void **state)
assert_true(res);
options_destroy(options);
g_list_free(keys);
}
void
@@ -578,6 +581,7 @@ parse_options_when_opt2_no_val_sets_error(void **state)
assert_false(res);
options_destroy(options);
g_list_free(keys);
}
void
@@ -601,6 +605,7 @@ parse_options_when_two_returns_map(void **state)
assert_true(res);
options_destroy(options);
g_list_free(keys);
}
void
@@ -621,6 +626,7 @@ parse_options_when_opt3_no_val_sets_error(void **state)
assert_false(res);
options_destroy(options);
g_list_free(keys);
}
void
@@ -647,6 +653,7 @@ parse_options_when_three_returns_map(void **state)
assert_true(res);
options_destroy(options);
g_list_free(keys);
}
void
@@ -667,6 +674,7 @@ parse_options_when_unknown_opt_sets_error(void **state)
assert_false(res);
options_destroy(options);
g_list_free(keys);
}
void
@@ -687,4 +695,5 @@ parse_options_with_duplicated_option_sets_error(void **state)
assert_false(res);
options_destroy(options);
g_list_free(keys);
}