devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 8 Actions Packages Projects 1 Releases Wiki Activity

fix(ai): fix provider_name leak and const-cast in cmd_ai_start
Some checks failed
CI Code / Check spelling (pull_request) Successful in 55s
Details
CI Code / Linux (arch) (pull_request) Failing after 3m25s
Details
CI Code / Check coding style (pull_request) Successful in 1m38s
Details
CI Code / Linux (debian) (pull_request) Successful in 4m42s
Details
CI Code / Code Coverage (pull_request) Successful in 2m50s
Details
CI Code / Linux (ubuntu) (pull_request) Successful in 8m12s
Details

Browse Source 
Use auto_gchar temporary for g_strndup result in cmd_ai_start to
prevent memory leak. Fix const-cast warning by using a proper
non-const temporary variable.
This commit is contained in:
Jabber Developer
2026-04-30 19:14:49 +00:00
parent 93ad7379e2
commit 9e1f9b666e
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/command/cmd_funcs.c
View File

@@ -10760,13 +10760,15 @@ cmd_ai_start(ProfWin* window, const char* const command, gchar** args)
// /ai start [<provider>/<model>] // /ai start [<provider>/<model>]
const gchar* provider_model = (g_strv_length(args) >= 2) ? args[1] : NULL; const gchar* provider_model = (g_strv_length(args) >= 2) ? args[1] : NULL;
auto_gchar gchar* owned_provider_name = NULL;
const gchar* provider_name = "openai"; const gchar* provider_name = "openai";
const gchar* model = "gpt-4o"; const gchar* model = "gpt-4o";
if (provider_model) { if (provider_model) {
const gchar* slash = strchr(provider_model, '/'); const gchar* slash = strchr(provider_model, '/');
if (slash) { if (slash) {
provider_name = g_strndup(provider_model, slash - provider_model); owned_provider_name = g_strndup(provider_model, slash - provider_model);
provider_name = owned_provider_name;
model = slash + 1; model = slash + 1;
} else { } else {
// Just a model name, use default provider // Just a model name, use default provider