1241 Commits

Author	SHA1	Message	Date
jabber.developer2	46987dee77	fix: rare memleak in roster_list (upstream 2d7426fb)	2026-03-31 19:10:03 +03:00
jabber.developer2	a9ee765c49	fix: memory leak and crash when id is NULL in iq_id_handler_add (upstream 0218ba26)	2026-03-31 18:56:02 +03:00
jabber.developer2	0b7ec1c5b6	fix: potential segfault in log_database_get_limits_info (upstream ff65db0b)	2026-03-31 18:52:45 +03:00
Jabber Developer	9ec01fa8cc	fix: CWE-134 format string audit and compiler hardening ... Security: Fix CWE-134 in iq.c: user-controlled string passed as format argument Add G_GNUC_PRINTF annotations to all variadic printf-like wrappers in ui.h, log.h and http_common.h Compiler flags (configure.ac): Replace basic -Wformat/-Wformat-nonliteral with -Wformat=2 Add -Wextra, -Wnull-dereference, -Wpointer-arith, -Wimplicit-function-declaration, -Wundef, -Wfloat-equal, -Wredundant-decls, -Walloc-zero Add -fstack-protector-strong, -fno-common, -D_FORTIFY_SOURCE=2 Add GCC-specific flags via AC_COMPILE_IFELSE: -Wlogical-op, -Wduplicated-cond, -Wduplicated-branches, -Wstringop-overflow, -Warray-bounds=2 Suppress noisy -Wextra sub-warnings: -Wno-unused-parameter, -Wno-missing-field-initializers, -Wno-sign-compare, -Wno-cast-function-type Remove AM_CFLAGS/CFLAGS duplication Bug fixes found by new warnings: chatlog.c: non-MUCPM redact path passed resourcepart instead of NULL rosterwin.c: merge duplicated if/else branches into single condition omemo.c: redundant else-if in omemo_automatic_start; remove unnecessary scope block and goto, use early return console.c: pointer compared to integer 0 instead of NULL stanza.c: increase pri_str/idle_str buffers from 10 to 12 bytes (INT_MIN = -2147483648 needs 12 bytes including NUL) vcard.c: NULL guard for filename before g_file_set_contents api.c: broken log_warning() calls with extra format argument Format mismatch fixes: chatwin.c: Jid* → char* for %s connection.c: %x → %lx for long flags cmd_funcs.c: %d → %zu for size_t; cast gpointer to char* for %s cmd_defs.c: %d → %u for g_list_length() return (guint) iq.c: barejid → fulljid for from_jid console.c, mucwin.c, privwin.c, account.c, omemo.c, presence.c: gpointer → (char*) casts for %s Const-correctness and cleanup: database.c: const for type, query, sort variables form.c/xmpp.h: const for form_set_value parameter files.c: refactor to early return, eliminating NULL logfile path muc.c/muc.h: remove meaningless top-level const on return type common.c: const for URL string literal Remove stale declarations: cons_show_desktop_prefs (ui.h), connection_set_priority (connection.h), omemo_devicelist_configure_and_request (omemo.h) test_common.c: add currb NULL check to silence -Wnull-dereference Tooling (check-cwe134.sh): Reduce from 5 checks to 2 (checks 1-3 redundant with -Wformat=2) Check 1: verify known wrappers have G_GNUC_PRINTF attribute Check 2: auto-detect unannotated variadic printf-like functions Match both const char* and const gchar* in variadic patterns Author: jabber.developer2 <jabber.developer2@jabber.space>	2026-03-07 11:55:50 +01:00
jabber.developer2	4fce333c9a	fix(xmpp): show message for empty disco#items results (XEP-0030) ... Per XEP-0030 section 3.1: 'if an entity has no associated items, it MUST return an empty <query/> element.' The client should display 'No service discovery items for X' when receiving an empty result, not silently ignore it. Previous version introduced in commit f28655c5c (2016-05-08) which added an early return when child == NULL, preventing the message from being shown.	2026-02-11 01:10:55 +03:00
Jabber Developer	467222d0ca	fix(ui,db): harden NULL handling, fix CWE-134, optimize iterations ... security(CWE-134): fix format string injections + add CI check fix(ui): subwindow lifecycle, newwin/newpad guards, fallback timestamps fix(db): sqlite cleanup on failures, sqlite3_close_v2 fix(xmpp): queued_messages loop, barejid leak perf(core): g_hash_table_iter_init instead of g_hash_table_get_keys refactor(ui): CLAMP macro in _check_subwin_width test: XEP-0012 and XEP-0045 functional tests Author: jabber.developer2 Closes #58, #85	2026-02-06 19:27:40 +01:00
Jabber Developer	84d6253561	fix(xmpp): format debug logging statements for consistency ... Add debug output tracking connection lifecycle. - Track disconnects and reconnects - Record session login, logout, and reconnection attempts - Use [CONNDBG] tag for easy log filtering	2025-11-21 10:03:50 +01:00
Jabber Developer	3738be4af1	fix: prevent autoping disable on false negative ping support check ... Remove autodisable logic (prefs_set_autoping(0)) and early return in autoping to treat intermittent false negatives from connection_supports(XMPP_FEATURE_PING). Add one-time error display with debug features print for monitoring; warn on first failing check without aborting to maintain functionality while investigating root cause.	2025-10-14 12:42:00 +02:00
Jabber Developer	e1ce7ac630	fix(caps): Add features in caps_init to avoid redundant presence updates ... Previously, features like `XMPP_FEATURE_OMEMO_DEVICELIST_NOTIFY` were added in separate init methods (e.g., `omemo_devicelist_subscribe`) via `caps_add_feature`, triggering `cl_ev_presence_send` and sending multiple "online" XMPP presence stanzas. This caused other clients to see users as appearing "online" multiple times. This change adds `STANZA_NS_MOOD_NOTIFY` and `XMPP_FEATURE_OMEMO_DEVICELIST_NOTIFY` in `caps_init`, ensuring they are in `prof_features` early. This allows `caps_add_feature` to exit early when called for these features, avoiding redundant presence updates.	2025-07-19 18:33:03 +02:00
Michael Vetter	091ff41c06	Merge pull request #2041 from profanity-im/some-improvements ... Summary: - Print the final storage location when successfully decrypting a file with `aesgcm://` source. - Less GString - Re-factor cmd_presence() - Improve const correctness - Use correct free function. Fixes: 75d7663 ("Free wins summary list") Pull Request Source: https://github.com/profanity-im/profanity/pull/2041 Author: Steffen Jaeckel <s@jaeckel.eu>	2025-07-19 00:13:49 +02:00
Jabber Developer	f824cde45f	fix(mam, log): improve datetime handling and memory management in MAM and log fetching ... - Introduce static helper `_truncate_datetime_suffix()` to safely trim datetime strings, removing unwanted suffixes like timezone offsets - Replace manual string management with auto_gchar and g_strdup for safer, clearer ownership and to prevent leaks - Add safety checks and logging warnings for unexpected datetime string lengths or null pointers - Refactor _mam_rsm_id_handler to use the helper function and updated string handling - Change log_database_get_previous_chat parameters for consistent ownership semantics, avoiding double frees and mem leaks - Overall improve stability and prevent memory leaks during log database queries	2025-07-02 14:59:31 +02:00
Steffen Jaeckel	ed44d7ad96	Fix handling of roster pushes ... We must only return early in cases where we received a roster push with 1. a `from` attribute 2. that `from` is not our bare JID The server sends roster pushes without `from` attribute and we must accept them. Fixes #2035 Fixes: bac24601da ("Introduce `equals_our_barejid()`") Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>	2025-04-11 18:55:17 +02:00
Michael Vetter	07dfeec816	Release 0.15.0	2025-03-27 20:06:38 +01:00
Steffen Jaeckel	95c2199ca2	Some more memory improvements ... * Less leaks * Less allocations Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>	2025-03-12 10:09:41 +01:00
Steffen Jaeckel	9fc0326428	Add Valgrind to CI ... * Also pass `$*` to `configure` when invoking `ci-build.sh`, so one can e.g. run `./ci-build.sh --without-xscreensaver` Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>	2025-03-11 12:15:09 +01:00
Steffen Jaeckel	c0da36c48d	Rage-cleanup. ... While trying to get the unit tests working again I stumbled over all those things that I thought could be better^TM. Now we also know "TODO: why does this make the test fail?" - because the unit tests are brittle AF ... and we have to init the subsystems we use in the test, otherwise the cleanup will fail... BTW. you can now also only run a single test ... or a pattern or so ... you'd have to read how `cmocka_set_test_filter()` works exactly. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>	2025-03-10 11:45:15 +01:00
Steffen Jaeckel	72b99ceb6d	Some minor improvements ... * destroy/free/shutdown/close in reverse order of allocation * more static/auto_Xfree * less variables/strlen/GString * properly `\0`-terminate string of testcase Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>	2025-03-10 11:45:15 +01:00
Steffen Jaeckel	b55bf6e4bd	Fix some more memory leaks + an invalid read. ... `ProfMessage` was not completely initialized, fix this by using `calloc()` for the allocation. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>	2025-03-10 11:45:15 +01:00
Steffen Jaeckel	c5a131ee46	Introduce our own shutdown callback mechanism. ... Instead of adding stuff to `_shutdown()`, we can now register a shutdown routine from the respective `init()` function of our modules. This also has the advantage, that we're sure they're called in reverse order from how the initialization happened. I didn't simply use `atexit()` because POSIX says that the number of possible callbacks is limited (min 32) and I was not sure whether we will maybe extend this number at one point. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>	2025-03-07 21:09:16 +01:00
Steffen Jaeckel	2696989ce5	Fix a bunch of obvious memory leaks at termination ... Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>	2025-01-28 16:43:13 +01:00
Hanspeter Portner	cb395b7c09	Make muc_nick return a const char* const ... In the documentation of the `muc_nick` function we can read: > The nickname is owned by the chat room and should not be modified or freed We should reflect that in the return type and `strdup` the value for the plugin API. Fixes: https://github.com/profanity-im/profanity/issues/2013	2025-01-26 18:16:14 +01:00
Martin Dosch	50e82376b0	Remove plenking ... There were two cases of plenking (a space between a word and the punctuation marks) in front of `…`.	2024-10-03 15:51:52 +02:00
Michael Vetter	87935b744d	Merge pull request #1979 from profanity-im/fix/leaks ... Fix memleaks	2024-06-20 10:51:12 +02:00
Steffen Jaeckel	9640670f0f	Less GString usage ... Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2024-06-19 16:01:46 +02:00
Steffen Jaeckel	848acdd1fa	Improve const correctness ... Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2024-06-19 16:01:46 +02:00
Michael Vetter	d341705a43	Fix possible leaks in omemo_receive_message() ... At that point we might have allocated memory that should be freed.	2024-06-19 11:46:50 +02:00
Michael Vetter	569e37f018	Update copyright to 2024	2024-01-22 16:03:48 +01:00
Steffen Jaeckel	f458d6ebdf	Fix when feature discovery is finished ... Feature discovery was marked as finished once we received a reply to the initial request. The discovery mechanism allows to delegate the real feature discovery to another service running on different domain and those requests are created dynamically. This was another instance causing the warning message described in #1940 Fixes #1940 (once more) Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2023-12-28 19:21:27 +01:00
Steffen Jaeckel	dc0f2acb9a	Simplify usage of roster_get_display_name() ... Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2023-12-12 18:27:11 +01:00
Steffen Jaeckel	b4c088232e	Improve const correctness ... Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2023-12-12 18:27:09 +01:00
Steffen Jaeckel	bac24601da	Introduce equals_our_barejid() ... Instead of always repeating the same pattern, introduce a helper function. Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2023-12-12 18:27:02 +01:00
Steffen Jaeckel	835ea397ac	Tidy up some code ... Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2023-12-12 18:26:21 +01:00
Steffen Jaeckel	847a86de50	add connection_get_jid() ... Use a singleton `Jid` inside the connection instead of always re-creating a `Jid` from the same string. Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2023-12-12 18:26:21 +01:00
Steffen Jaeckel	629cd33e2f	Reset internal flag ... Reset the `received_disco_items` flag when initializing the iq module. This has caused the console error message "Server doesn't support MAM" sometimes on reconnect. Fixes #1940 Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2023-12-12 16:31:42 +01:00
Steffen Jaeckel	c3ed0c3262	Only handle MAM response if window still exists ... Before this patch the following scenario lead to a segfault: 1. open a window that sends a MAM request 2. fast enough close that window again before the MAM response was processed Once the MAM response is received we'd call `_mam_rsm_id_handler()` from the `_iq_handler()` and `window` would point to a non-existant window which leads to a segfault. Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2023-12-12 16:31:42 +01:00
Steffen Jaeckel	2b51675e89	Save SM queue on /reconnect now ... Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2023-12-12 16:31:42 +01:00
Steffen Jaeckel	ff32f51f4f	Fix libstrophe verbosity level always being set to 0 on start ... Fixup/revert of e55f6d7f4d This line had been added because an earlier release of libstrophe missed the initialisation of that variable, which has since been fixed. Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2023-12-12 16:30:19 +01:00
Steffen Jaeckel	64046bcdf3	Fix some things regarding char* vs. gchar* ... Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2023-12-09 15:09:52 +01:00
Michael Vetter	45fe1be58f	Merge pull request #1902 from H3rnand3zzz/feature/improved-history ... Change DB structure	2023-11-06 22:41:36 +01:00
Steffen Jaeckel	4c26462827	Ensure instances of auto types are initialized ... Follow-up of #1913 Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2023-11-06 22:22:35 +01:00
John Hernandez	a671cff964	Improve XEP-0308 compliance ... Disallow correcting historical MUC messages, as the XEP-308 requires. Previous changes introduce problem with "Illicit LMC attempt from conference@server/user for message from user" During investigation it was revealed that XEP does not recommend support of historical MUC messages correction. ``` When used in a Multi-User Chat (XEP-0045) context, corrections must not be allowed (by the receiver) for messages received before the sender joined the room - particularly a full JID leaving the room then rejoining and correcting a message SHOULD be disallowed, as the entity behind the full JID in the MUC may have changed. ``` https://xmpp.org/extensions/xep-0308.html#rules XEP details mentioned by @jubalh Bug discovered and solution improved by @jaeckel	2023-11-06 22:04:53 +01:00
John Hernandez	3c8b4acac4	Fix typos, correct grammar	2023-10-14 18:07:52 +02:00
Michael Vetter	634cb586d9	Merge pull request #1892 from ike08/improvement/muc-title-behaviour ... Improve MUC title behaviour for roster, statusbar, and titlebar	2023-10-09 09:47:03 +02:00
IsaacM88	23c6936398	Improve MUC title behaviour for roster, statusbar, and titlebar ... ## Abstract Continuation of https://github.com/profanity-im/profanity/pull/1881 Give all MUC title commands a consistent command structure and appearance. - `/roster room use name|jid` and `/roster room show|hide server` are now `/roster room title bookmark|jid|localpart|name` - `/statusbar room room|jid` is now `/statusbar room title bookmark|jid|localpart|name` - `/statusbar show|hide jid` and `/statusbar show|hide name` are now `/titlebar room title bookmark|jid|localpart|name` Fix both bugs mentioned in https://github.com/profanity-im/profanity/pull/1881 ### src/ui/mucwin.c:mucwin_generate_title Called by each command to generate a properly formatted title. It checks for "name" first because "name" is the default preference for each command. The last if-statement sets the title to "localpart" for special cases when the title should be "localpart" instead of the user-defined preference. ## Testing ### Preparation Remove preferences that will interfere with testing. ``` sed -i "/roster.rooms.title=/d" profrc sed -i "/statusbar.room.title=/d" profrc sed -i "/titlebar.muc.title=/d" profrc sed -i "/roster.rooms.use.name=/d" profrc sed -i "/roster.rooms.server=/d" profrc sed -i "/statusbar.room=/d" profrc sed -i "/titlebar.muc.title.jid=/d" profrc sed -i "/titlebar.muc.title.name=/d" profrc sed -i "/roster.rooms.by=/d" profrc ``` ### Command Definitions | Test | Window | | :--- | :--- | | `/help roster` | - /roster room title bookmark\|jid\|localpart\|name<br>- room title bookmark\|jid\|localpart\|name : Display the bookmark name, JID, JID localpart, or room name as the roster title for MUCs.<br>- *No /roster show\|hide server*<br>- *No /roster room use jid\|name* | | `/help statusbar` | - /statusbar room title bookmark\|jid\|localpart\|name<br>- room title bookmark\|jid\|localpart\|name : Display the bookmark name, JID, JID localpart, or room name as the title for MUC tabs.<br>- *No /statusbar room jid\|room* | | `/help titlebar` | - /titlebar room title bookmark\|jid\|localpart\|name<br>- room title bookmark\|jid\|localpart\|name : Display the bookmark name, JID, JID localpart, or room name as the MUC window title.<br>- *No /titlebar show\|hide jid\|name* | ### Autocomplete | Test | Command line | | :--- | :--- | | `/roster room <TAB>` | Autocompletes `title` | | `/roster room title <TAB>` | Autocompletes `bookmark\|jid\|localpart\|name` | | `/statusbar room <TAB>` | Autocompletes `title` | | `/statusbar room title <TAB>` | Autocompletes `bookmark\|jid\|localpart\|name` | | `/titlebar room <TAB>` | Autocompletes `title` | | `/titlebar room title <TAB>` | Autocompletes `bookmark\|jid\|localpart\|name` | | `/roster room <TAB>` | Does not autocomplete `use`, `show`, or `hide` | | `/roster room use <TAB>` | Does not autocomplete `name` | | `/roster room show <TAB>` | Does not autocomplete `server` | | `/roster room hide <TAB>` | Does not autocomplete `server` | | `/statusbar room <TAB>` | Does not autocomplete `jid` or `room` | | `/titlebar show <TAB>` | Does not autocomplete `jid` or `name` | | `/titlebar hide <TAB>` | Does not autocomplete `jid` or `name` | ### Set Preferences | Test | Window | profrc | | :--- | :--- | :--- | | `/roster room title bookmark` | Roster MUCs will display 'bookmark' as their title. | roster.rooms.title=bookmark | | `/roster room title jid` | Roster MUCs will display 'jid' as their title. | roster.rooms.title=jid | | `/roster room title localpart` | Roster MUCs will display 'localpart' as their title. | roster.rooms.title=localpart | | `/roster room title name` | Roster MUCs will display 'name' as their title. | roster.rooms.title=name | | `/roster room title invalid` | Invalid usage, see '/help roster' for details. | | | `/statusbar room title bookmark` | Displaying 'bookmark' as the title for MUC tabs. | statusbar.room.title=bookmark | | `/statusbar room title jid` | Displaying 'jid' as the title for MUC tabs. | statusbar.room.title=jid | | `/statusbar room title localpart` | Displaying 'localpart' as the title for MUC tabs. | statusbar.room.title=localpart | | `/statusbar room title name` | Displaying 'name' as the title for MUC tabs. | statusbar.room.title=name | | `/statusbar room title invalid` | Invalid usage, see '/help statusbar' for details. | | | `/titlebar room title bookmark` | MUC windows will display 'bookmark' as the window title. | titlebar.muc.title=bookmark | | `/titlebar room title jid` | MUC windows will display 'jid' as the window title. | titlebar.muc.title=jid | | `/titlebar room title localpart` | MUC windows will display 'localpart' as the window title. | titlebar.muc.title=localpart | | `/titlebar room title name` | MUC windows will display 'name' as the window title. | titlebar.muc.title=name | | `/titlebar room title invalid` | Invalid usage, see '/help titlebar' for details. | | | `/roster room use jid` | Invalid usage, see '/help roster' for details. | | | `/roster room use name` | Invalid usage, see '/help roster' for details. | | | `/roster room show server` | Invalid usage, see '/help roster' for details. | | | `/roster room hide server` | Invalid usage, see '/help roster' for details. | | | `/statusbar room jid` | Invalid usage, see '/help statusbar' for details. | | | `/statusbar room room` | Invalid usage, see '/help statusbar' for details. | | | `/titlebar show jid` | Invalid usage, see '/help titlebar' for details. | | | `/titlebar hide jid` | Invalid usage, see '/help titlebar' for details. | | | `/titlebar show name` | Invalid usage, see '/help titlebar' for details. | | | `/titlebar hide name` | Invalid usage, see '/help titlebar' for details. | | ### Display Set Preferences | Test | Window | | :--- | :--- | | /prefs ui | - Roster rooms title (/roster) : name<br>- Room tab display (/statusbar) : name<br>- MUC window title (/titlebar) : name | ### Test MUC Window #### Test: without *name* preference, without *room name* field ``` /join muc@dmn.im /room config /field1 "" /form submit /quit ``` | Test | Roster | Statusbar | Titlebar | | :--- | :--- | :--- | :--- | | `/join muc@dmn.im` | muc<span/>@dmn.im | muc<span/>@dmn.im | muc<span/>@dmn.im | | `/room config` | | muc<span/>@dmn.im conf | muc<span/>@dmn.im config | | `/field2 edit` | | | muc<span/>@dmn.im config * | | `/msg tst` | tst | muc<span/>@dmn.im/tst | muc<span/>@dmn.im/tst | | `/roster room by service` | muc | | | #### Test: with *name* preference, without *room name* field ``` /roster room title name /statusbar room title name /titlebar room title name /save /quit ``` | Test | Roster | Statusbar | Titlebar | | :--- | :--- | :--- | :--- | | `/join muc@dmn.im` | muc<span/>@dmn.im | muc<span/>@dmn.im | muc<span/>@dmn.im | | `/room config` | | muc<span/>@dmn.im conf | muc<span/>@dmn.im config | | `/field2 edit` | | | muc<span/>@dmn.im config * | | `/msg tst` | tst | muc<span/>@dmn.im/tst | muc<span/>@dmn.im/tst | | `/roster room by service` | muc | | | #### Test: without *name* preference, with *room name* field ``` sed -i "/roster.rooms.title=/d" profrc sed -i "/statusbar.room.title=/d" profrc sed -i "/titlebar.muc.title=/d" profrc /join muc@dmn.im /room config /field1 "my_room" /form submit /quit ``` | Test | Roster | Statusbar | Titlebar | | :--- | :--- | :--- | :--- | | `/join muc@dmn.im` | my_room | my_room | my_room | | `/room config` | | my_room conf | my_room config | | `/field2 edit` | | | my_room config * | | `/msg tst` | tst | my_room/tst | my_room/tst | | `/roster room by service` | my_room | | | #### Test: with *name* preference, with *room name* field ``` /quit /roster room title name /statusbar room title name /titlebar room title name /save /quit ``` | Test | Roster | Statusbar | Titlebar | | :--- | :--- | :--- | :--- | | `/join muc@dmn.im` | my_room | my_room | my_room | | `/room config` | | my_room conf | my_room config | | `/field2 edit` | | | my_room config * | | `/msg tst` | tst | my_room/tst | my_room/tst | | `/roster room by service` | my_room | | | #### Test: with *localpart* preference ``` /quit /roster room title localpart /statusbar room title localpart /titlebar room title localpart /save /quit ``` | Test | Roster | Statusbar | Titlebar | | :--- | :--- | :--- | :--- | | `/join muc@dmn.im` | muc | muc | muc | | `/room config` | | muc conf | muc config | | `/field2 edit` | | | muc config * | | `/msg tst` | tst | muc/tst | muc/tst | | `/roster room by service` | muc | | | #### Test: with *bookmark* preference, without *bookmark name* ``` /quit /roster room title bookmark /statusbar room title bookmark /titlebar room title bookmark /save /quit /bookmark add muc@dmn.im ``` | Test | Roster | Statusbar | Titlebar | | :--- | :--- | :--- | :--- | | `/bookmark join muc@dmn.im` | muc<span/>@dmn.im | muc<span/>@dmn.im | muc<span/>@dmn.im | | `/room config` | | muc<span/>@dmn.im conf | muc<span/>@dmn.im config | | `/field2 edit` | | | muc<span/>@dmn.im config * | | `/msg tst` | tst | muc<span/>@dmn.im/tst | muc<span/>@dmn.im/tst | | `/roster room by service` | muc | | | #### Test: with *bookmark* preference, with *bookmark name* ``` /quit /bookmark remove muc@dmn.im /bookmark add muc@dmn.im name "my_bookmark" ``` | Test | Roster | Statusbar | Titlebar | | :--- | :--- | :--- | :--- | | `/bookmark join muc@dmn.im` | my_bookmark | my_bookmark | my_bookmark | | `/room config` | | my_bookmark conf | my_bookmark config | | `/field2 edit` | | | my_bookmark config * | | `/msg tst` | tst | my_bookmark/tst | my_bookmark/tst | | `/roster room by service` | my_bookmark | | | #### Test: with *jid* preference ``` /quit /roster room title jid /statusbar room title jid /titlebar room title jid /save /quit ``` | Test | Roster | Statusbar | Titlebar | | :--- | :--- | :--- | :--- | | `/join muc@dmn.im` | muc<span/>@dmn.im | muc<span/>@dmn.im | muc<span/>@dmn.im | | `/room config` | | muc<span/>@dmn.im conf | muc<span/>@dmn.im config | | `/field2 edit` | | | muc<span/>@dmn.im config * | | `/msg tst` | tst | muc<span/>@dmn.im/tst | muc<span/>@dmn.im/tst | | `/roster room by service` | muc | | | ### Test Contact Chat Window Title #### Test: without contact nick ``` /roster add tst@dmn.im ``` | Test | Titlebar | | :--- | :--- | | `/msg tst@dmn.im` | tst<span/>@dmn.im | #### Test: with contact nick ``` /roster add tst@dmn.im my_tst ``` | Test | Titlebar | | :--- | :--- | | `/msg my_tst` | my_tst <tst<span/>@ike.snikket.chat> | ### Test Preference Upgrade #### Test /roster | Test | profrc | | :--- | :--- | | `sed -i '/\[ui\]/a\roster.rooms.use.name=name' profrc` | Original key removed. | | `sed -i '/\[ui\]/a\roster.rooms.use.name=' profrc` | Original key removed. | | `sed -i '/\[ui\]/a\roster.rooms.server=' profrc` | Original key removed. | | `sed -i '/\[ui\]/a\roster.rooms.use.name=jid' profrc` | Original key removed.<br>roster.rooms.title=jid | | `sed -i '/\[ui\]/a\roster.rooms.use.name=jid' profrc`<br>`sed -i '/\[ui\]/a\roster.rooms.server=false' profrc` | Original keys removed.<br>roster.rooms.title=localpart | | `sed -i '/\[ui\]/a\roster.rooms.use.name=jid' profrc`<br>`sed -i '/\[ui\]/a\roster.rooms.server=true' profrc` | Original keys removed.<br>roster.rooms.title=jid | | `sed -i '/\[ui\]/a\roster.rooms.use.name=jid' profrc`<br>`sed -i '/\[ui\]/a\roster.rooms.server=' profrc` | Original keys removed.<br>roster.rooms.title=jid | | `sed -i '/\[ui\]/a\statusbar.room=' profrc` | Original key removed. | | `sed -i '/\[ui\]/a\statusbar.room=room' profrc` | Original key removed.<br>statusbar.room.title=localpart | | `sed -i '/\[ui\]/a\statusbar.room=jid' profrc` | Original key removed.<br>statusbar.room.title=jid | | `sed -i '/\[ui\]/a\titlebar.muc.title.jid=' profrc` | Original key removed. | | `sed -i '/\[ui\]/a\titlebar.muc.title.name=' profrc` | Original key removed. | | `sed -i '/\[ui\]/a\titlebar.muc.title.jid=true' profrc` | Original key removed. | | `sed -i '/\[ui\]/a\titlebar.muc.title.name=true' profrc` | Original key removed. | | `sed -i '/\[ui\]/a\titlebar.muc.title.jid=false' profrc` | Original key removed. | | `sed -i '/\[ui\]/a\titlebar.muc.title.name=false' profrc` | Original key removed. | | `sed -i '/\[ui\]/a\titlebar.muc.title.jid=true' profrc`<br>`sed -i '/\[ui\]/a\titlebar.muc.title.name=false' profrc` | Original key removed.<br>titlebar.muc.title=jid | | `sed -i '/\[ui\]/a\titlebar.muc.title.jid=false' profrc`<br>`sed -i '/\[ui\]/a\titlebar.muc.title.name=true' profrc` | Original keys removed. | | `sed -i '/\[ui\]/a\titlebar.muc.title.jid=true' profrc`<br>`sed -i '/\[ui\]/a\titlebar.muc.title.name=true' profrc` | Original keys removed. | ### Test Valgrind No memory leaks detected relating to these changes.	2023-10-05 18:16:04 -06:00
Steffen Jaeckel	6f1ea087c8	Fix memleak. ... In some cases it was possible that the `roster_pending_presence` list was not free'd correctly. Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2023-10-04 17:02:10 +02:00
Steffen Jaeckel	e668c4f7df	Extend autoping timer on each stanza we receive. ... Sometimes the server is too busy sending other stanzas or our connection is saturated because of something else, so the pong arrives too late. Prevent the autoping disconnect event by extending the timeout each time a stanza is received. Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2023-10-04 17:02:10 +02:00
Steffen Jaeckel	ca2df180d8	Introduce a shared implementation for keyfile loading ... Instead of copy&pasting the same code over again, use a common implementation. Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2023-09-04 09:59:09 +02:00
Michael Vetter	492efc432c	Display headline sender	2023-08-11 15:56:26 +02:00
Michael Vetter	215e35b198	Fix my email address	2023-07-31 16:42:45 +02:00
Michael Vetter	22b1d14b67	Add helper function to create version string ... And remove all the duplicate code. Depending on the situation prof_get_version() will return: * 0.13.1 * 0.13.1dev * 0.13.1dev.master.69d8c1f9	2023-07-25 20:58:15 +02:00