191 Commits

Author	SHA1	Message	Date
Jabber Developer	830479cf20	fix: OTR/presence/OMEMO correctness, stanza-id disco gate, build hardening ... - OTR: strip the whitespace tag by shifting the full message tail incl. the NUL, not tag_length bytes, so the body is no longer duplicated for messages longer than the tag. - presence: snapshot the resource fields before connection_add_available_resource() takes ownership, removing a use-after-free in the own-presence path. - OMEMO: propagate _omemo_finalize_identity_load() failure on connect (log + cons_show_error + stop) instead of leaving OMEMO silently unavailable. - OMEMO: guard NULL fingerprint decode in _omemo_fingerprint_decode / omemo_is_trusted_identity / omemo_trust and log every decode failure instead of failing silently. - stanza-id: gate XEP-0359 dedup on disco urn:xmpp:sid:0 (the `by` JID or its domain), falling back to no-dedup when caps are unknown; add functional tests for trusted vs untrusted server. - accounts: narrow the group-name sanitizer to the characters GKeyFile forbids in headers ([ ] \n \r), keeping `=` and `#`, so read/write stays symmetric. - build: re-introduce compiler/sanitizer flags in a Pikaur-safe form (opt-in sanitizers, -Wsign-compare) and fix the resulting -Wsign-compare warnings (incl. proftest _mkdir_recursive).fix: OTR/presence/OMEMO correctness, stanza-id disco gate, build hardening Author: jabber.developer2 <jabber.developer2@jabber.space>	2026-06-20 10:30:23 +00:00
Jabber Developer	72f4f186da	merge: sync upstream profanity-im/profanity ... Sync with upstream profanity-im/profanity. Major upstream changes incorporated: Memory management - Replace malloc+memset with g_new0 throughout codebase - Adopt auto_gchar / auto_gcharv / auto_gerror / auto_jid cleanup macros - Replace free() with g_free() for GAlloc'd memory Editor rewrite - Remove pthread-based async editor; use GChildWatch callback API - New launch_editor(initial_content, callback, user_data) interface - Proper signal handling (SIGINT, SIGTSTP, SIGPIPE reset in child) - ui_suspend()/ui_resume() integration for TTY management OMEMO improvements - Dual backend support: libsignal-protocol-c and libomemo-c - Proper pre-key removal after use (XEP-0384 compliance) - Automatic pre-key regeneration when store drops below threshold - New functions: omemo_is_device_active(), omemo_is_jid_trusted() - omemo_get_jid_untrusted_fingerprints() for better error messages - Fingerprint notifications on new device identity discovery - Deterministic pre-key ID generation tracking max_pre_key_id - omemo_trust_changed() UI updates on trust state changes JID validation - RFC 6122-compliant validation in jid_is_valid() - Character-level checks (RFC 6122 forbidden chars: & ' / : < > @) - Length limits: 1023 per component, 3071 total - New jid_is_valid_user_jid() for user vs. service JID distinction Database - Schema migration v3: UNIQUE constraint on archive_id for deduplication - Triggers for corrected message tracking (replaces_db_id / replaced_by_db_id) - db_history_result_t return type, _truncate_datetime_suffix() UI / console - win_warn_needed() / win_warn_sent() warning deduplication hash table - PAD_MIN_HEIGHT dynamic pad sizing with PAD_THRESHOLD auto-cleanup - Spellcheck integration in input field with Unicode word detection - cons_spellcheck_setting() for /settings ui output - /[command]? shortcut for command help Account config - Account name sanitization for GKeyFile special chars ([ ] = # \n \r) - Replace popen() with g_spawn_sync() for eval_password - TLS policy: add "direct" option alongside legacy Connection - Port validation with g_assert (0–65535) - SHA-256 certificate fingerprint support (XMPP_CERT_PUBKEY_FINGERPRINT_SHA256) - "direct" TLS policy alias for legacy SSL Common utilities - str_xml_sanitize() for XML 1.0 illegal character removal - string_matches_one_of() with formatted error messages - valid_tls_policy_option() helper - prof_date_time_format_iso8601() utility - Improved strip_arg_quotes() with backslash unescaping - prof_occurrences() uses g_slist_prepend + reverse for performance PGP / OX - Proper GPGME resource cleanup with goto-cleanup pattern - g_string_free(xmppuri) leak fix in _ox_key_lookup CSV export - Use GString + g_file_set_contents instead of raw write() syscalls Tests - Restructured into subdirectories: command/, config/, xmpp/, ui/, omemo/, otr/, pgp/ - New test_cmd_ac.c for autocompleter unit tests - Updated stubs for new UI suspend/resume functions License headers - Migrate to SPDX-3.0 identifiers (GPL-3.0-or-later WITH OpenSSL-exception) ──────────────────────────────────────────────────── cproof-specific preservations: - XEP-0308 LMC: replace_id ?: id logic in message/stanza/omemo - Force encryption: cmd_force_encryption, test_forced_encryption - CWE-134: format string protection (cons_show("%s", ...)) - y_start_pos-based paging in window.c - db_history_result_t return type, _truncate_datetime_suffix() Merge-time fixes: - common.c: format-security (-Werror) — cons_show(errmsg) → cons_show("%s", errmsg) - database.c: null-deref guard — !msg->timestamp → msg && !msg->timestamp - console.c: implicit size_t → int cast — (int)(maxlen + 1) - tlscerts.c: %d for size_t — %zu Build system: - Kept autotools (Makefile.am, configure.ac); upstream uses Meson - Restored deleted files: bootstrap.sh, autogen.sh, ax_valgrind_check.m4, configure-debug - Updated Makefile.am test paths for subdirectory structure - Added test_cmd_ac, test_forced_encryption to test sources Functional tests: - Use cproof version; upstream requires stbbr_for_xmlns from updated stabber - Not yet available in devs/stabber fork Closes #64 Merge author: jabber.developer2 Commits authors: Michael Vetter <jubalh@iodoru.org> & Steffen Jaeckel <s@jaeckel.eu>	2026-05-26 17:48:14 +00:00
Jabber Developer	9ec01fa8cc	fix: CWE-134 format string audit and compiler hardening ... Security: Fix CWE-134 in iq.c: user-controlled string passed as format argument Add G_GNUC_PRINTF annotations to all variadic printf-like wrappers in ui.h, log.h and http_common.h Compiler flags (configure.ac): Replace basic -Wformat/-Wformat-nonliteral with -Wformat=2 Add -Wextra, -Wnull-dereference, -Wpointer-arith, -Wimplicit-function-declaration, -Wundef, -Wfloat-equal, -Wredundant-decls, -Walloc-zero Add -fstack-protector-strong, -fno-common, -D_FORTIFY_SOURCE=2 Add GCC-specific flags via AC_COMPILE_IFELSE: -Wlogical-op, -Wduplicated-cond, -Wduplicated-branches, -Wstringop-overflow, -Warray-bounds=2 Suppress noisy -Wextra sub-warnings: -Wno-unused-parameter, -Wno-missing-field-initializers, -Wno-sign-compare, -Wno-cast-function-type Remove AM_CFLAGS/CFLAGS duplication Bug fixes found by new warnings: chatlog.c: non-MUCPM redact path passed resourcepart instead of NULL rosterwin.c: merge duplicated if/else branches into single condition omemo.c: redundant else-if in omemo_automatic_start; remove unnecessary scope block and goto, use early return console.c: pointer compared to integer 0 instead of NULL stanza.c: increase pri_str/idle_str buffers from 10 to 12 bytes (INT_MIN = -2147483648 needs 12 bytes including NUL) vcard.c: NULL guard for filename before g_file_set_contents api.c: broken log_warning() calls with extra format argument Format mismatch fixes: chatwin.c: Jid* → char* for %s connection.c: %x → %lx for long flags cmd_funcs.c: %d → %zu for size_t; cast gpointer to char* for %s cmd_defs.c: %d → %u for g_list_length() return (guint) iq.c: barejid → fulljid for from_jid console.c, mucwin.c, privwin.c, account.c, omemo.c, presence.c: gpointer → (char*) casts for %s Const-correctness and cleanup: database.c: const for type, query, sort variables form.c/xmpp.h: const for form_set_value parameter files.c: refactor to early return, eliminating NULL logfile path muc.c/muc.h: remove meaningless top-level const on return type common.c: const for URL string literal Remove stale declarations: cons_show_desktop_prefs (ui.h), connection_set_priority (connection.h), omemo_devicelist_configure_and_request (omemo.h) test_common.c: add currb NULL check to silence -Wnull-dereference Tooling (check-cwe134.sh): Reduce from 5 checks to 2 (checks 1-3 redundant with -Wformat=2) Check 1: verify known wrappers have G_GNUC_PRINTF attribute Check 2: auto-detect unannotated variadic printf-like functions Match both const char* and const gchar* in variadic patterns Author: jabber.developer2 <jabber.developer2@jabber.space>	2026-03-07 11:55:50 +01:00
Jabber Developer	467222d0ca	fix(ui,db): harden NULL handling, fix CWE-134, optimize iterations ... security(CWE-134): fix format string injections + add CI check fix(ui): subwindow lifecycle, newwin/newpad guards, fallback timestamps fix(db): sqlite cleanup on failures, sqlite3_close_v2 fix(xmpp): queued_messages loop, barejid leak perf(core): g_hash_table_iter_init instead of g_hash_table_get_keys refactor(ui): CLAMP macro in _check_subwin_width test: XEP-0012 and XEP-0045 functional tests Author: jabber.developer2 Closes #58, #85	2026-02-06 19:27:40 +01:00
Michael Vetter	091ff41c06	Merge pull request #2041 from profanity-im/some-improvements ... Summary: - Print the final storage location when successfully decrypting a file with `aesgcm://` source. - Less GString - Re-factor cmd_presence() - Improve const correctness - Use correct free function. Fixes: 75d7663 ("Free wins summary list") Pull Request Source: https://github.com/profanity-im/profanity/pull/2041 Author: Steffen Jaeckel <s@jaeckel.eu>	2025-07-19 00:13:49 +02:00
Jabber Developer	f824cde45f	fix(mam, log): improve datetime handling and memory management in MAM and log fetching ... - Introduce static helper `_truncate_datetime_suffix()` to safely trim datetime strings, removing unwanted suffixes like timezone offsets - Replace manual string management with auto_gchar and g_strdup for safer, clearer ownership and to prevent leaks - Add safety checks and logging warnings for unexpected datetime string lengths or null pointers - Refactor _mam_rsm_id_handler to use the helper function and updated string handling - Change log_database_get_previous_chat parameters for consistent ownership semantics, avoiding double frees and mem leaks - Overall improve stability and prevent memory leaks during log database queries	2025-07-02 14:59:31 +02:00
Steffen Jaeckel	95c2199ca2	Some more memory improvements ... * Less leaks * Less allocations Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>	2025-03-12 10:09:41 +01:00
Steffen Jaeckel	2696989ce5	Fix a bunch of obvious memory leaks at termination ... Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>	2025-01-28 16:43:13 +01:00
Hanspeter Portner	cb395b7c09	Make muc_nick return a const char* const ... In the documentation of the `muc_nick` function we can read: > The nickname is owned by the chat room and should not be modified or freed We should reflect that in the return type and `strdup` the value for the plugin API. Fixes: https://github.com/profanity-im/profanity/issues/2013	2025-01-26 18:16:14 +01:00
Steffen Jaeckel	848acdd1fa	Improve const correctness ... Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2024-06-19 16:01:46 +02:00
Steffen Jaeckel	b4c088232e	Improve const correctness ... Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2023-12-12 18:27:09 +01:00
Steffen Jaeckel	e668c4f7df	Extend autoping timer on each stanza we receive. ... Sometimes the server is too busy sending other stanzas or our connection is saturated because of something else, so the pong arrives too late. Prevent the autoping disconnect event by extending the timeout each time a stanza is received. Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2023-10-04 17:02:10 +02:00
John Hernandez	029f1caa52	Cleanup jid_destroy to auto_jid ... Remove unused variables Apply minor cleanups	2023-07-13 17:05:07 +02:00
John Hernandez	8304ac86ff	g_free() to auto_gfree, introduce auto_guchar ... Fix 11 potential mem leaks in theme.c	2023-07-13 17:04:59 +02:00
John Hernandez	e1d137f4e6	Change char->free to auto_char char for autocleanup ... Replace `gchar` and `g_free` to `auto_gchar` Correct certain `char` functions/variables to `gchar` Related to #1819. Edited by @jubalh.	2023-07-11 13:26:37 +02:00
John Hernandez	07cc19ce10	Add sessions_alarm ... Introduce new feature: sessions_alarm. Added new account setting: max_connections. On exceeding this number, user will get an alert. If number is less than 1, no alert will happen. Tests altered to fit new feature.	2023-04-18 14:28:20 +02:00
MarcoPolo-PasTonMolo	63f694d6a7	Respect silent nick change in mucs ... Profanity would ignore the silent nick change in some places. The roster and history would show the correct nick, new messages from the current user and the "Autojoined <jid> as <nick>" message would show the wrong one. This commit fixes that problem. Fixes https://github.com/profanity-im/profanity/issues/757	2022-05-26 21:57:42 +03:00
Michael Vetter	b1929068ff	presence: guard against invalid input ... It shouldn't happen that we get the presence stanza without a resource. https://datatracker.ietf.org/doc/html/rfc6120 ``` Implementation Note: It is the server's responsibility to deliver only stanzas that are addressed to the client's full JID or the user's bare JID; thus, there is no need for the client to check the 'to' address of incoming stanzas. However, if the client does check the 'to' address then it is suggested to check at most the bare JID portion (not the full JID), since the 'to' address might be the user's bare JID, the client's current full JID, or even a full JID with a different resourcepart (e.g., in the case of so- called "offline messages" as described in [XEP-0160]). ``` Let's not segfault though. Close https://github.com/profanity-im/profanity/issues/1630	2022-01-27 11:52:23 +01:00
Steffen Jaeckel	ffc0b49ab1	first step to remove libmesode ... Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2021-10-27 22:45:44 +02:00
Michael Vetter	a2726b6a7d	Apply coding style	2020-07-07 14:18:57 +02:00
Michael Vetter	a4cadf78fa	Revert "Apply coding style" ... This reverts commit 9b55f2dec0. Sorting the includes creates some problems.	2020-07-07 13:53:30 +02:00
Michael Vetter	9b55f2dec0	Apply coding style ... Regards https://github.com/profanity-im/profanity/issues/1396	2020-07-07 09:43:28 +02:00
Michael Vetter	b73606cc60	Review logging in presence.c ... Some stuff just floods the log file. We only need this when debugging. Others are useless without more info.	2020-04-14 18:29:15 +02:00
Paul Fariello	a52e3ea1d8	Add context to autocomplete_with_func and use it for omemo trust command ... Fix #1068	2020-01-31 10:07:08 +01:00
Michael Vetter	46fd7150e5	Add vim modeline	2019-11-13 12:11:05 +01:00
Michael Vetter	53640f6e97	Remove prefix from stanza id ... We sent `prof_prefix_uuid` as id. Where the prefix was also optional. We don't need this at all.	2019-10-17 15:40:40 +02:00
Michael Vetter	706af9a900	Update copyright to include 2019	2019-01-22 11:31:45 +01:00
Michael Vetter	6d80700329	Move ID generation to xmpp folder ... create_unique_id() was changed to use UUIDs instead of a counter in the last commit. Since now it depends on connection_create_uuid() which is in the xmpp subfolder the function should also be moved there. Renamed it to connection_create_stanza_id() and moved it to src/xmpp/connection.c. Discussion happened in https://github.com/boothj5/profanity/pull/1010	2018-08-30 11:17:04 +02:00
James Booth	250e972b7a	Update copyright	2018-01-21 15:00:02 +00:00
James Booth	6b830277a6	Allow previous autocompletion with shift tab	2017-04-01 00:27:11 +01:00
James Booth	68a3daedb9	Update Copyright	2017-01-28 17:24:22 +00:00
James Booth	2b7894ccff	Remove status from cl_ev_presence_send ... fixes #888	2017-01-15 23:59:31 +00:00
James Booth	0886062806	Use hash table for bookmarks	2016-08-21 15:25:49 +01:00
James Booth	a52230978f	Tidy presence.c	2016-08-20 23:31:27 +01:00
James Booth	583fb2b8c6	Use libstrophe xmpp_presence_new convenience function	2016-08-20 20:37:48 +01:00
James Booth	24c3eff428	Use libstrophe convenience functions for stanza attributes	2016-08-20 18:16:51 +01:00
James Booth	e776ef9b68	Rename caps_contains -> caps_cache_contains	2016-08-13 23:45:58 +01:00
James Booth	6777919d96	Rename rooms vars in _send_room_presence	2016-07-25 23:13:09 +01:00
James Booth	0a57c4de78	Tidy headers	2016-07-24 15:43:51 +01:00
James Booth	e8fc80f5c1	Update GPL link in headers	2016-07-24 01:14:49 +01:00
James Booth	9596591610	Move available resources to connection struct	2016-05-07 23:04:50 +01:00
James Booth	d1c71e98f4	Move connection fulljid function	2016-05-06 01:12:54 +01:00
James Booth	88f423afea	Rename jabber_ functions	2016-05-06 00:53:03 +01:00
James Booth	3bb1f12410	Add session.c	2016-05-05 23:51:49 +01:00
James Booth	f6fa63b374	Renamed connection.c -> session.c	2016-05-05 22:10:10 +01:00
James Booth	ccabc08fef	Tidy xmpp headers	2016-05-04 01:19:51 +01:00
James Booth	aabe3afff8	Rename stanza handler init functions	2016-05-02 22:34:43 +01:00
James Booth	31ab43ea2d	Free stanza text and DiscoInfo features	2016-05-02 00:40:16 +01:00
James Booth	2bacd43a16	Free stanza text on plugin send hooks	2016-05-01 23:41:57 +01:00
Dmitry Podgorny	efbf233c85	Define stanza's attributes as const char* ... In most get-like funcitons libstrophe returns pointer to a string that resides in an internal structure (e.g. xmpp_stanza_t). Hence, Profanity must not change such strings. Define respective variables as 'const char*' to reduce a chance of error and conform future libstrophe's interface. This patch mostly replaces 'char *' with 'const char*', but also fixes two memory leaks after stanza_get_reason(). Add comment within stanza_get_reason() to fix conflict with different allocator types.	2016-04-27 10:31:28 +00:00