fix(autocomplete): guard history completion safely

Prevent autocomplete crashes on asset failures when executing history subcommands without an active connection by validating the session state beforehand. Standardize JID resolution across command handlers to ensure consistent contact lookup behavior. Use auto_gchar gchar instead of GString for performance and readability purposes.
feat(cli): resolve contact names to JIDs in multiple commands and improve autocomplete
2026-07-11 16:09:36 +00:00 · 2026-07-11 15:54:32 +00:00 · 2026-07-10 08:54:24 +00:00 · 2026-07-10 08:12:56 +00:00
10 changed files with 187 additions and 150 deletions
--- a/src/command/cmd_ac.c
+++ b/src/command/cmd_ac.c
@@ -110,6 +110,8 @@ static char* _software_autocomplete(ProfWin* window, const char* const input, gb
 static char* _url_autocomplete(ProfWin* window, const char* const input, gboolean previous);
 static char* _executable_autocomplete(ProfWin* window, const char* const input, gboolean previous);
 static char* _lastactivity_autocomplete(ProfWin* window, const char* const input, gboolean previous);
+static char* _disco_autocomplete(ProfWin* window, const char* const input, gboolean previous);
+static char* _roster_jid_autocomplete(const char* const input, const char* const prefix, gboolean previous);
 static char* _intype_autocomplete(ProfWin* window, const char* const input, gboolean previous);
 static char* _mood_autocomplete(ProfWin* window, const char* const input, gboolean previous);
 static char* _strophe_autocomplete(ProfWin* window, const char* const input, gboolean previous);
@@ -122,6 +124,7 @@ static char* _ai_autocomplete(ProfWin* window, const char* const input, gboolean
 static char* _script_autocomplete_func(const char* const prefix, gboolean previous, void* context);

 static char* _cmd_ac_complete_params(ProfWin* window, const char* const input, gboolean previous);
+static gboolean _is_connected(void);

 static Autocomplete commands_ac;
 static Autocomplete who_room_ac;
@@ -1426,6 +1429,7 @@ cmd_ac_init(void)
    g_hash_table_insert(ac_funcs, "/color", _color_autocomplete);
    g_hash_table_insert(ac_funcs, "/connect", _connect_autocomplete);
    g_hash_table_insert(ac_funcs, "/console", _console_autocomplete);
+    g_hash_table_insert(ac_funcs, "/disco", _disco_autocomplete);
    g_hash_table_insert(ac_funcs, "/correct", _correct_autocomplete);
    g_hash_table_insert(ac_funcs, "/correction", _correction_autocomplete);
    g_hash_table_insert(ac_funcs, "/executable", _executable_autocomplete);
@@ -1862,10 +1866,12 @@ _cmd_ac_complete_params(ProfWin* window, const char* const input, gboolean previ
    }

    gchar* history_jid_subcmds[] = { "/history verify", "/history export", "/history import" };
-    for (size_t i = 0; i < ARRAY_SIZE(history_jid_subcmds); i++) {
-        result = autocomplete_param_with_func(input, history_jid_subcmds[i], roster_barejid_autocomplete, previous, NULL);
-        if (result) {
-            return result;
+    if (conn_status == JABBER_CONNECTED) {
+        for (size_t i = 0; i < ARRAY_SIZE(history_jid_subcmds); i++) {
+            result = autocomplete_param_with_func(input, history_jid_subcmds[i], roster_barejid_autocomplete, previous, NULL);
+            if (result) {
+                return result;
+            }
        }
    }

@@ -1941,7 +1947,6 @@ _cmd_ac_complete_params(ProfWin* window, const char* const input, gboolean previ
        Autocomplete completer;
    } ac_cmds[] = {
        { "/prefs", prefs_ac },
-        { "/disco", disco_ac },
        { "/room", room_ac },
        { "/mainwin", winpos_ac },
        { "/inputwin", winpos_ac },
@@ -1991,6 +1996,31 @@ _cmd_ac_complete_params(ProfWin* window, const char* const input, gboolean previ
    return NULL;
 }

+static gboolean
+_is_connected(void)
+{
+    return connection_get_status() == JABBER_CONNECTED;
+}
+
+static char*
+_roster_jid_autocomplete(const char* const input, const char* const prefix, gboolean previous)
+{
+    if (!_is_connected()) {
+        return NULL;
+    }
+    char* result = NULL;
+    result = autocomplete_param_with_func(input, prefix, roster_contact_autocomplete, previous, NULL);
+    if (result) {
+        return result;
+    }
+    result = autocomplete_param_with_func(input, prefix, roster_barejid_autocomplete, previous, NULL);
+    if (result) {
+        return result;
+    }
+    result = autocomplete_param_with_func(input, prefix, roster_fulljid_autocomplete, previous, NULL);
+    return result;
+}
+
 static char*
 _caps_autocomplete(ProfWin* window, const char* const input, gboolean previous)
 {
@@ -2006,20 +2036,29 @@ _caps_autocomplete(ProfWin* window, const char* const input, gboolean previous)
        if (nick_ac) {
            result = autocomplete_param_with_ac(input, "/caps", nick_ac, TRUE, previous);
        }
-    } else if (connection_get_status() == JABBER_CONNECTED) {
-        result = autocomplete_param_with_func(input, "/caps", roster_contact_autocomplete, previous, NULL);
-        if (result) {
-            return result;
-        }
-        result = autocomplete_param_with_func(input, "/caps", roster_barejid_autocomplete, previous, NULL);
-        if (result) {
-            return result;
-        }
-        result = autocomplete_param_with_func(input, "/caps", roster_fulljid_autocomplete, previous, NULL);
+    } else {
+        result = _roster_jid_autocomplete(input, "/caps", previous);
    }
    return result;
 }

+static char*
+_disco_autocomplete(ProfWin* window, const char* const input, gboolean previous)
+{
+    char* result = NULL;
+    result = autocomplete_param_with_ac(input, "/disco", disco_ac, TRUE, previous);
+    if (result) {
+        return result;
+    }
+
+    result = _roster_jid_autocomplete(input, "/disco info", previous);
+    if (result) {
+        return result;
+    }
+    result = _roster_jid_autocomplete(input, "/disco items", previous);
+    return result;
+}
+
 static char*
 _sub_autocomplete(ProfWin* window, const char* const input, gboolean previous)
 {
@@ -3698,7 +3737,7 @@ _win_autocomplete(ProfWin* window, const char* const input, gboolean previous)
    }

    char* unquoted = strip_arg_quotes(input);
-    result = autocomplete_param_with_func(unquoted, "/win", roster_contact_autocomplete, previous, NULL);
+    result = _roster_jid_autocomplete(input, "/win", previous);
    free(unquoted);
    return result;
 }
@@ -4032,18 +4071,14 @@ _invite_autocomplete(ProfWin* window, const char* const input, gboolean previous
        return result;
    }

-    jabber_conn_status_t conn_status = connection_get_status();
+    result = _roster_jid_autocomplete(input, "/invite send", previous);
+    if (result) {
+        return result;
+    }

-    if (conn_status == JABBER_CONNECTED) {
-        result = autocomplete_param_with_func(input, "/invite send", roster_contact_autocomplete, previous, NULL);
-        if (result) {
-            return result;
-        }
-
-        result = autocomplete_param_with_func(input, "/invite decline", muc_invites_find, previous, NULL);
-        if (result) {
-            return result;
-        }
+    result = autocomplete_param_with_func(input, "/invite decline", muc_invites_find, previous, NULL);
+    if (result) {
+        return result;
    }

    return NULL;
@@ -4059,43 +4094,38 @@ _status_autocomplete(ProfWin* window, const char* const input, gboolean previous
        return result;
    }

-    jabber_conn_status_t conn_status = connection_get_status();
+    // complete with: online, away etc.
+    result = autocomplete_param_with_ac(input, "/status set", account_status_ac, TRUE, previous);
+    if (result) {
+        return result;
+    }

-    if (conn_status == JABBER_CONNECTED) {
+    // Remove quote character before and after names when doing autocomplete
+    char* unquoted = strip_arg_quotes(input);

-        // complete with: online, away etc.
-        result = autocomplete_param_with_ac(input, "/status set", account_status_ac, TRUE, previous);
-        if (result) {
-            return result;
-        }
-
-        // Remove quote character before and after names when doing autocomplete
-        char* unquoted = strip_arg_quotes(input);
-
-        // MUC completion with nicknames
-        if (window->type == WIN_MUC) {
-            ProfMucWin* mucwin = (ProfMucWin*)window;
-            assert(mucwin->memcheck == PROFMUCWIN_MEMCHECK);
-            Autocomplete nick_ac = muc_roster_ac(mucwin->roomjid);
-            if (nick_ac) {
-                result = autocomplete_param_with_ac(unquoted, "/status get", nick_ac, TRUE, previous);
-                if (result) {
-                    free(unquoted);
-                    return result;
-                }
-            }
-            // roster completion
-        } else {
-            result = autocomplete_param_with_func(unquoted, "/status get", roster_contact_autocomplete, previous, NULL);
+    // MUC completion with nicknames
+    if (window->type == WIN_MUC) {
+        ProfMucWin* mucwin = (ProfMucWin*)window;
+        assert(mucwin->memcheck == PROFMUCWIN_MEMCHECK);
+        Autocomplete nick_ac = muc_roster_ac(mucwin->roomjid);
+        if (nick_ac) {
+            result = autocomplete_param_with_ac(unquoted, "/status get", nick_ac, TRUE, previous);
            if (result) {
                free(unquoted);
                return result;
            }
        }
-
-        free(unquoted);
+        // roster completion
+    } else {
+        result = _roster_jid_autocomplete(input, "/status get", previous);
+        if (result) {
+            free(unquoted);
+            return result;
+        }
    }

+    free(unquoted);
+
    return NULL;
 }

@@ -4202,14 +4232,12 @@ _software_autocomplete(ProfWin* window, const char* const input, gboolean previo
 {
    char* result = NULL;

-    if (window->type == WIN_CHAT) {
+    if (window->type == WIN_CHAT && _is_connected()) {
        ProfChatWin* chatwin = (ProfChatWin*)window;
        assert(chatwin->memcheck == PROFCHATWIN_MEMCHECK);

-        GString* search_str = g_string_new("/software ");
-        g_string_append(search_str, chatwin->barejid);
-        result = autocomplete_param_with_func(search_str->str, "/software", roster_fulljid_autocomplete, previous, NULL);
-        g_string_free(search_str, TRUE);
+        auto_gchar gchar* search_str = g_strdup_printf("/software %s", chatwin->barejid);
+        result = autocomplete_param_with_func(search_str, "/software", roster_fulljid_autocomplete, previous, NULL);
    } else if (window->type == WIN_MUC) {
        ProfMucWin* mucwin = (ProfMucWin*)window;
        assert(mucwin->memcheck == PROFMUCWIN_MEMCHECK);
@@ -4223,10 +4251,7 @@ _software_autocomplete(ProfWin* window, const char* const input, gboolean previo
            }
        }
    } else {
-        result = autocomplete_param_with_func(input, "/software", roster_fulljid_autocomplete, previous, NULL);
-        if (result) {
-            return result;
-        }
+        result = _roster_jid_autocomplete(input, "/software", previous);
    }

    return result;
@@ -4325,16 +4350,11 @@ _lastactivity_autocomplete(ProfWin* window, const char* const input, gboolean pr
        return result;
    }

-    jabber_conn_status_t conn_status = connection_get_status();
-
-    if (conn_status == JABBER_CONNECTED) {
-
-        result = autocomplete_param_with_func(input, "/lastactivity set", prefs_autocomplete_boolean_choice, previous, NULL);
-        if (result) {
-            return result;
-        }
-        result = autocomplete_param_with_func(input, "/lastactivity get", roster_barejid_autocomplete, previous, NULL);
+    result = autocomplete_param_with_func(input, "/lastactivity set", prefs_autocomplete_boolean_choice, previous, NULL);
+    if (result) {
+        return result;
    }
+    result = _roster_jid_autocomplete(input, "/lastactivity get", previous);

    return result;
 }
@@ -4514,19 +4534,19 @@ _vcard_autocomplete(ProfWin* window, const char* const input, gboolean previous)
    } else {
        char* unquoted = strip_arg_quotes(input);

-        result = autocomplete_param_with_func(unquoted, "/vcard get", roster_contact_autocomplete, previous, NULL);
+        result = _roster_jid_autocomplete(input, "/vcard get", previous);
        if (result) {
            free(unquoted);
            return result;
        }

-        result = autocomplete_param_with_func(unquoted, "/vcard photo open", roster_contact_autocomplete, previous, NULL);
+        result = _roster_jid_autocomplete(input, "/vcard photo open", previous);
        if (result) {
            free(unquoted);
            return result;
        }

-        result = autocomplete_param_with_func(unquoted, "/vcard photo save", roster_contact_autocomplete, previous, NULL);
+        result = _roster_jid_autocomplete(input, "/vcard photo save", previous);
        if (result) {
            free(unquoted);
            return result;
--- a/src/command/cmd_funcs.c
+++ b/src/command/cmd_funcs.c
@@ -110,6 +110,15 @@ static gboolean _cmd_execute_default(ProfWin* window, const char* inp);
 static gboolean _cmd_execute_alias(ProfWin* window, const char* const inp, gboolean* ran);
 static gboolean
 _download_install_plugin(ProfWin* window, gchar* url, gchar* path);
+static const gchar*
+_resolve_contact_jid(const char* const name)
+{
+    char* barejid = roster_barejid_from_name(name);
+    if (barejid == NULL) {
+        barejid = (char*)name;
+    }
+    return barejid;
+}

 static void
 _vcard_editor_finished_cb(gchar* message, void* user_data)
@@ -3414,7 +3423,7 @@ cmd_caps(ProfWin* window, const char* const command, gchar** args)
    case WIN_CONSOLE:
    case WIN_XML:
        if (args[0]) {
-            auto_jid Jid* jid = jid_create(args[0]);
+            auto_jid Jid* jid = jid_create(_resolve_contact_jid(args[0]));

            if (jid == NULL || jid->fulljid == NULL) {
                cons_show("You must provide a full jid to the /caps command.");
@@ -3456,7 +3465,7 @@ cmd_caps(ProfWin* window, const char* const command, gchar** args)
 }

 static void
-_send_software_version_iq_to_fulljid(char* request)
+_send_software_version_iq_to_fulljid(const gchar* const request)
 {
    auto_jid Jid* jid = jid_create(request);

@@ -3497,7 +3506,7 @@ cmd_software(ProfWin* window, const char* const command, gchar** args)
        break;
    case WIN_CHAT:
        if (args[0]) {
-            _send_software_version_iq_to_fulljid(args[0]);
+            _send_software_version_iq_to_fulljid(_resolve_contact_jid(args[0]));
            break;
        } else {
            ProfChatWin* chatwin = (ProfChatWin*)window;
@@ -3521,7 +3530,7 @@ cmd_software(ProfWin* window, const char* const command, gchar** args)
        }
    case WIN_CONSOLE:
        if (args[0]) {
-            _send_software_version_iq_to_fulljid(args[0]);
+            _send_software_version_iq_to_fulljid(_resolve_contact_jid(args[0]));
        } else {
            cons_show("You must provide a jid to the /software command.");
        }
@@ -4831,7 +4840,7 @@ cmd_disco(ProfWin* window, const char* const command, gchar** args)
        return TRUE;
    }

-    auto_gchar gchar* jid = g_strdup_printf("%s", args[1] ?: connection_get_jid()->domainpart);
+    auto_gchar gchar* jid = g_strdup_printf("%s", args[1] ? _resolve_contact_jid(args[1]) : connection_get_jid()->domainpart);

    if (g_strcmp0(args[0], "info") == 0) {
        iq_disco_info_request(jid);
@@ -5053,7 +5062,7 @@ cmd_lastactivity(ProfWin* window, const char* const command, gchar** args)
        if (args[1] == NULL) {
            iq_last_activity_request(connection_get_jid()->domainpart);
        } else {
-            iq_last_activity_request(args[1]);
+            iq_last_activity_request(_resolve_contact_jid(args[1]));
        }
        return TRUE;
    }
@@ -6406,17 +6415,17 @@ cmd_ping(ProfWin* window, const char* const command, gchar** args)
        return TRUE;
    }

-    if (args[0] != NULL && caps_jid_has_feature(args[0], XMPP_FEATURE_PING) == FALSE) {
-        cons_show("%s does not support ping requests.", args[0]);
-        return TRUE;
-    }
-
-    iq_send_ping(args[0]);
-
-    if (args[0] == NULL) {
-        cons_show("Pinged server…");
+    if (args[0] != NULL) {
+        const gchar* ping_target = _resolve_contact_jid(args[0]);
+        if (caps_jid_has_feature(ping_target, XMPP_FEATURE_PING) == FALSE) {
+            cons_show("%s does not support ping requests.", ping_target);
+            return TRUE;
+        }
+        iq_send_ping(ping_target);
+        cons_show("Pinged %s…", ping_target);
    } else {
-        cons_show("Pinged %s…", args[0]);
+        iq_send_ping(NULL);
+        cons_show("Pinged server…");
    }
    return TRUE;
 }
--- a/src/xmpp/capabilities.c
+++ b/src/xmpp/capabilities.c
@@ -277,8 +277,11 @@ caps_cache_clear(void)
 {
    g_hash_table_remove_all(jid_to_ver);
    g_hash_table_remove_all(jid_to_caps);
-    cache = g_key_file_new();
-    caps_prof_keyfile.keyfile = cache;
+    if (caps_prof_keyfile.keyfile) {
+        g_key_file_free(caps_prof_keyfile.keyfile);
+    }
+    caps_prof_keyfile.keyfile = g_key_file_new();
+    cache = caps_prof_keyfile.keyfile;
    save_keyfile(&caps_prof_keyfile);
 }

--- a/src/xmpp/jid.c
+++ b/src/xmpp/jid.c
@@ -280,9 +280,13 @@ jid_fulljid_or_barejid(Jid* jid)
 gchar*
 jid_random_resource(void)
 {
-    auto_gchar gchar* rand = get_random_string(5);
+    gchar* rand = g_malloc0(29);
+    const gchar* digits = "0123456789";

-    gchar* result = g_strdup_printf("%s", rand);
+    for (int i = 0; i < 28; i++) {
+        rand[i] = digits[g_random_int_range(0, 10)];
+    }
+    rand[28] = '\0';

-    return result;
+    return rand;
 }
--- a/src/xmpp/stanza.c
+++ b/src/xmpp/stanza.c
@@ -931,19 +931,22 @@ stanza_create_caps_query_element(xmpp_ctx_t* ctx)

    xmpp_stanza_t* identity = xmpp_stanza_new(ctx);
    xmpp_stanza_set_name(identity, "identity");
-    xmpp_stanza_set_attribute(identity, "category", "client");
    xmpp_stanza_set_type(identity, "pc");
+    xmpp_stanza_set_attribute(identity, "category", "client");

    ProfAccount* account = accounts_get_account(session_get_account_name());
-    gchar* client = account->client;
-    bool is_custom_client = client != NULL;

-    GString* name_str = g_string_new(is_custom_client ? client : "Pidgin");
+    auto_gchar gchar* name = g_strdup(account->client ? account->client : "Pidgin");

+    if (account->client) {
+        gchar* space = strchr(name, ' ');
+        if (space) {
+            *space = '\0';
+        }
+    }
    account_free(account);

-    xmpp_stanza_set_attribute(identity, "name", name_str->str);
-    g_string_free(name_str, TRUE);
+    xmpp_stanza_set_attribute(identity, "name", name);
    xmpp_stanza_add_child(query, identity);
    xmpp_stanza_release(identity);

@@ -1995,35 +1998,33 @@ static const char*
 _stanza_get_caps_node(const char* const client)
 {
    if (!client || g_strcmp0(client, "") == 0) {
-        static const char* pidgin_node = "http://pidgin.im/";
-        return pidgin_node;
+        return "http://pidgin.im";
    }

    auto_gchar gchar* lower = g_ascii_strdown(client, -1);

    if (g_str_has_prefix(lower, "pidgin")) {
-        static const char* pidgin_node = "http://pidgin.im/";
-        return pidgin_node;
+        return "http://pidgin.im";
    }

    if (g_str_has_prefix(lower, "gajim")) {
-        static const char* gajim_node = "https://gajim.org/";
-        return gajim_node;
+        return "https://gajim.org";
    }

    if (g_str_has_prefix(lower, "conversations")) {
-        static const char* conv_node = "https://conversations.im/";
-        return conv_node;
+        return "https://conversations.im";
    }

    if (g_str_has_prefix(lower, "psi+")) {
-        static const char* psip_node = "http://psi-plus.com/";
-        return psip_node;
+        return "http://psi-plus.com";
    }

    if (g_str_has_prefix(lower, "psi")) {
-        static const char* psi_node = "http://psi-im.org/";
-        return psi_node;
+        return "http://psi-im.org";
+    }
+
+    if (g_str_has_prefix(lower, "profanity")) {
+        return "http://profanity-im.github.io";
    }

    return "";
--- a/tests/functionaltests/proftest.c
+++ b/tests/functionaltests/proftest.c
@@ -601,11 +601,11 @@ prof_connect_with_roster(const char* roster)
    assert_true(prof_output_regex(".+online.+ \\(priority 0\\)\\."));

    expect_timeout = EXPECT_TIMEOUT_CONNECT;
-    // Wait for presence stanza to be sent (content-based, not ID-based)
+    // Wait for presence stanza to be sent
    // Match the actual attribute order from stanza_attach_caps
    assert_true(stbbr_received(
        "<presence id=\"*\">"
-        "<c xmlns=\"http://jabber.org/protocol/caps\" hash=\"sha-1\" node=\"http://profanity-im.github.io\" ver=\"*\"/>"
+        "<c xmlns=\"http://jabber.org/protocol/caps\" hash=\"sha-1\" node=\"*\" ver=\"*\"/>"
        "</presence>"));
 }

--- a/tests/functionaltests/test_connect.c
+++ b/tests/functionaltests/test_connect.c
@@ -25,7 +25,7 @@ connect_jid_sends_presence_after_receiving_roster(void **state)

    assert_true(stbbr_received(
        "<presence id='*'>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='http://profanity-im.github.io'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
        "</presence>"
    ));
 }
--- a/tests/functionaltests/test_export_import.c
+++ b/tests/functionaltests/test_export_import.c
@@ -1289,7 +1289,7 @@ _join_muc(const char* room)
    snprintf(presence, sizeof(presence),
        "<presence id='*' lang='en' to='stabber@localhost/profanity' from='%s/stabber'>"
            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' "
-               "node='http://profanity-im.github.io' ver='*'/>"
+               "node='*' ver='*'/>"
            "<x xmlns='http://jabber.org/protocol/muc#user'>"
                "<item role='participant' jid='stabber@localhost/profanity' affiliation='none'/>"
            "</x>"
--- a/tests/functionaltests/test_muc.c
+++ b/tests/functionaltests/test_muc.c
@@ -26,7 +26,7 @@ sends_room_join(void **state)
    assert_true(stbbr_received(
        "<presence id='*' to='testroom@conference.localhost/stabber'>"
            "<x xmlns='http://jabber.org/protocol/muc'/>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='http://profanity-im.github.io'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
        "</presence>"
    ));
 }
@@ -41,7 +41,7 @@ sends_room_join_with_nick(void **state)
    assert_true(stbbr_received(
        "<presence id='*' to='testroom@conference.localhost/testnick'>"
            "<x xmlns='http://jabber.org/protocol/muc'/>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='http://profanity-im.github.io'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
        "</presence>"
    ));
 }
@@ -58,7 +58,7 @@ sends_room_join_with_password(void **state)
            "<x xmlns='http://jabber.org/protocol/muc'>"
                "<password>testpassword</password>"
            "</x>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='http://profanity-im.github.io'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
        "</presence>"
    ));
 }
@@ -75,7 +75,7 @@ sends_room_join_with_nick_and_password(void **state)
            "<x xmlns='http://jabber.org/protocol/muc'>"
                "<password>testpassword</password>"
            "</x>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='http://profanity-im.github.io'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
        "</presence>"
    ));
 }
@@ -87,7 +87,7 @@ shows_role_and_affiliation_on_join(void **state)

    stbbr_for_presence_to("testroom@conference.localhost/stabber",
        "<presence id='*' lang='en' to='stabber@localhost/profanity' from='testroom@conference.localhost/stabber'>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' node='http://profanity-im.github.io' ver='*'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' node='*' ver='*'/>"
            "<x xmlns='http://jabber.org/protocol/muc#user'>"
                "<item role='participant' jid='stabber@localhost/profanity' affiliation='none'/>"
            "</x>"
@@ -107,7 +107,7 @@ shows_subject_on_join(void **state)

    stbbr_for_presence_to("testroom@conference.localhost/stabber",
        "<presence id='*' lang='en' to='stabber@localhost/profanity' from='testroom@conference.localhost/stabber'>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' node='http://profanity-im.github.io' ver='*'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' node='*' ver='*'/>"
            "<x xmlns='http://jabber.org/protocol/muc#user'>"
                "<item role='participant' jid='stabber@localhost/profanity' affiliation='none'/>"
            "</x>"
@@ -135,7 +135,7 @@ shows_history_message(void **state)

    stbbr_for_presence_to("testroom@conference.localhost/stabber",
        "<presence id='*' lang='en' to='stabber@localhost/profanity' from='testroom@conference.localhost/stabber'>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' node='http://profanity-im.github.io' ver='*'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' node='*' ver='*'/>"
            "<x xmlns='http://jabber.org/protocol/muc#user'>"
                "<item role='participant' jid='stabber@localhost/profanity' affiliation='none'/>"
            "</x>"
@@ -170,7 +170,7 @@ shows_occupant_join(void **state)

    stbbr_for_presence_to("testroom@conference.localhost/stabber",
        "<presence id='*' lang='en' to='stabber@localhost/profanity' from='testroom@conference.localhost/stabber'>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' node='http://profanity-im.github.io' ver='*'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' node='*' ver='*'/>"
            "<x xmlns='http://jabber.org/protocol/muc#user'>"
                "<item role='participant' jid='stabber@localhost/profanity' affiliation='none'/>"
            "</x>"
@@ -200,7 +200,7 @@ shows_message(void **state)

    stbbr_for_presence_to("testroom@conference.localhost/stabber",
        "<presence id='*' lang='en' to='stabber@localhost/profanity' from='testroom@conference.localhost/stabber'>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' node='http://profanity-im.github.io' ver='*'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' node='*' ver='*'/>"
            "<x xmlns='http://jabber.org/protocol/muc#user'>"
                "<item role='participant' jid='stabber@localhost/profanity' affiliation='none'/>"
            "</x>"
@@ -227,7 +227,7 @@ shows_me_message_from_occupant(void **state)

    stbbr_for_presence_to("testroom@conference.localhost/stabber",
        "<presence id='*' lang='en' to='stabber@localhost/profanity' from='testroom@conference.localhost/stabber'>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' node='http://profanity-im.github.io' ver='*'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' node='*' ver='*'/>"
            "<x xmlns='http://jabber.org/protocol/muc#user'>"
                "<item role='participant' jid='stabber@localhost/profanity' affiliation='none'/>"
            "</x>"
@@ -254,7 +254,7 @@ shows_me_message_from_self(void **state)

    stbbr_for_presence_to("testroom@conference.localhost/stabber",
        "<presence id='*' lang='en' to='stabber@localhost/profanity' from='testroom@conference.localhost/stabber'>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' node='http://profanity-im.github.io' ver='*'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' node='*' ver='*'/>"
            "<x xmlns='http://jabber.org/protocol/muc#user'>"
                "<item role='participant' jid='stabber@localhost/profanity' affiliation='none'/>"
            "</x>"
@@ -281,7 +281,7 @@ shows_all_messages_in_console_when_window_not_focussed(void **state)

    stbbr_for_presence_to("testroom@conference.localhost/stabber",
        "<presence id='*' lang='en' to='stabber@localhost/profanity' from='testroom@conference.localhost/stabber'>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' node='http://profanity-im.github.io' ver='*'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' node='*' ver='*'/>"
            "<x xmlns='http://jabber.org/protocol/muc#user'>"
                "<item role='participant' jid='stabber@localhost/profanity' affiliation='none'/>"
            "</x>"
@@ -322,7 +322,7 @@ shows_first_message_in_console_when_window_not_focussed(void **state)

    stbbr_for_presence_to("testroom@conference.localhost/stabber",
        "<presence id='*' lang='en' to='stabber@localhost/profanity' from='testroom@conference.localhost/stabber'>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' node='http://profanity-im.github.io' ver='*'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' node='*' ver='*'/>"
            "<x xmlns='http://jabber.org/protocol/muc#user'>"
                "<item role='participant' jid='stabber@localhost/profanity' affiliation='none'/>"
            "</x>"
@@ -369,7 +369,7 @@ shows_no_message_in_console_when_window_not_focussed(void **state)

    stbbr_for_presence_to("testroom@conference.localhost/stabber",
        "<presence id='*' lang='en' to='stabber@localhost/profanity' from='testroom@conference.localhost/stabber'>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' node='http://profanity-im.github.io' ver='*'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' node='*' ver='*'/>"
            "<x xmlns='http://jabber.org/protocol/muc#user'>"
                "<item role='participant' jid='stabber@localhost/profanity' affiliation='none'/>"
            "</x>"
@@ -401,7 +401,7 @@ sends_affiliation_list_request(void **state)

    stbbr_for_presence_to("testroom@conference.localhost/stabber",
        "<presence id='*' lang='en' to='stabber@localhost/profanity' from='testroom@conference.localhost/stabber'>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' node='http://profanity-im.github.io' ver='*'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' node='*' ver='*'/>"
            "<x xmlns='http://jabber.org/protocol/muc#user'>"
                "<item role='moderator' jid='stabber@localhost/profanity' affiliation='owner'/>"
            "</x>"
@@ -434,7 +434,7 @@ sends_kick_request(void **state)

    stbbr_for_presence_to("testroom@conference.localhost/stabber",
        "<presence id='*' lang='en' to='stabber@localhost/profanity' from='testroom@conference.localhost/stabber'>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' node='http://profanity-im.github.io' ver='*'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' node='*' ver='*'/>"
            "<x xmlns='http://jabber.org/protocol/muc#user'>"
                "<item role='moderator' jid='stabber@localhost/profanity' affiliation='admin'/>"
            "</x>"
--- a/tests/functionaltests/test_presence.c
+++ b/tests/functionaltests/test_presence.c
@@ -19,7 +19,7 @@ presence_online(void **state)
    assert_true(stbbr_received(
        "<presence id='*'>"
            "<status>online</status>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='http://profanity-im.github.io'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
        "</presence>"
    ));
 }
@@ -36,7 +36,7 @@ presence_online_with_message(void **state)
    assert_true(stbbr_received(
        "<presence id='*'>"
            "<status>Hi there</status>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='http://profanity-im.github.io'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
        "</presence>"
    ));
 }
@@ -54,7 +54,7 @@ presence_away(void **state)
        "<presence id='*'>"
            "<show>away</show>"
            "<status>away</status>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='http://profanity-im.github.io'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
        "</presence>"
    ));
 }
@@ -72,7 +72,7 @@ presence_away_with_message(void **state)
        "<presence id='*'>"
            "<show>away</show>"
            "<status>I'm not here for a bit</status>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='http://profanity-im.github.io'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
        "</presence>"
    ));
 }
@@ -90,7 +90,7 @@ presence_xa(void **state)
        "<presence id='*'>"
            "<show>xa</show>"
            "<status>xa</status>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='http://profanity-im.github.io'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
        "</presence>"
    ));
 }
@@ -108,7 +108,7 @@ presence_xa_with_message(void **state)
        "<presence id='*'>"
            "<show>xa</show>"
            "<status>Gone to the shops</status>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='http://profanity-im.github.io'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
        "</presence>"
    ));
 }
@@ -126,7 +126,7 @@ presence_dnd(void **state)
        "<presence id='*'>"
            "<show>dnd</show>"
            "<status>dnd</status>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='http://profanity-im.github.io'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
        "</presence>"
    ));
 }
@@ -144,7 +144,7 @@ presence_dnd_with_message(void **state)
        "<presence id='*'>"
            "<show>dnd</show>"
            "<status>Working</status>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='http://profanity-im.github.io'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
        "</presence>"
    ));
 }
@@ -162,7 +162,7 @@ presence_chat(void **state)
        "<presence id='*'>"
            "<show>chat</show>"
            "<status>chat</status>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='http://profanity-im.github.io'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
        "</presence>"
    ));
 }
@@ -180,7 +180,7 @@ presence_chat_with_message(void **state)
        "<presence id='*'>"
            "<show>chat</show>"
            "<status>Free to talk</status>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='http://profanity-im.github.io'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
        "</presence>"
    ));
 }
@@ -197,7 +197,7 @@ presence_set_priority(void **state)
    assert_true(stbbr_received(
        "<presence id='*'>"
            "<priority>25</priority>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='http://profanity-im.github.io'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
        "</presence>"
    ));
 }
@@ -212,7 +212,7 @@ presence_includes_priority(void **state)
    assert_true(stbbr_received(
        "<presence id='*'>"
            "<priority>25</priority>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='http://profanity-im.github.io'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
        "</presence>"
    ));

@@ -223,7 +223,7 @@ presence_includes_priority(void **state)
            "<priority>25</priority>"
            "<show>chat</show>"
            "<status>Free to talk</status>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='http://profanity-im.github.io'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
        "</presence>"
    ));
 }
@@ -239,7 +239,7 @@ presence_keeps_status(void **state)
        "<presence id='*'>"
            "<show>chat</show>"
            "<status>Free to talk</status>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='http://profanity-im.github.io'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
        "</presence>"
    ));

@@ -250,7 +250,7 @@ presence_keeps_status(void **state)
            "<show>chat</show>"
            "<status>Free to talk</status>"
            "<priority>25</priority>"
-            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='http://profanity-im.github.io'/>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
        "</presence>"
    ));
 }
Author	SHA1	Message	Date
Jabber Developer	b7dec705c3	fix(autocomplete): guard history completion safely All checks were successful CI Code / Check spelling (pull_request) Successful in 12s Details CI Code / Check coding style (pull_request) Successful in 23s Details CI Code / Code Coverage (pull_request) Successful in 3m40s Details CI Code / Linux (debian) (pull_request) Successful in 5m14s Details CI Code / Linux (ubuntu) (pull_request) Successful in 5m20s Details CI Code / Linux (arch) (pull_request) Successful in 7m23s Details Prevent autocomplete crashes on asset failures when executing history subcommands without an active connection by validating the session state beforehand. Standardize JID resolution across command handlers to ensure consistent contact lookup behavior. Use auto_gchar gchar instead of GString for performance and readability purposes.	2026-07-11 16:09:36 +00:00
Jabber Developer	b208e48ee1	feat(cli): resolve contact names to JIDs in multiple commands and improve autocomplete Introduce _resolve_contact_jid helper to convert contact names to JIDs. Apply this helper to /caps, /software, /disco, /lastactivity, and /ping commands, allowing users to specify contacts by name instead of full JIDs. Enhance command-line autocomplete by adding _disco_autocomplete and _roster_jid_autocomplete functions. Update /caps autocomplete to utilize the new roster resolution logic and ensure it only returns results when connected.	2026-07-11 15:54:32 +00:00
Jabber Developer	c5dd0cf9df	fix(xmpp): obfuscate client identity in protocol exchanges All checks were successful CI Code / Check spelling (pull_request) Successful in 12s Details CI Code / Check coding style (pull_request) Successful in 24s Details CI Code / Code Coverage (pull_request) Successful in 3m54s Details CI Code / Linux (debian) (pull_request) Successful in 5m16s Details CI Code / Linux (ubuntu) (pull_request) Successful in 5m22s Details CI Code / Linux (arch) (pull_request) Successful in 6m56s Details CI Code / Check spelling (push) Successful in 13s Details CI Code / Check coding style (push) Successful in 27s Details CI Code / Code Coverage (push) Successful in 3m35s Details CI Code / Linux (debian) (push) Successful in 5m41s Details CI Code / Linux (ubuntu) (push) Successful in 5m52s Details CI Code / Linux (arch) (push) Successful in 7m36s Details Modify version responses to return a generic client name and omit version strings. Drop the "profanity." prefix from dynamically generated JID resources. Spoof the XEP-0115 capabilities node URI to prevent service discovery/presence fingerprinting. These adjustments reduce the client's attack surface by minimizing identifiable metadata.	2026-07-10 08:54:24 +00:00
Jabber Developer	b34faa2099	feat(caps): add cache clearing to /caps Add /caps clear to wipe the local capabilities cache. Implement autocomplete for new subcommand.	2026-07-10 08:12:56 +00:00