cproof

Author	SHA1	Message	Date
Jabber Developer	eefebba9b6	Revert "Temporarily disable Fedora tests" Some checks failed CI / Check spelling (pull_request) Successful in 17s Details CI / Check coding style (pull_request) Successful in 28s Details CI / Linux (debian) (pull_request) Successful in 10m25s Details CI / Linux (ubuntu) (pull_request) Successful in 10m49s Details CI / Linux (arch) (pull_request) Successful in 13m21s Details CI / Linux (fedora) (pull_request) Failing after 1m3s Details This reverts commit `a3e23c3514`. Reenable Fedora tests	2025-08-26 15:47:34 +02:00
Jabber Developer	a3e23c3514	Temporarily disable Fedora tests All checks were successful CI / Check spelling (pull_request) Successful in 15s Details CI / Check coding style (pull_request) Successful in 28s Details CI / Linux (arch) (pull_request) Successful in 11m52s Details CI / Linux (ubuntu) (pull_request) Successful in 11m59s Details CI / Linux (debian) (pull_request) Successful in 12m2s Details CI / Check spelling (push) Successful in 17s Details CI / Check coding style (push) Successful in 30s Details CI / Linux (ubuntu) (push) Successful in 10m9s Details CI / Linux (arch) (push) Successful in 12m4s Details CI / Linux (debian) (push) Successful in 13m0s Details They are failing on our runners due to issues with dependency resolution.	2025-08-07 03:27:14 +02:00
Jabber Developer	ad294cdd6d	feat(editor): add asynchronous external editor support Some checks failed CI / Check spelling (pull_request) Successful in 18s Details CI / Check coding style (pull_request) Successful in 31s Details CI / Linux (fedora) (pull_request) Failing after 1m14s Details CI / Linux (debian) (pull_request) Successful in 10m19s Details CI / Linux (ubuntu) (pull_request) Successful in 10m42s Details CI / Linux (arch) (pull_request) Successful in 13m2s Details The synchronous `get_message_from_editor` blocked the main loop (`prof_run`) while launching an external editor like `vim`, halting network I/O in `session_process_events` and preventing incoming message reception. Introduced `get_message_from_editor_async` for `cmd_editor` to run the editor asynchronously. It forks and execs the editor in a thread (`editor_thread`), suspending NCurses to free the terminal. The main loop skips `inp_readline` and `ui_update` via a new `background_mode` flag while the editor runs, allowing `session_process_events` to keep the connection alive. On editor completion, `editor_process` (called per loop iteration) resumes NCurses with `ui_resize`, inserts the result into the readline buffer and clears `background_mode`. Retained synchronous `get_message_from_editor` for ~20 existing code paths (e.g., `vcard_nickname`) to avoid breaking them. Tested with `vim` and `nano`: confirms no rendering conflicts, messages received during editing, and seamless resume. Edge cases like editor crashes handled via error logging and seamless resume.	2025-08-07 03:03:43 +02:00

1 changed files with 1 additions and 0 deletions

									
										1

src/tools/editor.c
									
												View File
												
				@@ -38,6 +38,7 @@

				#include <fcntl.h>

				#include <glib.h>

				#include <errno.h>

				#include <stdio.h> // necessary for readline

				#include <readline/readline.h>

				#include <sys/wait.h>

				#include <unistd.h>

Compare commits

3 Commits

c4e2e46636 ... build/reen

1

src/tools/editor.c

View File

Compare commits

3 Commits c4e2e46636 ... build/reen

1 src/tools/editor.c Unescape Escape View File

3 Commits

c4e2e46636 ... build/reen

1

src/tools/editor.c

View File