Compare commits

merge into: devs:chore/remove-chatlog-stage-1

Branches Tags

devs:master devs:feat/ai-api-type devs:fix/editor-terminal-size devs:ci/docker-hub-publishing devs:feat/disco-ac devs:feat/privacy-enhancements devs:fix/clientid-regression devs:fix/ai-chat-completions-followup devs:feat/ai-custom devs:fix/unencrypted-send devs:rollback/pre-upstream-merge devs:fix/autoping-warning-null-domain devs:fix/pad-dead-space-reclaim devs:feat/autoping-warning devs:chore/untrack-gitversion devs:fix/multiline-pad-clip devs:fix/issue-112-followups devs:fix/issue-128-migrate-v3-dedup devs:fix/delay-timestamp-validation devs:ref/light-cleanup devs:fix/history-scroll-pad-redraw-storm devs:fix/plugin-post-display-incoming-only devs:merge/upstream-full devs:merge-improve devs:chore/remove-chatlog-stage-1 devs:fix/ai-json-encoding devs:feat/no-db-backlog-114 devs:fix/scroll-non-chat-windows devs:fix/paged-non-chat-windows devs:fix/ai-leaks devs:feat/ai devs:fix/ai-followups devs:test/ai-coverage-unit-only devs:test/ai-coverage devs:refactor/scroll-mechanism devs:fix/verify-per-contact-context devs:feat/no-db-mode devs:feat/ai-json devs:feat/pikaur-parity-arch devs:fix-pikaur-build devs:feat/upstream-sync devs:feat/functest-speedup devs:fix/cwe-134-format-string-audit devs:ci/separate-build-step devs:test/autoping-functional-tests devs:test/db-functional-tests devs:fix/arch-build devs:fix/xep-0030-disco-items-error-handling devs:fix/xep-0030-empty-disco-items devs:playground/fix/src_refactoring devs:tests/disco devs:fix/test-CI-stability devs:feat/parallel-tests-clean devs:feat/parallel-functional-tests devs:fix/functional_tests_v2 devs:fix/functional_tests devs:fix/connect_max_args devs:feat/extended_debug_info devs:playground/fix/scroll-stuck devs:build/multicore devs:build/reenable-fedora devs:build/autoupdate

...

pull from: devs:rollback/pre-upstream-merge

Branches Tags

devs:feat/ai-api-type devs:fix/editor-terminal-size devs:ci/docker-hub-publishing devs:master devs:feat/disco-ac devs:feat/privacy-enhancements devs:fix/clientid-regression devs:fix/ai-chat-completions-followup devs:feat/ai-custom devs:fix/unencrypted-send devs:rollback/pre-upstream-merge devs:fix/autoping-warning-null-domain devs:fix/pad-dead-space-reclaim devs:feat/autoping-warning devs:chore/untrack-gitversion devs:fix/multiline-pad-clip devs:fix/issue-112-followups devs:fix/issue-128-migrate-v3-dedup devs:fix/delay-timestamp-validation devs:ref/light-cleanup devs:fix/history-scroll-pad-redraw-storm devs:fix/plugin-post-display-incoming-only devs:merge/upstream-full devs:merge-improve devs:chore/remove-chatlog-stage-1 devs:fix/ai-json-encoding devs:feat/no-db-backlog-114 devs:fix/scroll-non-chat-windows devs:fix/paged-non-chat-windows devs:fix/ai-leaks devs:feat/ai devs:fix/ai-followups devs:test/ai-coverage-unit-only devs:test/ai-coverage devs:refactor/scroll-mechanism devs:fix/verify-per-contact-context devs:feat/no-db-mode devs:feat/ai-json devs:feat/pikaur-parity-arch devs:fix-pikaur-build devs:feat/upstream-sync devs:feat/functest-speedup devs:fix/cwe-134-format-string-audit devs:ci/separate-build-step devs:test/autoping-functional-tests devs:test/db-functional-tests devs:fix/arch-build devs:fix/xep-0030-disco-items-error-handling devs:fix/xep-0030-empty-disco-items devs:playground/fix/src_refactoring devs:tests/disco devs:fix/test-CI-stability devs:feat/parallel-tests-clean devs:feat/parallel-functional-tests devs:fix/functional_tests_v2 devs:fix/functional_tests devs:fix/connect_max_args devs:feat/extended_debug_info devs:playground/fix/scroll-stuck devs:build/multicore devs:build/reenable-fedora devs:build/autoupdate

15 Commits

chore/remo ... rollback/p

Author	SHA1	Message	Date
jabber.developer2	f9e184eda7	revert: restore pre-upstream-merge baseline (tree of 3b673150b) ... Roll the tree back to the pre-merge tip 3b673150b, undoing the upstream sync merge 72f4f186d (303 files) and the 13 post-merge commits layered on top of it. Purpose: restore the last pre-sync baseline so the reported OMEMO/OTR encryption regressions can be reproduced against a known-good state and the upstream sync ruled in or out as the cause. Nothing is dropped from history; the merge and every post-merge commit remain reachable and can be cherry-picked back selectively. Baseline: 3b673150b chore(chatlog): disable background message file logging (stage 1) Undoes merge: 72f4f186d merge: sync upstream profanity-im/profanity	2026-06-29 12:17:01 +03:00
Jabber Developer	ca92d29179	fix(ui): measure dead pad space from cursor instead of absolute height ... Remove the /autoping warning subcommand and PREF_AUTOPING_WARNING preference entirely. The warning was shown at connect time when autoping was disabled but the server supported XEP-0199 ping. The pad threshold logic previously used an absolute height (PAD_THRESHOLD=12000) which was above the buffer cap and never fired during normal scrolling. Replace with a dead-space measurement (cursor position minus live buffer lines) that only triggers a redraw when dead space exceeds PAD_DEAD_SPACE_LIMIT (2000 lines). Author: jabber.developer2 <jabber.developer2@jabber.space>	2026-06-24 16:22:52 +00:00
jabber.developer2	72aa603147	build: untrack generated src/gitversion.h.in ... The file is gitignored and regenerated by the build recipe from .git/HEAD/.git/index; it was committed by mistake during the upstream sync. Untrack it so builds no longer dirty the working tree. The version string behaviour is unchanged.	2026-06-23 12:33:49 +00:00
jabber.developer2	15dfc2bdb4	fix(xmpp): guard NULL domain in autoping disco warning gate ... g_ascii_strcasecmp() is not NULL-safe (unlike the g_strcmp0 it replaced), and connection_get_domain() can be NULL (init NULL, FREE_SET_NULL on teardown). A disco#info response racing a disconnect would dereference NULL. Capture the domain and skip the check when it is NULL.	2026-06-23 14:23:11 +03:00
Jabber Developer	02e679c277	feat(autoping): autoping availability warning ... ## Introduced change A new warning that notifies users when the connected XMPP server advertises XEP-0199 (urn:xmpp:ping) support but the autoping feature is disabled in settings. The warning can be toggled with `/autoping warning on|off`. The warning fires during the on-connect disco#info exchange, only for responses from the server's own domain — responses from user JIDs or subdomain services (e.g., conference servers) are excluded. ### Capabilities - **On-connect detection**: Warning is emitted automatically when the server's disco#info response indicates `urn:xmpp:ping` support while autoping is disabled and the preference is enabled (default: on) - **`/autoping warning on|off`**: Toggle the warning via the existing autoping command - **Domain-scoped**: Only triggers for disco#info from the bound server domain; user JIDs and subdomain service JIDs are skipped - **Case-insensitive domain matching**: Uses `g_ascii_strcasecmp` instead of `g_strcmp0` to handle case differences between the stanza `from` field and the bound domain - **Display in settings**: Shown in both `/notify` and `/autoping` settings dumps, with consistent alignment and `(/autoping warning)` reference in each line - **Autocomplete**: Dedicated `_autoping_autocomplete` function handles the `warning` subcommand with `on|off` completion ## Reasoning behind the change Users connecting to servers that support XEP-0199 ping but have autoping disabled may experience poorer connection stability. The warning draws attention to this configuration mismatch without requiring users to read documentation or dig into settings. The warning is scoped to the server domain (not user JIDs or subdomain services) because autoping is a connection-level feature — it only makes sense in the context of the server's keepalive capabilities. The warning preference defaults to `on` so users are informed by default, but can be disabled with `/autoping warning off` if they prefer not to see it. ## Implementation details ### Warning logic (`src/xmpp/iq.c`) `_disco_autoping_warning_message()` is called from the on-connect disco#info handler when the `from` field matches the bound domain. It checks three conditions: 1. Server features contain `urn:xmpp:ping` 2. Autoping interval is 0 (disabled) 3. `PREF_AUTOPING_WARNING` is true All three must be true for the warning to display. ### Domain matching `g_ascii_strcasecmp(from, connection_get_domain())` is used instead of `g_strcmp0` to handle case differences. This prevents the warning from silently skipping if a server echoes the `from` field in a different case than the bound domain. ### Command integration (`src/command/cmd_*.c`) - `cmd_defs.c`: Added `/autoping warning on|off` syntax and argument description - `cmd_funcs.c`: Added `warning` subcommand handler that calls `_cmd_set_boolean_preference` with `PREF_AUTOPING_WARNING` - `cmd_ac.c`: Registered dedicated `_autoping_autocomplete` that handles the `warning` subcommand with `on|off` boolean completion ### Preference storage (`src/config/preferences.c`) - Group: `PREF_GROUP_NOTIFICATIONS` - Key: `autoping.warning` - Default: `TRUE` ### Settings display (`src/ui/console.c`) The autoping warning preference is shown in both `cons_notify_setting()` and `cons_autoping_setting()` with consistent column alignment and a `(/autoping warning)` reference in each line. ### Tests (`tests/functionaltests/test_autoping.c`) Six functional tests cover all condition combinations: | Test | Server ping | Autoping | Warning pref | Expected | |---|---|---|---|---| | `autoping_warning_shown_when_disabled` | yes | off | on | warning shown | | `autoping_warning_not_shown_when_server_unsupported` | no | off | on | no warning | | `autoping_warning_not_shown_when_autoping_enabled` | yes | on | on | no warning | | `autoping_warning_not_shown_when_user_disabled` | yes | off | off | no warning | | `autoping_warning_not_shown_for_user_jid` | yes (from user JID) | off | on | no warning | | `autoping_warning_not_shown_for_subdomain_service` | yes (from subdomain) | off | on | no warning | Co-authored-by: Jabber Developer2 <jabber.developer2@jabber.space>	2026-06-23 11:11:25 +00:00
Jabber Developer	830479cf20	fix: OTR/presence/OMEMO correctness, stanza-id disco gate, build hardening ... - OTR: strip the whitespace tag by shifting the full message tail incl. the NUL, not tag_length bytes, so the body is no longer duplicated for messages longer than the tag. - presence: snapshot the resource fields before connection_add_available_resource() takes ownership, removing a use-after-free in the own-presence path. - OMEMO: propagate _omemo_finalize_identity_load() failure on connect (log + cons_show_error + stop) instead of leaving OMEMO silently unavailable. - OMEMO: guard NULL fingerprint decode in _omemo_fingerprint_decode / omemo_is_trusted_identity / omemo_trust and log every decode failure instead of failing silently. - stanza-id: gate XEP-0359 dedup on disco urn:xmpp:sid:0 (the `by` JID or its domain), falling back to no-dedup when caps are unknown; add functional tests for trusted vs untrusted server. - accounts: narrow the group-name sanitizer to the characters GKeyFile forbids in headers ([ ] \n \r), keeping `=` and `#`, so read/write stays symmetric. - build: re-introduce compiler/sanitizer flags in a Pikaur-safe form (opt-in sanitizers, -Wsign-compare) and fix the resulting -Wsign-compare warnings (incl. proftest _mkdir_recursive).fix: OTR/presence/OMEMO correctness, stanza-id disco gate, build hardening Author: jabber.developer2 <jabber.developer2@jabber.space>	2026-06-20 10:30:23 +00:00
jabber.developer2	2d3d1ced71	ref(ui): use MAX utility method for code conciseness and clarity	2026-06-20 09:40:11 +00:00
jabber.developer2	adb078a3e2	fix(ui): reserve pad height per message to prevent multi-line clip and scroll desync ... A tall multi-line message printed near the bottom of the ncurses pad was clipped because _win_print_internal grew the pad from the current cursor only (_win_ensure_pad_capacity(getcury)), not the height of the message about to be printed. The clipped message's captured height (e.g. 1 row for a 49-row message) was wrong while win_redraw later rendered it in full; the resulting buffer->lines / y_start_pos mismatch desynced the page-up scroll anchor, producing a ~one-page jump when scrolling past such messages from history. Estimate the rendered height (hard newlines + soft-wrap over the usable width) and reserve that many rows before printing, so the message is never clipped and its captured height matches the redraw. All print paths go through _win_print_internal, so incoming/outgoing/history are covered. Regression from the upstream sync (72f4f186d), which replaced the fixed-size pad with the dynamic _win_ensure_pad_capacity model.	2026-06-20 11:59:19 +03:00
Jabber Developer	5b45b35b3e	refactor: rename argument to avoid C++ keyword conflict ... The parameter `template` in format_call_external_argv() was renamed to `template_fmt` to avoid collision with the `template` keyword in C++. This improves compatibility when the header is included in C++ code.	2026-06-16 11:21:11 +00:00
Jabber Developer	57d79ecf9c	fix: add missing parameter types to function declarations ... Some functions were declared without parameters in header files, despite their implementations specifying arguments. This mismatch is deprecated in all versions of C and is disallowed in C23. This change updates the declarations to match their definitions, ensuring compatibility with C standards, avoiding potential undefined behavior, and improving support in tools and editors.	2026-06-16 11:21:11 +00:00
Jabber Developer	bfd7064a40	build: add missing includes to header files ... This change adds necessary `#include` directives that were previously omitted in some header files. Without these includes, compilation could fail or produce undefined behavior when the headers are used in isolation (i.e., before their dependencies are included elsewhere). Ensures better modularity and reliability of header usage.	2026-06-16 11:21:11 +00:00
jabber.developer2	3f6b8f69fd	fix(ui): raise pad redraw threshold above buffer cap to fix history scroll ... PAD_THRESHOLD (3000) sat below the buffer line cap (PAD_SIZE - PAD_SIZE/10 = 9000), so _win_ensure_pad_capacity() fired a full win_redraw() from the hot print path on every message once a chat exceeded 3000 rendered lines. During history paging this turned one redraw per fetch into dozens, corrupting per-entry y_start_pos (offset jumps, dropped/skipped messages) and causing ~10s lag per page. The flat-file backend was byte-identical across the regression; the fault was purely in the UI pad path from the upstream merge. Raise PAD_THRESHOLD to 12000 (above the cap) so the reclaim redraw only fires to drop dead pad space in long append-only sessions, never during scrolling. Also size the pad once to buffer->lines+100 in win_redraw() instead of shrinking to PAD_MIN_HEIGHT and regrowing per entry, removing the residual per-redraw wresize churn.	2026-06-08 16:03:33 +03:00
jabber.developer2	a04a8948e1	fix(chatwin): only fire plugins_post_chat_message_display on incoming ... The trigger was wired into outgoing / outgoing-carbon / history paths too, which made plugins like sounds.py play the "new message" sound when opening a chat (history loads), sending a message yourself, or receiving a carbon of your own sent message from another device. Restrict the call to chatwin_incoming_msg — matches the semantic of "a remote party sent a chat message and it was displayed".	2026-06-01 16:31:14 +03:00
Jabber Developer	c1093db090	fix(editor): prevent UI redraw conflicts during editor suspend/resume ... Guard against re-entrant editor launches, abort editor on Ctrl-Z, and centralize suspend-aware redraws through prof_doupdate() to prevent terminal corruption when SIGTSTP is received while editor is active. Removes SIGUSR1 editor escape in favor of standard pkill <editor> recovery.	2026-06-01 12:21:34 +00:00
Jabber Developer	72f4f186da	merge: sync upstream profanity-im/profanity ... Sync with upstream profanity-im/profanity. Major upstream changes incorporated: Memory management - Replace malloc+memset with g_new0 throughout codebase - Adopt auto_gchar / auto_gcharv / auto_gerror / auto_jid cleanup macros - Replace free() with g_free() for GAlloc'd memory Editor rewrite - Remove pthread-based async editor; use GChildWatch callback API - New launch_editor(initial_content, callback, user_data) interface - Proper signal handling (SIGINT, SIGTSTP, SIGPIPE reset in child) - ui_suspend()/ui_resume() integration for TTY management OMEMO improvements - Dual backend support: libsignal-protocol-c and libomemo-c - Proper pre-key removal after use (XEP-0384 compliance) - Automatic pre-key regeneration when store drops below threshold - New functions: omemo_is_device_active(), omemo_is_jid_trusted() - omemo_get_jid_untrusted_fingerprints() for better error messages - Fingerprint notifications on new device identity discovery - Deterministic pre-key ID generation tracking max_pre_key_id - omemo_trust_changed() UI updates on trust state changes JID validation - RFC 6122-compliant validation in jid_is_valid() - Character-level checks (RFC 6122 forbidden chars: & ' / : < > @) - Length limits: 1023 per component, 3071 total - New jid_is_valid_user_jid() for user vs. service JID distinction Database - Schema migration v3: UNIQUE constraint on archive_id for deduplication - Triggers for corrected message tracking (replaces_db_id / replaced_by_db_id) - db_history_result_t return type, _truncate_datetime_suffix() UI / console - win_warn_needed() / win_warn_sent() warning deduplication hash table - PAD_MIN_HEIGHT dynamic pad sizing with PAD_THRESHOLD auto-cleanup - Spellcheck integration in input field with Unicode word detection - cons_spellcheck_setting() for /settings ui output - /[command]? shortcut for command help Account config - Account name sanitization for GKeyFile special chars ([ ] = # \n \r) - Replace popen() with g_spawn_sync() for eval_password - TLS policy: add "direct" option alongside legacy Connection - Port validation with g_assert (0–65535) - SHA-256 certificate fingerprint support (XMPP_CERT_PUBKEY_FINGERPRINT_SHA256) - "direct" TLS policy alias for legacy SSL Common utilities - str_xml_sanitize() for XML 1.0 illegal character removal - string_matches_one_of() with formatted error messages - valid_tls_policy_option() helper - prof_date_time_format_iso8601() utility - Improved strip_arg_quotes() with backslash unescaping - prof_occurrences() uses g_slist_prepend + reverse for performance PGP / OX - Proper GPGME resource cleanup with goto-cleanup pattern - g_string_free(xmppuri) leak fix in _ox_key_lookup CSV export - Use GString + g_file_set_contents instead of raw write() syscalls Tests - Restructured into subdirectories: command/, config/, xmpp/, ui/, omemo/, otr/, pgp/ - New test_cmd_ac.c for autocompleter unit tests - Updated stubs for new UI suspend/resume functions License headers - Migrate to SPDX-3.0 identifiers (GPL-3.0-or-later WITH OpenSSL-exception) ──────────────────────────────────────────────────── cproof-specific preservations: - XEP-0308 LMC: replace_id ?: id logic in message/stanza/omemo - Force encryption: cmd_force_encryption, test_forced_encryption - CWE-134: format string protection (cons_show("%s", ...)) - y_start_pos-based paging in window.c - db_history_result_t return type, _truncate_datetime_suffix() Merge-time fixes: - common.c: format-security (-Werror) — cons_show(errmsg) → cons_show("%s", errmsg) - database.c: null-deref guard — !msg->timestamp → msg && !msg->timestamp - console.c: implicit size_t → int cast — (int)(maxlen + 1) - tlscerts.c: %d for size_t — %zu Build system: - Kept autotools (Makefile.am, configure.ac); upstream uses Meson - Restored deleted files: bootstrap.sh, autogen.sh, ax_valgrind_check.m4, configure-debug - Updated Makefile.am test paths for subdirectory structure - Added test_cmd_ac, test_forced_encryption to test sources Functional tests: - Use cproof version; upstream requires stbbr_for_xmlns from updated stabber - Not yet available in devs/stabber fork Closes #64 Merge author: jabber.developer2 Commits authors: Michael Vetter <jubalh@iodoru.org> & Steffen Jaeckel <s@jaeckel.eu>	2026-05-26 17:48:14 +00:00

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Expand all files Collapse all files

Diff Content Not Available