build: untrack generated src/gitversion.h.in

The file is gitignored and regenerated by the build recipe from
.git/HEAD/.git/index; it was committed by mistake during the upstream
sync. Untrack it so builds no longer dirty the working tree. The
version string behaviour is unchanged.

src/gitversion.h.in

@@ -1,6 +0,0 @@
-#ifndef PROF_GIT_BRANCH
-#define PROF_GIT_BRANCH @PROF_GIT_BRANCH@
-#endif
-#ifndef PROF_GIT_REVISION
-#define PROF_GIT_REVISION @PROF_GIT_REVISION@
-#endif

src/xmpp/message.c

@@ -1132,17 +1132,12 @@ _handle_groupchat(xmpp_stanza_t* const stanza)
         message->timestamp = NULL;
     }
 
-    // XEP-0203 §4: trust <delay> only from the room or our server, not a client-forged stamp
-    message->timestamp = stanza_get_oldest_delay_from(stanza, from_jid->barejid);
-    if (!message->timestamp && from_jid->domainpart) {
-        message->timestamp = stanza_get_oldest_delay_from(stanza, from_jid->domainpart);
-    }
-    if (!message->timestamp) {
-        const char* my_domain = connection_get_domain();
-        if (my_domain) {
-            message->timestamp = stanza_get_oldest_delay_from(stanza, my_domain);
-        }
-    }
+    // we want to display the oldest delay
+    message->timestamp = stanza_get_oldest_delay(stanza);
+
+    // now this has nothing to do with MUC history
+    // it's just setting the time to the received time so upon displaying we can use this time
+    // for example in win_println_incoming_muc_msg()
     if (!message->timestamp) {
         message->timestamp = g_date_time_new_now_local();
     }
@@ -1273,15 +1268,7 @@ _handle_muc_private_message(xmpp_stanza_t* const stanza)
     _receive_omemo(stanza, message);
 #endif
 
-    // XEP-0203 §4: trust <delay> only from a server domain, not a client-forged stamp
-    const char* my_domain = connection_get_domain();
-    message->timestamp = stanza_get_delay_from(stanza, my_domain);
-    if (!message->timestamp && message->from_jid->domainpart) {
-        message->timestamp = stanza_get_delay_from(stanza, message->from_jid->domainpart);
-    }
-    if (!message->timestamp) {
-        message->timestamp = g_date_time_new_now_local();
-    }
+    message->timestamp = stanza_get_delay(stanza);
     message->body = xmpp_message_get_body(stanza);
 
     if (!message->plain && !message->body) {
@@ -1432,12 +1419,8 @@ _handle_chat(xmpp_stanza_t* const stanza, gboolean is_mam, gboolean is_carbon, c
         // timestamp provided outside like in a <forwarded> by MAM
         message->timestamp = timestamp;
     } else {
-        // XEP-0203 §4: trust <delay> only from a server domain, not a client-forged stamp
-        const char* my_domain = connection_get_domain();
-        message->timestamp = stanza_get_delay_from(stanza, my_domain);
-        if (!message->timestamp && jid->domainpart) {
-            message->timestamp = stanza_get_delay_from(stanza, jid->domainpart);
-        }
+        // timestamp in the message stanza or use time of receival (now)
+        message->timestamp = stanza_get_delay(stanza);
         if (!message->timestamp) {
             message->timestamp = g_date_time_new_now_local();
         }

src/xmpp/stanza.c

@@ -1163,7 +1163,7 @@ _stanza_get_delay_timestamp_xep0091(xmpp_stanza_t* const x_stanza)
 }
 
 GDateTime*
-stanza_get_delay_from(xmpp_stanza_t* const stanza, const char* const from)
+stanza_get_delay_from(xmpp_stanza_t* const stanza, gchar* from)
 {
     xmpp_stanza_t* delay = NULL;
 
@@ -1195,12 +1195,6 @@ stanza_get_delay_from(xmpp_stanza_t* const stanza, const char* const from)
 
 GDateTime*
 stanza_get_oldest_delay(xmpp_stanza_t* const stanza)
-{
-    return stanza_get_oldest_delay_from(stanza, NULL);
-}
-
-GDateTime*
-stanza_get_oldest_delay_from(xmpp_stanza_t* const stanza, const char* const from)
 {
     xmpp_stanza_t* child;
     const char* child_name;
@@ -1211,37 +1205,27 @@ stanza_get_oldest_delay_from(xmpp_stanza_t* const stanza, const char* const from
         child_name = xmpp_stanza_get_name(child);
 
         if (child_name && g_strcmp0(child_name, STANZA_NAME_DELAY) == 0) {
-            if (from) {
-                const char* child_from = xmpp_stanza_get_attribute(child, STANZA_ATTR_FROM);
-                if (!child_from || g_strcmp0(child_from, from) != 0)
-                    continue;
-            }
             GDateTime* tmp = _stanza_get_delay_timestamp_xep0203(child);
 
             if (oldest == NULL) {
                 oldest = tmp;
-            } else if (tmp && g_date_time_compare(oldest, tmp) == 1) {
+            } else if (g_date_time_compare(oldest, tmp) == 1) {
                 g_date_time_unref(oldest);
                 oldest = tmp;
-            } else if (tmp) {
+            } else {
                 g_date_time_unref(tmp);
             }
         }
 
         if (child_name && g_strcmp0(child_name, STANZA_NAME_X) == 0) {
-            if (from) {
-                const char* child_from = xmpp_stanza_get_attribute(child, STANZA_ATTR_FROM);
-                if (!child_from || g_strcmp0(child_from, from) != 0)
-                    continue;
-            }
             GDateTime* tmp = _stanza_get_delay_timestamp_xep0091(child);
 
             if (oldest == NULL) {
                 oldest = tmp;
-            } else if (tmp && g_date_time_compare(oldest, tmp) == 1) {
+            } else if (g_date_time_compare(oldest, tmp) == 1) {
                 g_date_time_unref(oldest);
                 oldest = tmp;
-            } else if (tmp) {
+            } else {
                 g_date_time_unref(tmp);
             }
         }

src/xmpp/stanza.h

@@ -305,9 +305,8 @@ xmpp_stanza_t* stanza_create_mediated_invite(xmpp_ctx_t* ctx, const char* const
 gboolean stanza_contains_chat_state(xmpp_stanza_t* stanza);
 
 GDateTime* stanza_get_delay(xmpp_stanza_t* const stanza);
-GDateTime* stanza_get_delay_from(xmpp_stanza_t* const stanza, const char* const from);
+GDateTime* stanza_get_delay_from(xmpp_stanza_t* const stanza, gchar* from);
 GDateTime* stanza_get_oldest_delay(xmpp_stanza_t* const stanza);
-GDateTime* stanza_get_oldest_delay_from(xmpp_stanza_t* const stanza, const char* const from);
 
 gboolean stanza_is_muc_presence(xmpp_stanza_t* const stanza);
 gboolean stanza_is_muc_self_presence(xmpp_stanza_t* const stanza,