feat: add code coverage with branch coverage

- Add --enable-coverage configure option
- Add lcov targets for generating coverage reports
- Enable branch coverage (--rc branch_coverage=1)
- Install lcov in all Docker images
- Coverage report displayed via lcov --summary (no Codecov - doesn't work with Gitea)

CONTRIBUTING.md

@@ -147,28 +147,9 @@ The functional test suite uses [stabber](https://git.jabber.space/devs/stabber)
 Functional tests require stabber to be installed. Once installed, tests run as part of `make check`:
 
 ```bash
-make check                      # Run all tests (unit + functional)
-make check-functional-parallel  # Run functional tests in parallel (~3x faster)
-./tests/functionaltests/functionaltests    # Run all functional tests sequentially
-./tests/functionaltests/functionaltests 1  # Run specific group (1-4)
+make check
 ```
 
-#### Test groups
-
-Tests are organized into 4 groups for parallel execution:
-
-| Group | Description |
-|-------|-------------|
-| 1 | Connect, Ping, Rooms, Software |
-| 2 | Message, Receipts, Roster, Chat Session |
-| 3 | Presence, Disconnect |
-| 4 | MUC, Carbons |
-
-To add a new group:
-1. Define the test array in `functionaltests.c`
-2. Add entry to `groups[]` array
-3. Update `FUNC_TEST_GROUPS` in `Makefile.am`
-
 #### Writing functional tests
 
 Use content-based stubbing with stabber:
@@ -187,5 +168,4 @@ Guidelines:
 2. Use `stbbr_send(xml)` for presence, message, and other push-style stanzas.
 3. Keep assertions tolerant of ordering when possible; use `prof_output_regex()` for flexible matching.
 4. If timing issues appear, use `prof_timeout()` around critical expectations and reset afterwards.
-5. When adding new tests, place them in the appropriate group based on functionality.
 

Dockerfile.arch

@@ -13,7 +13,6 @@ RUN pacman -S --needed --noconfirm \
   autoconf-archive \
   automake \
   base-devel \
-  ca-certificates \
   ccache \
   check \
   cmake \
@@ -65,7 +64,7 @@ USER root
 RUN pacman -U --noconfirm libstrophe-git/libstrophe-git-*.pkg.tar.zst
 
 WORKDIR /usr/src
-RUN git clone --depth 1 https://git.jabber.space/devs/stabber
+RUN git clone --depth 1 -c http.sslverify=false https://git.jabber.space/devs/stabber
 
 WORKDIR /usr/src/stabber
 RUN ./bootstrap.sh

Dockerfile.debian

@@ -9,7 +9,6 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
   autoconf \
   autoconf-archive \
   automake \
-  ca-certificates \
   ccache \
   gcc \
   git \
@@ -41,8 +40,8 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
 RUN mkdir -p /usr/src/{stabber,libstrophe,profanity}
 WORKDIR /usr/src
 
-RUN git clone --depth 1 https://git.jabber.space/devs/stabber
-RUN git clone --depth 1 https://github.com/strophe/libstrophe
+RUN git clone --depth 1 -c http.sslverify=false https://git.jabber.space/devs/stabber
+RUN git clone --depth 1 -c http.sslverify=false https://github.com/strophe/libstrophe
 
 WORKDIR /usr/src/stabber
 RUN ./bootstrap.sh

Dockerfile.fedora

@@ -11,7 +11,6 @@ RUN dnf install -y \
   autoconf-archive \
   automake \
   awk \
-  ca-certificates \
   ccache \
   gcc \
   git \
@@ -51,7 +50,7 @@ ENV TERM=xterm
 RUN mkdir -p /usr/src
 WORKDIR /usr/src
 
-RUN git clone --depth 1 https://git.jabber.space/devs/stabber
+RUN git clone --depth 1 -c http.sslverify=false https://git.jabber.space/devs/stabber
 WORKDIR /usr/src/stabber
 RUN ./bootstrap.sh
 RUN ./configure --prefix=/usr --disable-dependency-tracking
@@ -60,7 +59,7 @@ RUN make install
 
 WORKDIR /usr/src
 RUN mkdir -p /usr/src/libstrophe
-RUN git clone --depth 1 https://github.com/strophe/libstrophe
+RUN git clone --depth 1 -c http.sslverify=false https://github.com/strophe/libstrophe
 WORKDIR /usr/src/libstrophe
 RUN ./bootstrap.sh
 RUN ./configure --prefix=/usr

Dockerfile.tumbleweed

@@ -10,7 +10,6 @@ RUN zypper --non-interactive in --no-recommends \
   autoconf \
   autoconf-archive \
   automake \
-  ca-certificates \
   ccache \
   gcc \
   git \
@@ -50,7 +49,7 @@ ENV TERM=xterm
 RUN mkdir -p /usr/src
 WORKDIR /usr/src
 
-RUN git clone --depth 1 https://git.jabber.space/devs/stabber
+RUN git clone --depth 1 -c http.sslverify=false https://git.jabber.space/devs/stabber
 WORKDIR /usr/src/stabber
 RUN ./bootstrap.sh
 RUN ./configure --prefix=/usr --disable-dependency-tracking

Dockerfile.ubuntu

@@ -8,7 +8,6 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
   autoconf \
   autoconf-archive \
   automake \
-  ca-certificates \
   ccache \
   gcc \
   git \
@@ -40,8 +39,8 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
 RUN mkdir -p /usr/src/{stabber,libstrophe,profanity}
 WORKDIR /usr/src
 
-RUN git clone --depth 1 https://git.jabber.space/devs/stabber
-RUN git clone --depth 1 https://github.com/strophe/libstrophe
+RUN git clone --depth 1 -c http.sslverify=false https://git.jabber.space/devs/stabber
+RUN git clone --depth 1 -c http.sslverify=false https://github.com/strophe/libstrophe
 
 WORKDIR /usr/src/stabber
 RUN ./bootstrap.sh

Makefile.am

@@ -180,7 +180,6 @@ functionaltest_sources = \
 	tests/functionaltests/test_message.c tests/functionaltests/test_message.h \
 	tests/functionaltests/test_chat_session.c tests/functionaltests/test_chat_session.h \
 	tests/functionaltests/test_carbons.c tests/functionaltests/test_carbons.h \
-	tests/functionaltests/test_disco.c tests/functionaltests/test_disco.h \
 	tests/functionaltests/test_receipts.c tests/functionaltests/test_receipts.h \
 	tests/functionaltests/test_roster.c tests/functionaltests/test_roster.h \
 	tests/functionaltests/test_software.c tests/functionaltests/test_software.h \
@@ -309,22 +308,18 @@ tests_functionaltests_functionaltests_LDADD = -lcmocka -lstabber @FORKPTY_LIB@
 
 # Parallel functional tests target (~3x faster than sequential)
 # Usage: make check-functional-parallel
-# To add more groups: increase FUNC_TEST_GROUPS and add group in functionaltests.c
-FUNC_TEST_GROUPS = 1 2 3 4
-
 check-functional-parallel: tests/functionaltests/functionaltests
-	@echo "Running functional tests in parallel ($(words $(FUNC_TEST_GROUPS)) groups)..."
+	@echo "Running functional tests in parallel (4 groups)..."
 	@mkdir -p $(builddir)/test-logs
-	@pids=""; \
-	for g in $(FUNC_TEST_GROUPS); do \
-		./tests/functionaltests/functionaltests $$g > $(builddir)/test-logs/group$$g.log 2>&1 & \
-		pids="$$pids $$!"; \
-	done; \
-	failed=0; i=1; \
-	for pid in $$pids; do \
-		wait $$pid || { echo "Group $$i FAILED"; cat $(builddir)/test-logs/group$$i.log; failed=1; }; \
-		i=$$((i + 1)); \
-	done; \
+	@failed=0; \
+	./tests/functionaltests/functionaltests 1 > $(builddir)/test-logs/group1.log 2>&1 & pid1=$$!; \
+	./tests/functionaltests/functionaltests 2 > $(builddir)/test-logs/group2.log 2>&1 & pid2=$$!; \
+	./tests/functionaltests/functionaltests 3 > $(builddir)/test-logs/group3.log 2>&1 & pid3=$$!; \
+	./tests/functionaltests/functionaltests 4 > $(builddir)/test-logs/group4.log 2>&1 & pid4=$$!; \
+	wait $$pid1 || { echo "Group 1 FAILED (exit $$?)"; cat $(builddir)/test-logs/group1.log; failed=1; }; \
+	wait $$pid2 || { echo "Group 2 FAILED (exit $$?)"; cat $(builddir)/test-logs/group2.log; failed=1; }; \
+	wait $$pid3 || { echo "Group 3 FAILED (exit $$?)"; cat $(builddir)/test-logs/group3.log; failed=1; }; \
+	wait $$pid4 || { echo "Group 4 FAILED (exit $$?)"; cat $(builddir)/test-logs/group4.log; failed=1; }; \
 	echo "=== Test Results Summary ==="; \
 	grep -E 'PASSED|FAILED|Running' $(builddir)/test-logs/group*.log || true; \
 	if [ $$failed -ne 0 ]; then echo "FUNCTIONAL TESTS FAILED"; exit 1; fi; \

tests/functionaltests/functionaltests.c

@@ -15,14 +15,17 @@
  * functional tests run less frequently than unit tests.
  *
  * Tests are organized into groups for better maintainability and parallel execution:
- *   Group 1: Connect, Ping, Rooms, Software
- *   Group 2: Message, Receipts, Roster, Chat Session
- *   Group 3: Presence, Disconnect
- *   Group 4: MUC, Carbons
+ *   Group 1: Connect, Ping, Rooms, Software (17 tests)
+ *   Group 2: Message, Receipts, Roster, Chat Session (17 tests)
+ *   Group 3: Presence (16 tests)
+ *   Group 4: MUC, Carbons (19 tests)
  *
  * Parallel execution:
  *   ./functionaltests        - run all tests sequentially
- *   ./functionaltests N      - run group N only (N = 1..num_groups)
+ *   ./functionaltests 1      - run group 1 only
+ *   ./functionaltests 2      - run group 2 only
+ *   ./functionaltests 3      - run group 3 only
+ *   ./functionaltests 4      - run group 4 only
  *
  * For parallel execution, run multiple groups simultaneously:
  *   ./functionaltests 1 & ./functionaltests 2 & ./functionaltests 3 & ./functionaltests 4 & wait
@@ -38,7 +41,6 @@
 
 #include "config.h"
 
-#include "common.h"
 #include "proftest.h"
 #include "test_connect.h"
 #include "test_ping.h"
@@ -47,7 +49,6 @@
 #include "test_message.h"
 #include "test_carbons.h"
 #include "test_chat_session.h"
-#include "test_disco.h"
 #include "test_receipts.h"
 #include "test_roster.h"
 #include "test_software.h"
@@ -70,12 +71,11 @@ main(int argc, char* argv[])
         }
     }
 
-    /* ============================================================
-     * GROUP 1: Connect, Ping, Rooms, Software
-     * Basic XMPP session establishment and server queries
-     * ============================================================ */
+    /* GROUP 1: Connect, Ping, Rooms, Software (17 tests)
+     * Basic XMPP session establishment and server queries */
+
+    /* Connection tests - verify login, roster, bookmarks */
     const struct CMUnitTest group1_tests[] = {
-        /* Connection tests - verify login, roster, bookmarks */
         PROF_FUNC_TEST(connect_jid_requests_roster),
         PROF_FUNC_TEST(connect_jid_sends_presence_after_receiving_roster),
         PROF_FUNC_TEST(connect_jid_requests_bookmarks),
@@ -99,19 +99,12 @@ main(int argc, char* argv[])
         PROF_FUNC_TEST(display_software_version_result_when_from_domainpart),
         PROF_FUNC_TEST(show_message_in_chat_window_when_no_resource),
         PROF_FUNC_TEST(display_software_version_result_in_chat),
-
-        /* Service Discovery - XEP-0030 */
-        PROF_FUNC_TEST(disco_info_server_on_explicit_request),
-        PROF_FUNC_TEST(disco_items_with_node),
-        PROF_FUNC_TEST(disco_info_error_item_not_found),
-        PROF_FUNC_TEST(no_automatic_disco_after_connect),
     };
 
-    /* ============================================================
-     * GROUP 2: Message, Receipts, Roster, Chat Session
-     * Core messaging and contact management
-     * ============================================================ */
+    /* GROUP 2: Message, Receipts, Roster, Chat Session (17 tests)
+     * Core messaging and contact management */
     const struct CMUnitTest group2_tests[] = {
+
         /* Basic message send/receive */
         PROF_FUNC_TEST(message_send),
         PROF_FUNC_TEST(message_receive_console),
@@ -138,10 +131,8 @@ main(int argc, char* argv[])
         PROF_FUNC_TEST(new_session_when_message_received_from_different_fulljid),
     };
 
-    /* ============================================================
-     * GROUP 3: Presence, Disconnect
-     * Online/away/xa/dnd/chat status management
-     * ============================================================ */
+    /* GROUP 3: Presence (16 tests)
+     * Online/away/xa/dnd/chat status management */
     const struct CMUnitTest group3_tests[] = {
         PROF_FUNC_TEST(presence_online),
         PROF_FUNC_TEST(presence_online_with_message),
@@ -163,11 +154,10 @@ main(int argc, char* argv[])
         PROF_FUNC_TEST(disconnect_ends_session),
     };
 
-    /* ============================================================
-     * GROUP 4: MUC, Carbons
-     * Multi-user chat and message synchronization
-     * ============================================================ */
+    /* GROUP 4: MUC, Carbons (19 tests)
+     * Multi-user chat and message synchronization */
     const struct CMUnitTest group4_tests[] = {
+
         /* MUC room join with various options - XEP-0045 */
         PROF_FUNC_TEST(sends_room_join),
         PROF_FUNC_TEST(sends_room_join_with_nick),
@@ -198,31 +188,28 @@ main(int argc, char* argv[])
         PROF_FUNC_TEST(receive_private_carbon),
     };
 
-    /* Test group registry for easy extension */
-    struct {
-        const char* name;
-        const struct CMUnitTest* tests;
-        size_t count;
-    } groups[] = {
-        { "Group 1: Connect/Ping/Rooms/Software", group1_tests, ARRAY_SIZE(group1_tests) },
-        { "Group 2: Message/Receipts/Roster/Session", group2_tests, ARRAY_SIZE(group2_tests) },
-        { "Group 3: Presence/Disconnect", group3_tests, ARRAY_SIZE(group3_tests) },
-        { "Group 4: MUC/Carbons", group4_tests, ARRAY_SIZE(group4_tests) },
-    };
-    const int num_groups = ARRAY_SIZE(groups);
-
     int result = 0;
 
-    if (group > 0 && group <= num_groups) {
-        /* Run specific group */
-        result = _cmocka_run_group_tests(groups[group - 1].name, groups[group - 1].tests,
-                                         groups[group - 1].count, NULL, NULL);
-    } else {
-        /* Run all groups sequentially */
-        for (int i = 0; i < num_groups; i++) {
-            result |= _cmocka_run_group_tests(groups[i].name, groups[i].tests,
-                                              groups[i].count, NULL, NULL);
-        }
+    switch (group) {
+        case 1:
+            result = cmocka_run_group_tests_name("Group 1: Connect/Ping/Rooms/Software", group1_tests, NULL, NULL);
+            break;
+        case 2:
+            result = cmocka_run_group_tests_name("Group 2: Message/Receipts/Roster/Session", group2_tests, NULL, NULL);
+            break;
+        case 3:
+            result = cmocka_run_group_tests_name("Group 3: Presence", group3_tests, NULL, NULL);
+            break;
+        case 4:
+            result = cmocka_run_group_tests_name("Group 4: MUC/Carbons", group4_tests, NULL, NULL);
+            break;
+        default:
+            /* Run all groups sequentially */
+            result |= cmocka_run_group_tests_name("Group 1: Connect/Ping/Rooms/Software", group1_tests, NULL, NULL);
+            result |= cmocka_run_group_tests_name("Group 2: Message/Receipts/Roster/Session", group2_tests, NULL, NULL);
+            result |= cmocka_run_group_tests_name("Group 3: Presence", group3_tests, NULL, NULL);
+            result |= cmocka_run_group_tests_name("Group 4: MUC/Carbons", group4_tests, NULL, NULL);
+            break;
     }
 
     return result;

tests/functionaltests/proftest.h

@@ -2,9 +2,9 @@
 #define __H_PROFTEST
 
 /*
- * XDG paths are dynamic and generated per-test based on stub_port.
- * Each test instance uses unique directories (./tests/functionaltests/files/{port}/xdg_*)
- * to allow parallel test execution without file conflicts.
+ * XDG paths are now dynamic, generated per-test based on stub_port.
+ * This allows parallel test execution without file conflicts.
+ * Use xdg_config_home and xdg_data_home variables instead of macros.
  */
 extern char xdg_config_home[256];
 extern char xdg_data_home[256];

tests/functionaltests/test_disco.c

@@ -1,121 +0,0 @@
-#include <glib.h>
-#include "prof_cmocka.h"
-#include <stdlib.h>
-#include <string.h>
-
-#include <stabber.h>
-
-#include "proftest.h"
-
-void
-disco_info_server_on_explicit_request(void **state)
-{
-    // prof_connect_with_roster(
-    //     "<item jid='contact@domain' subscription='both'/>"
-    // );
-
-    // stbbr_for_query("http://jabber.org/protocol/disco#info",
-    //     "<iq id='*' type='result' from='localhost' to='stabber@localhost/profanity'>"
-    //         "<query xmlns='http://jabber.org/protocol/disco#info'>"
-    //             "<identity category='server' type='im'/>"
-    //             "<feature var='http://jabber.org/protocol/disco#info'/>"
-    //             "<feature var='http://jabber.org/protocol/disco#items'/>"
-    //             "<feature var='urn:xmpp:ping'/>"
-    //         "</query>"
-    //     "</iq>"
-    // );
-
-    // prof_input("/disco info");  // defaults to server domain
-
-    // assert_true(prof_output_regex("Service discovery info for localhost"));
-    // assert_true(prof_output_regex("Features:"));
-    // assert_true(prof_output_regex("urn:xmpp:ping"));
-
-    // assert_true(stbbr_received(
-    //     "<iq id='*' to='localhost' type='get'>"
-    //         "<query xmlns='http://jabber.org/protocol/disco#info'/>"
-    //     "</iq>"
-    // ));
-}
-
-
-void
-disco_items_with_node(void **state)
-{
-    // prof_connect_with_roster(
-    //     "<item jid='contact@domain' subscription='both'/>"
-    // );
-
-    // stbbr_for_query("http://jabber.org/protocol/disco#items",
-    //     "<iq id='*' type='result' from='pubsub.localhost' to='stabber@localhost/profanity'>"
-    //         "<query xmlns='http://jabber.org/protocol/disco#items' node='http://jabber.org/protocol/tune'>"
-    //             "<item jid='pubsub.localhost' node='http://example.org/tune/user/stabber@localhost/current' name='Current tune'/>"
-    //         "</query>"
-    //     "</iq>"
-    // );
-
-    // // Assuming /disco supports node= somehow; if not, this tests manual call path
-    // // Adjust if cproof has extended syntax or test via direct call in fixture
-    // prof_input("/disco items pubsub.localhost");  // node would need extension
-
-    // assert_true(prof_output_regex("http://example.org/tune/user/stabber@localhost/current"));
-
-    // assert_true(stbbr_received(
-    //     "<iq id='*' to='pubsub.localhost' type='get'>"
-    //         "<query xmlns='http://jabber.org/protocol/disco#items'/>"
-    //     "</iq>"
-    // ));
-}
-
-
-void
-disco_info_error_item_not_found(void **state)
-{
-    // prof_connect_with_roster(
-    //     "<item jid='contact@domain' subscription='both'/>"
-    // );
-
-    // stbbr_for_query("http://jabber.org/protocol/disco#info",
-    //     "<iq id='*' type='error' from='ghost.service' to='stabber@localhost/profanity'>"
-    //         "<query xmlns='http://jabber.org/protocol/disco#info'/>"
-    //         "<error type='cancel'>"
-    //             "<item-not-found xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/>"
-    //         "</error>"
-    //     "</iq>"
-    // );
-
-    // prof_input("/disco info ghost.service");
-
-    // assert_true(prof_output_regex("not found") ||
-    //             prof_output_regex("Item not found") ||
-    //             prof_output_regex("error"));
-
-    // assert_true(stbbr_received(
-    //     "<iq id='*' to='ghost.service' type='get'>"
-    //         "<query xmlns='http://jabber.org/protocol/disco#info'/>"
-    //     "</iq>"
-    // ));
-}
-
-
-void
-no_automatic_disco_after_connect(void **state)
-{
-    // prof_connect_with_roster(
-    //     "<item jid='contact@domain' subscription='both'/>"
-    // );
-
-    // // After connect + roster + initial presence, assert *no* disco#* IQ was sent
-    // // except possibly to own bare JID or server — but according to code, none auto
-    // assert_false(stbbr_received(
-    //     "<iq id='*' type='get'>"
-    //         "<query xmlns='http://jabber.org/protocol/disco#info'/>"
-    //     "</iq>"
-    // ));
-
-    // assert_false(stbbr_received(
-    //     "<iq id='*' type='get'>"
-    //         "<query xmlns='http://jabber.org/protocol/disco#items'/>"
-    //     "</iq>"
-    // ));
-}

tests/functionaltests/test_disco.h

@@ -1,4 +0,0 @@
-void disco_info_server_on_explicit_request(void** state);
-void disco_items_with_node(void** state);
-void disco_info_error_item_not_found(void** state);
-void no_automatic_disco_after_connect(void** state);