devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

Crash in /caps Command with Malformed JID Input #20

New Issue
Closed
opened 2025-09-01 19:28:10 +00:00 by jabber.developer · 0 comments
jabber.developer commented 2025-09-01 19:28:10 +00:00
Owner
Copy Link

Problem:
The /caps command crashes when provided with malformed JID inputs like @example.com in WIN_CHAT or WIN_CONSOLE modes. The issue occurs because jid_create may return a NULL pointer for invalid inputs, but cmd_caps only checks jid->fulljid for null, leading to a potential null pointer dereference.

Proposed solution:
Add null checks for the jid pointer in cmd_caps and ensure consistent handling in the WIN_MUC case. Include unit tests to verify robust handling of malformed inputs.

**Problem:** The `/caps` command crashes when provided with malformed JID inputs like `@example.com` in `WIN_CHAT` or `WIN_CONSOLE` modes. The issue occurs because `jid_create` may return a `NULL` pointer for invalid inputs, but `cmd_caps` only checks `jid->fulljid` for null, leading to a potential null pointer dereference. **Proposed solution:** Add null checks for the `jid` pointer in `cmd_caps` and ensure consistent handling in the `WIN_MUC` case. Include unit tests to verify robust handling of malformed inputs.
admin closed this issue 2025-09-01 19:48:27 +00:00
jabber.developer self-assigned this 2025-09-01 22:23:52 +00:00
jabber.developer added the
Kind/Bug
 label 2025-09-01 22:24:55 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Kind/Bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin jabber.developer jabber.developer2
No Assignees jabber.developer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: devs/cproof#20
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?