devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

Prevent crash in /caps with malformed JID input #21

Manually merged
jabber.developer merged 1 commits from fix/caps-crash into master 2025-09-01 19:48:28 +00:00
Conversation 0 Commits 1 Files Changed 1 +1 -1
jabber.developer commented 2025-09-01 19:29:13 +00:00
Owner
Copy Link
  • I ran valgrind when using my new feature

How to test the functionality

  • Try /caps @example.com

Fixes #20

<!-- For completed items, change [ ] to [x]. --> - [x] I ran valgrind when using my new feature ### How to test the functionality - Try `/caps @example.com` Fixes #20
jabber.developer added 1 commit 2025-09-01 19:29:13 +00:00
fix(cmd_caps): Prevent crash in /caps with malformed JID input
All checks were successful
CI / Check spelling (pull_request) Successful in 15s
Details
CI / Check coding style (pull_request) Successful in 29s
Details
CI / Linux (debian) (pull_request) Successful in 9m54s
Details
CI / Linux (ubuntu) (pull_request) Successful in 10m15s
Details
CI / Linux (arch) (pull_request) Successful in 11m51s
Details
CI / Check spelling (push) Successful in 18s
Details
CI / Check coding style (push) Successful in 31s
Details
CI / Linux (debian) (push) Successful in 10m35s
Details
CI / Linux (ubuntu) (push) Successful in 11m0s
Details
CI / Linux (arch) (push) Successful in 13m26s
Details
51d2355d97 
- Added null check for `jid` in `cmd_caps` to handle `jid_create` returning NULL.
- Crash occurred when processing malformed inputs like `@example.com` in `/caps`.
- Ensures robust handling of invalid JID strings in `WIN_CHAT` and `WIN_CONSOLE` cases.

Fixes #20
jabber.developer changed title from fix(cmd_caps): Prevent crash in /caps with malformed JID input to Prevent crash in /caps with malformed JID input 2025-09-01 19:29:54 +00:00
jabber.developer manually merged commit 51d2355d97 into master 2025-09-01 19:48:28 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin jabber.developer jabber.developer2
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: devs/cproof#21
No description provided.
Delete Branch "fix/caps-crash"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?