devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

Incorrect Autocompletion in /correct Command #24

New Issue
Closed
opened 2025-09-01 22:16:14 +00:00 by jabber.developer · 0 comments
jabber.developer commented 2025-09-01 22:16:14 +00:00
Owner
Copy Link

Description

The /correct command's autocompletion feature incorrectly suggests the original message content (e.g., Hello) instead of the corrected message content (e.g., Hi) when using Last Message Correction (LMC). This occurs because chatwin_outgoing_msg only calls _chatwin_set_last_message for original messages (when replace_id is NULL), preventing the message content from being updated for autocompletion.

Steps to Reproduce

  1. Send a message Hello.
  2. Use /correct Hi to replace it with a new message.
  3. Type /correct and press <tab> for autocompletion.
  4. Observe that autocompletion suggests /correct Hello (original message) instead of /correct Hi (corrected message).

Expected Behavior

Autocompletion for /correct should suggest the corrected message content (e.g., /correct Hi).

Root Cause

In chatwin_outgoing_msg, _chatwin_set_last_message is only called when replace_id is NULL (original messages). This prevents the corrected message content from being stored for autocompletion, causing /correct to suggest the original message content.

Proposed Fix

Modify chatwin_outgoing_msg to call _chatwin_set_last_message for both original and corrected messages, using replace_id (if present) or id to preserve the original message ID (as per XEP-0308), while updating the message content for autocompletion.

Add unit tests to verify:

  • Autocompletion suggests the corrected message content.
  • The original message ID is preserved for LMC corrections.

Related Issues

https://github.com/profanity-im/profanity/issues/1899#issuecomment-1769942338

## Description The `/correct` command's autocompletion feature incorrectly suggests the original message content (e.g., `Hello`) instead of the corrected message content (e.g., `Hi`) when using Last Message Correction (LMC). This occurs because `chatwin_outgoing_msg` only calls `_chatwin_set_last_message` for original messages (when `replace_id` is `NULL`), preventing the message content from being updated for autocompletion. ## Steps to Reproduce 1. Send a message `Hello`. 2. Use `/correct Hi` to replace it with a new message. 3. Type `/correct` and press `<tab>` for autocompletion. 4. Observe that autocompletion suggests `/correct Hello` (original message) instead of `/correct Hi` (corrected message). ## Expected Behavior Autocompletion for `/correct` should suggest the corrected message content (e.g., `/correct Hi`). ## Root Cause In `chatwin_outgoing_msg`, `_chatwin_set_last_message` is only called when `replace_id` is `NULL` (original messages). This prevents the corrected message content from being stored for autocompletion, causing `/correct` to suggest the original message content. ## Proposed Fix Modify `chatwin_outgoing_msg` to call `_chatwin_set_last_message` for both original and corrected messages, using `replace_id` (if present) or `id` to preserve the original message ID (as per [XEP-0308](https://xmpp.org/extensions/xep-0308.html)), while updating the message content for autocompletion. Add unit tests to verify: - Autocompletion suggests the corrected message content. - The original message ID is preserved for LMC corrections. ## Related Issues https://github.com/profanity-im/profanity/issues/1899#issuecomment-1769942338
jabber.developer self-assigned this 2025-09-01 22:23:16 +00:00
jabber.developer removed their assignment 2025-09-01 22:23:46 +00:00
jabber.developer added the
Kind/Bug
 label 2025-09-01 22:24:42 +00:00
admin closed this issue 2025-09-02 12:20:54 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Kind/Bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin jabber.developer jabber.developer2
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: devs/cproof#24
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?