devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

Fix LMC autocompletion to suggest corrected message content #25

Manually merged
jabber.developer merged 1 commits from fix/correct-autocompletion into master 2025-09-02 12:20:56 +00:00
Conversation 0 Commits 1 Files Changed 2 +16 -7
jabber.developer commented 2025-09-01 22:31:51 +00:00
Owner
Copy Link

This PR fixes the /correct command's autocompletion, which incorrectly suggests the original message content instead of the corrected content. The issue occurs because chatwin_outgoing_msg only updates the last message content for original messages, not corrections. The fix ensures corrected content is stored for autocompletion while preserving the original message ID, per XEP-0308. It also optimizes _chatwin_set_last_message to avoid redundant memory operations and adds null checks for safety.

Checklist

  • Run Valgrind

How to tests

  • Use /correct autocompletion with multiple corrections to ensure correct content is suggested.

Fixes #24.

This PR fixes the `/correct` command's autocompletion, which incorrectly suggests the original message content instead of the corrected content. The issue occurs because `chatwin_outgoing_msg` only updates the last message content for original messages, not corrections. The fix ensures corrected content is stored for autocompletion while preserving the original message ID, per XEP-0308. It also optimizes `_chatwin_set_last_message` to avoid redundant memory operations and adds null checks for safety. ## Checklist - [x] Run Valgrind ## How to tests - Use `/correct` autocompletion with multiple corrections to ensure correct content is suggested. Fixes #24.
jabber.developer added 1 commit 2025-09-01 22:31:51 +00:00
fix(chatwin): Fix LMC autocompletion to suggest corrected message content
All checks were successful
CI / Check spelling (pull_request) Successful in 18s
Details
CI / Check coding style (pull_request) Successful in 33s
Details
CI / Linux (debian) (pull_request) Successful in 9m45s
Details
CI / Linux (ubuntu) (pull_request) Successful in 10m0s
Details
CI / Linux (arch) (pull_request) Successful in 16m48s
Details
2808def933 
- Modified chatwin_outgoing_msg to call _chatwin_set_last_message for corrected messages, using replace_id per XEP-0308.
- Updated _chatwin_set_last_message to skip redundant and invalid free/strdup for same pointers.
- Added null checks in _chatwin_set_last_message for safety.
- Fixes autocompletion suggesting original message content instead of corrected content.

Fixes #24
jabber.developer manually merged commit ea8a758ecf into master 2025-09-02 12:20:56 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin jabber.developer jabber.developer2
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: devs/cproof#25
No description provided.
Delete Branch "fix/correct-autocompletion"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?