devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

Autoping connection_support false negative #40

New Issue
Open
opened 2025-10-14 09:45:48 +00:00 by jabber.developer · 3 comments
jabber.developer commented 2025-10-14 09:45:48 +00:00
Owner
Copy Link

Description

The connection_supports(XMPP_FEATURE_PING) check in the autoping logic intermittently returns FALSE despite the server supporting the ping feature. This falsely triggers prefs_set_autoping(0) and an early return, disabling autoping and preventing further pings.
Root cause likely stems from timing issues, incomplete stream feature parsing, or other XMPP stream handling problems, as observed in production logs.

Impact

Unreliable connection health monitoring due to unexpected autoping disables.
Repeated user-facing error messages without diagnostics.
Intermittent nature makes it hard to reproduce consistently.

Steps to Reproduce

  • Connect to a ping-supporting XMPP server (e.g., via confirmed stream features).
  • [further steps to reproduce are unknown, the error has been reported by users]

Proposed Solution

  • Remove autodisable and early return
  • add one-time error display with debug features print and per-check warning for monitoring.

Additional Context

  • Affects XMPP connections only
  • Monitor post-deploy logs to find root cause
## Description The connection_supports(XMPP_FEATURE_PING) check in the autoping logic intermittently returns FALSE despite the server supporting the ping feature. This falsely triggers prefs_set_autoping(0) and an early return, disabling autoping and preventing further pings. Root cause likely stems from timing issues, incomplete stream feature parsing, or other XMPP stream handling problems, as observed in production logs. ## Impact Unreliable connection health monitoring due to unexpected autoping disables. Repeated user-facing error messages without diagnostics. Intermittent nature makes it hard to reproduce consistently. ## Steps to Reproduce - Connect to a ping-supporting XMPP server (e.g., via confirmed stream features). - [further steps to reproduce are unknown, the error has been reported by users] ## Proposed Solution - Remove autodisable and early return - add one-time error display with debug features print and per-check warning for monitoring. ## Additional Context - Affects XMPP connections only - Monitor post-deploy logs to find root cause
jabber.developer commented 2025-10-14 11:35:05 +00:00
Author
Owner
Copy Link

Hotfix deployed: #41

Hotfix deployed: #41
jabber.developer self-assigned this 2025-10-14 11:35:11 +00:00
jabber.developer added this to the Plans (2025-2026) project 2025-11-10 12:25:47 +00:00
jabber.developer added the
Kind/Bug
Priority
Medium
3
Reviewed
Confirmed
1
 labels 2026-01-21 16:38:20 +00:00
jabber.developer commented 2026-02-05 17:33:40 +00:00
Author
Owner
Copy Link

The bug has just randomly reproduced.

It is caused by AntiSpam plugin.

prof: DBG: [AntiSpam] Blocked stanza: <iq id="discoitemsreq_onconnect" type="result" to

The bug has just randomly reproduced. It is caused by AntiSpam plugin. `prof: DBG: [AntiSpam] Blocked stanza: <iq id="discoitemsreq_onconnect" type="result" to`
jabber.developer moved this to To Do in Plans (2025-2026) on 2026-02-11 08:44:28 +00:00
jabber.developer moved this to Done in Plans (2025-2026) on 2026-06-24 07:26:41 +00:00
jabber.developer commented 2026-07-05 12:20:40 +00:00
Author
Owner
Copy Link

The issue is not related to AntiSpam plugin and is occasionally reproducible on clean installations.

The issue is not related to AntiSpam plugin and is occasionally reproducible on clean installations.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Kind/Bug
Priority
Medium
3
Reviewed
Confirmed
1
Milestone
No items
No Milestone
Projects
Clear projects
No project Plans (2025-2026)
Assignees
Clear assignees
admin jabber.developer jabber.developer2
No Assignees jabber.developer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: devs/cproof#40
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?