devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

[GIT-40] Prevent automatic disabling autoping feature #41

Manually merged
jabber.developer merged 2 commits from fix/autoping-autodisable into master 2025-10-14 11:33:14 +00:00
Conversation 0 Commits 2 Files Changed 9 +56 -12
jabber.developer commented 2025-10-14 09:49:12 +00:00
Owner
Copy Link

Description

Addresses #40 (symptom mitigation; root cause investigation pending)

Problem

The connection_supports(XMPP_FEATURE_PING) check returns FALSE for some users under certain unknown conditions, despite server support, triggering prefs_set_autoping(0) and an early return. This disables autoping unexpectedly, impacting connection monitoring. User reports confirm the issue is accurate but hard to reproduce consistently.

Changes

Remove autodisable (prefs_set_autoping(0)) and early return to preserve autoping functionality.
Add per-check warning log without aborting.
Introduce autoping_error_shown flag for one-time error display via cons_show_error.
On first error, print debug features with connection_debug_print_features().
Add TODO comment on repeated check necessity (consider future caching).

Impact

Restores reliable autoping for affected users while enabling monitoring of false negatives in logs. No user config changes required.

Testing

  • Verified on ping-supporting XMPP servers: autoping continues despite false negatives.
  • Error shown once per session; subsequent checks log only.
  • Monitor post-merge for warning frequency to inform root fix.
## Description Addresses #40 (symptom mitigation; root cause investigation pending) ## Problem The connection_supports(XMPP_FEATURE_PING) check returns FALSE for some users under certain unknown conditions, despite server support, triggering prefs_set_autoping(0) and an early return. This disables autoping unexpectedly, impacting connection monitoring. User reports confirm the issue is accurate but hard to reproduce consistently. ## Changes Remove autodisable (prefs_set_autoping(0)) and early return to preserve autoping functionality. Add per-check warning log without aborting. Introduce autoping_error_shown flag for one-time error display via cons_show_error. On first error, print debug features with connection_debug_print_features(). Add TODO comment on repeated check necessity (consider future caching). ## Impact Restores reliable autoping for affected users while enabling monitoring of false negatives in logs. No user config changes required. ## Testing - Verified on ping-supporting XMPP servers: autoping continues despite false negatives. - Error shown once per session; subsequent checks log only. - Monitor post-merge for warning frequency to inform root fix.
jabber.developer added 2 commits 2025-10-14 09:49:12 +00:00
feat: make /log level work with non-default files ad95edb2b9
fix: prevent autoping disable on false negative ping support check
Some checks failed
CI Code / Linux (debian) (pull_request) Failing after 1m3s
Details
CI Code / Check coding style (pull_request) Successful in 33s
Details
CI Code / Check spelling (pull_request) Successful in 18s
Details
CI Code / Linux (ubuntu) (pull_request) Failing after 3m5s
Details
CI Code / Linux (arch) (pull_request) Failing after 3m47s
Details
a689973674 
Remove autodisable logic (prefs_set_autoping(0)) and early return in autoping
to treat intermittent false negatives from connection_supports(XMPP_FEATURE_PING).
Add one-time error display with debug features print for monitoring; warn on first failing
check without aborting to maintain functionality while investigating root cause.
jabber.developer changed title from fix/autoping-autodisable to Prevent automatic disabling autoping feature 2025-10-14 09:53:16 +00:00
jabber.developer force-pushed fix/autoping-autodisable from a689973674 to b79bafbd8f 2025-10-14 10:03:45 +00:00 Compare
jabber.developer force-pushed fix/autoping-autodisable from b79bafbd8f to 3738be4af1 2025-10-14 10:42:08 +00:00 Compare
jabber.developer changed title from Prevent automatic disabling autoping feature to [GIT-40] Prevent automatic disabling autoping feature 2025-10-14 10:59:55 +00:00
jabber.developer manually merged commit 3738be4af1 into master 2025-10-14 11:33:14 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin jabber.developer jabber.developer2
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: devs/cproof#41
No description provided.
Delete Branch "fix/autoping-autodisable"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?