devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

XEP-0030: Empty disco#items result silently ignored #90

New Issue
Closed
opened 2026-02-10 22:26:13 +00:00 by jabber.developer2 · 1 comment
jabber.developer2 commented 2026-02-10 22:26:13 +00:00
Collaborator
Copy Link

Description

When querying service discovery items (/disco items) on a server that returns an empty <query/> element (no items), the client silently ignores the result instead of displaying a message to the user.

Expected Behavior

Display message: No service discovery items for <jid>

Actual Behavior

No output shown to user. Command appears to do nothing.

Steps to Reproduce

  1. Connect to any XMPP server
  2. Run /disco items against a JID that has no associated items
  3. Observe no response

XEP-0030 Reference

Per XEP-0030 Section 3, 4:

"If there are no items associated with an entity (or if those items are not publicly available), the target entity MUST return an empty query element to the requesting entity"

Example valid response:

<iq type='result' from='example.com' to='user@example.com/resource' id='items1'>
  <query xmlns='http://jabber.org/protocol/disco#items'/>
</iq>

Root Cause

In iq.c, function _disco_items_result_handler() has early return when query has no children:

xmpp_stanza_t* child = xmpp_stanza_get_children(query);
if (child == NULL) {
    return;  // <-- Bug: exits before showing "No items" message
}

Introduced In

Commit f28655c5c (2016-05-08) "Move logic to connection_set_disco_items"

Affected Versions

All versions since 0.5.0

Proposed Fix

Remove the early return check. PR #89 submitted.

### Description When querying service discovery items (`/disco items`) on a server that returns an empty `<query/>` element (no items), the client silently ignores the result instead of displaying a message to the user. ### Expected Behavior Display message: `No service discovery items for <jid>` ### Actual Behavior No output shown to user. Command appears to do nothing. ### Steps to Reproduce 1. Connect to any XMPP server 2. Run `/disco items` against a JID that has no associated items 3. Observe no response ### XEP-0030 Reference Per [XEP-0030 Section 3, 4](https://xmpp.org/extensions/xep-0030.html#items): > "If there are no items associated with an entity (or if those items are not publicly available), the target entity MUST return an empty query element to the requesting entity" Example valid response: ```xml <iq type='result' from='example.com' to='user@example.com/resource' id='items1'> <query xmlns='http://jabber.org/protocol/disco#items'/> </iq> ``` ### Root Cause In iq.c, function `_disco_items_result_handler()` has early return when query has no children: ```c xmpp_stanza_t* child = xmpp_stanza_get_children(query); if (child == NULL) { return; // <-- Bug: exits before showing "No items" message } ``` ### Introduced In Commit f28655c5c (2016-05-08) "Move logic to connection_set_disco_items" ### Affected Versions All versions since 0.5.0 ### Proposed Fix Remove the early return check. PR #89 submitted.
jabber.developer2 added the
Kind/Bug
 label 2026-02-10 22:26:14 +00:00
jabber.developer2 added this to the Plans (2025-2026) project 2026-02-10 22:26:17 +00:00
jabber.developer commented 2026-02-11 08:42:24 +00:00
Owner
Copy Link

Resolved by #89

Resolved by #89
jabber.developer moved this to Done in Plans (2025-2026) on 2026-02-11 08:43:01 +00:00
jabber.developer moved this to Verification in Plans (2025-2026) on 2026-02-11 08:43:26 +00:00
jabber.developer moved this to Done in Plans (2025-2026) on 2026-03-04 11:36:13 +00:00
Sign in to join this conversation.
fix/xep-0030-empty-disco-items
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Kind/Bug
Milestone
No items
No Milestone
Projects
Clear projects
No project Plans (2025-2026)
Assignees
Clear assignees
admin jabber.developer jabber.developer2
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: devs/cproof#90
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?