devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

fix(xmpp): show message for empty disco#items results (XEP-0030) #89

Manually merged
jabber.developer2 merged 1 commits from fix/xep-0030-empty-disco-items into master 2026-02-11 08:41:25 +00:00
Conversation 0 Commits 1 Files Changed 1 -3
jabber.developer2 commented 2026-02-10 22:19:50 +00:00
Collaborator
Copy Link

Summary

Fixes XEP-0030 compliance issue where empty disco#items results were silently ignored instead of showing a user-friendly message.

Problem

When a server returns an empty <query/> element for disco#items (which is valid per XEP-0030), the client silently returned without displaying any message to the user.

Per XEP-0030 Section 3.1:

"If there are no items associated with an entity (or if those items are not publicly available), the target entity MUST return an empty query element to the requesting entity"

Solution

Removed erroneous early return in _disco_items_result_handler() when child == NULL. Now the function continues to display "No service discovery items for X" as intended.

Changes

// Removed from src/xmpp/iq.c:
xmpp_stanza_t* child = xmpp_stanza_get_children(query);
-   if (child == NULL) {
-       return;
-   }

Root Cause

This update introduced in commit f28655c5c (2016-05-08) "Move logic to connection_set_disco_items" which added the early return check.

Testing

  • Verified with functional test disco_items_empty_result (in PR #88)
  • [] Manual testing with /disco items against server with no items

Related

### Summary Fixes XEP-0030 compliance issue where empty disco#items results were silently ignored instead of showing a user-friendly message. ### Problem When a server returns an empty `<query/>` element for disco#items (which is valid per XEP-0030), the client silently returned without displaying any message to the user. Per [XEP-0030 Section 3.1](https://xmpp.org/extensions/xep-0030.html#items): > "If there are no items associated with an entity (or if those items are not publicly available), the target entity MUST return an empty query element to the requesting entity" ### Solution Removed erroneous early return in `_disco_items_result_handler()` when `child == NULL`. Now the function continues to display "No service discovery items for X" as intended. ### Changes ```c // Removed from src/xmpp/iq.c: xmpp_stanza_t* child = xmpp_stanza_get_children(query); - if (child == NULL) { - return; - } ``` ### Root Cause This update introduced in commit f28655c5c (2016-05-08) "Move logic to connection_set_disco_items" which added the early return check. ### Testing - [x] Verified with functional test `disco_items_empty_result` (in PR #88) - [] Manual testing with `/disco items` against server with no items ### Related - PR #88 (test/autoping-functional-tests) - contains functional test for this fix - Closes #90
jabber.developer2 added 1 commit 2026-02-10 22:19:52 +00:00
fix(xmpp): show message for empty disco#items results (XEP-0030)
All checks were successful
CI Code / Check spelling (pull_request) Successful in 23s
Details
CI Code / Check coding style (pull_request) Successful in 34s
Details
CI Code / Code Coverage (pull_request) Successful in 4m45s
Details
CI Code / Linux (debian) (pull_request) Successful in 6m10s
Details
CI Code / Linux (ubuntu) (pull_request) Successful in 6m17s
Details
CI Code / Linux (arch) (pull_request) Successful in 6m24s
Details
CI Code / Check spelling (push) Successful in 17s
Details
CI Code / Check coding style (push) Successful in 30s
Details
CI Code / Linux (debian) (push) Successful in 6m16s
Details
CI Code / Linux (ubuntu) (push) Successful in 6m22s
Details
CI Code / Linux (arch) (push) Successful in 6m27s
Details
CI Code / Code Coverage (push) Successful in 9m41s
Details
4fce333c9a 
Per XEP-0030 section 3.1: 'if an entity has no associated items,
it MUST return an empty <query/> element.'

The client should display 'No service discovery items for X' when
receiving an empty result, not silently ignore it.

Previous version introduced in commit f28655c5c (2016-05-08) which added an early
return when child == NULL, preventing the message from being shown.
jabber.developer2 added the
Kind/Bug
 label 2026-02-10 22:29:03 +00:00
jabber.developer added the
Priority
Medium
3
Reviewed
Confirmed
1
 labels 2026-02-11 08:38:08 +00:00
jabber.developer2 manually merged commit 4fce333c9a into master 2026-02-11 08:41:25 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Kind/Bug
Priority
Medium
3
Reviewed
Confirmed
1
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin jabber.developer jabber.developer2
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Blocks
#88 test: add functional tests for autoping and service discovery (XEP-0199, XEP-0030)
devs/cproof
Reference: devs/cproof#89
No description provided.
Delete Branch "fix/xep-0030-empty-disco-items"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?