devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

chore(chatlog): disable background message file logging (stage 1) #127

Manually merged
jabber.developer2 merged 1 commits from chore/remove-chatlog-stage-1 into master 2026-05-20 11:41:23 +00:00
Conversation 0 Commits 1 Files Changed 1 +22 -383
jabber.developer2 commented 2026-05-20 10:38:28 +00:00
Collaborator
Copy Link

Summary

Stage 1 of removing the chatlog subsystem that wrote plain-text per-day message logs to $XDG_DATA_HOME/profanity/chatlogs/<account>/<other>/YYYY_MM_DD.log (and chatlogs/<account>/rooms/... for MUCs). These files were never read back by Profanity — history replay in src/ui/chatwin.c reads from the database via log_database_get_previous_chat, not from these files — so the feature only ever wrote to disk for users to inspect with external tools.

This change reduces src/chatlog.c to no-op stubs while preserving all 12 public signatures. The ~20 call sites in src/event/, src/otr/otr.c and src/profanity.c continue to compile and link unchanged.

What changes for users

  • chatlogs/ directory is no longer created or written to.
  • Existing chatlogs/ data on disk is left untouched (users may delete it manually).
  • /logging, /otr log, /pgp log, /omemo log, /ox log and the related preferences (chlog, grlog, otr.log, pgp.log, omemo.log, ox.log) continue to be accepted but have no on-disk effect.

What is NOT affected

  • Database-backed history: PREF_DBLOG, PREF_HISTORY, /history, SQLite/flatfile backends.
  • Debug logging: log.c, /log, profanity*.log.
  • xmlconsole, OMEMO/OTR/PGP/OX encryption flows.

Follow-up stages (separate PRs)

  • Stage 2 — remove /logging, /otr log, /pgp log, /omemo log, /ox log commands and decouple PREF_CHLOG from history-replay gating in chatwin.c.
  • Stage 3 — remove the ~20 call sites and the PREF_CHLOG/PREF_GRLOG/PREF_OTR_LOG/PREF_PGP_LOG/PREF_OMEMO_LOG/PREF_OX_LOG preferences.
  • Stage 4 — delete src/chatlog.c, src/chatlog.h, tests/unittests/chatlog/stub_chatlog.c, DIR_CHATLOGS and the _create_chatlogs_dir helper in functional tests.
## Summary Stage 1 of removing the chatlog subsystem that wrote plain-text per-day message logs to `$XDG_DATA_HOME/profanity/chatlogs/<account>/<other>/YYYY_MM_DD.log` (and `chatlogs/<account>/rooms/...` for MUCs). These files were never read back by Profanity — history replay in [src/ui/chatwin.c](src/ui/chatwin.c) reads from the database via `log_database_get_previous_chat`, not from these files — so the feature only ever wrote to disk for users to inspect with external tools. This change reduces [src/chatlog.c](src/chatlog.c) to no-op stubs while preserving all 12 public signatures. The ~20 call sites in `src/event/`, `src/otr/otr.c` and `src/profanity.c` continue to compile and link unchanged. ## What changes for users - `chatlogs/` directory is no longer created or written to. - Existing `chatlogs/` data on disk is left untouched (users may delete it manually). - `/logging`, `/otr log`, `/pgp log`, `/omemo log`, `/ox log` and the related preferences (`chlog`, `grlog`, `otr.log`, `pgp.log`, `omemo.log`, `ox.log`) continue to be accepted but have no on-disk effect. ## What is NOT affected - Database-backed history: `PREF_DBLOG`, `PREF_HISTORY`, `/history`, SQLite/flatfile backends. - Debug logging: `log.c`, `/log`, `profanity*.log`. - `xmlconsole`, OMEMO/OTR/PGP/OX encryption flows. ## Follow-up stages (separate PRs) - **Stage 2** — remove `/logging`, `/otr log`, `/pgp log`, `/omemo log`, `/ox log` commands and decouple `PREF_CHLOG` from history-replay gating in `chatwin.c`. - **Stage 3** — remove the ~20 call sites and the `PREF_CHLOG`/`PREF_GRLOG`/`PREF_OTR_LOG`/`PREF_PGP_LOG`/`PREF_OMEMO_LOG`/`PREF_OX_LOG` preferences. - **Stage 4** — delete `src/chatlog.c`, `src/chatlog.h`, `tests/unittests/chatlog/stub_chatlog.c`, `DIR_CHATLOGS` and the `_create_chatlogs_dir` helper in functional tests.
jabber.developer2 added 1 commit 2026-05-20 10:38:28 +00:00
chore(chatlog): disable background message file logging (stage 1)
All checks were successful
CI Code / Check spelling (pull_request) Successful in 16s
Details
CI Code / Check coding style (pull_request) Successful in 30s
Details
CI Code / Code Coverage (pull_request) Successful in 2m39s
Details
CI Code / Linux (ubuntu) (pull_request) Successful in 4m58s
Details
CI Code / Linux (arch) (pull_request) Successful in 5m56s
Details
CI Code / Linux (debian) (pull_request) Successful in 7m2s
Details
CI Code / Check spelling (push) Successful in 16s
Details
CI Code / Check coding style (push) Successful in 31s
Details
CI Code / Code Coverage (push) Successful in 2m41s
Details
CI Code / Linux (ubuntu) (push) Successful in 5m3s
Details
CI Code / Linux (arch) (push) Successful in 6m2s
Details
CI Code / Linux (debian) (push) Successful in 7m12s
Details
3b673150b4 
First stage of removing the chatlog subsystem that writes plain-text
per-day message logs to $XDG_DATA_HOME/profanity/chatlogs/. These files
were never read back by Profanity (history replay reads from the
database via log_database_get_previous_chat), so the feature only ever
wrote to disk for users to inspect with external tools.

This change reduces chatlog.c to no-op stubs, preserving all public
signatures so the ~20 call sites in event/, otr/ and profanity.c
continue to compile and link unchanged. Subsequent stages will remove
the call sites, the related preferences (PREF_CHLOG, PREF_GRLOG and the
per-encryption PREF_*_LOG) and the now-dead commands (/logging,
/otr log, /pgp log, /omemo log, /ox log).

Database-based history (PREF_DBLOG, /history) and the debug log
(log.c, /log) are unaffected.
jabber.developer2 manually merged commit 3b673150b4 into master 2026-05-20 11:41:23 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin jabber.developer jabber.developer2
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: devs/cproof#127
No description provided.
Delete Branch "chore/remove-chatlog-stage-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?