build: untrack generated src/gitversion.h.in #137

Manually merged

jabber.developer merged 1 commits from chore/untrack-gitversion into master 2026-06-23 12:34:20 +00:00

Conversation 0 Commits 1 Files Changed 1 -6

jabber.developer2 commented 2026-06-23 10:57:27 +00:00

Collaborator

Copy Link

src/gitversion.h.in is listed in .gitignore and regenerated by the build recipe from .git/HEAD/.git/index, but it was committed to the repo by mistake during the upstream sync. As a result the tracked file is overwritten by the build and dirties git status.

This PR untracks the file (git rm --cached), restoring the pre-sync state where it was a purely generated artifact. The file stays on disk and remains gitignored.

Version-string behaviour is unchanged: dev builds still report 0.15.0dev.master.. The generation recipe and the BUILT_SOURCES dependency are left untouched — that is a separate concern (see below).

Out of scope: the common.o recompile + relink on every git operation (measured ~1.85s) remains. It stems from gitversion.h depending on .git/HEAD/.git/index and predates the upstream sync; removing it would require moving the hash computation into ./configure.

Fixes #139

src/gitversion.h.in is listed in .gitignore and regenerated by the build recipe from .git/HEAD/.git/index, but it was committed to the repo by mistake during the upstream sync. As a result the tracked file is overwritten by the build and dirties git status. This PR untracks the file (git rm --cached), restoring the pre-sync state where it was a purely generated artifact. The file stays on disk and remains gitignored. Version-string behaviour is unchanged: dev builds still report 0.15.0dev.master.<hash>. The generation recipe and the BUILT_SOURCES dependency are left untouched — that is a separate concern (see below). Out of scope: the common.o recompile + relink on every git operation (measured ~1.85s) remains. It stems from gitversion.h depending on .git/HEAD/.git/index and predates the upstream sync; removing it would require moving the hash computation into ./configure. Fixes #139

jabber.developer2 added 1 commit 2026-06-23 10:57:27 +00:00

build: untrack generated src/gitversion.h.in ... d4fbc26fea

The file is gitignored and regenerated by the build recipe from
.git/HEAD/.git/index; it was committed by mistake during the upstream
sync. Untrack it so builds no longer dirty the working tree. The
version string behaviour is unchanged.

jabber.developer manually merged commit 72aa603147 into master 2026-06-23 12:34:20 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

Compat/Breaking

Breaking change that won't be backward compatible

Kind/Bug

Something is not working

Kind/Documentation

Documentation changes

Kind/Enhancement

Improve existing functionality

Kind/Feature

New functionality

Kind/Security

This is security issue

Kind/Testing

Issue or pull request related to testing

Priority

Critical

1

The priority is critical

Priority

High

2

The priority is high

Priority

Low

4

The priority is low

Priority

Medium

3

The priority is medium

Reviewed

Confirmed

1

Issue has been confirmed

Reviewed

Duplicate

2

This issue or pull request already exists

Reviewed

Invalid

3

Invalid issue

Reviewed

Won't Fix

3

This issue won't be fixed

Status

Abandoned

3

Somebody has started to work on this but abandoned work

Status

Blocked

1

Something is blocking this issue or pull request

Status

Need More Info

2

Feedback is required to reproduce issue or to continue work

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

admin jabber.developer jabber.developer2

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: devs/cproof#137

No description provided.