fix(xmpp): guard NULL domain in autoping disco warning gate #138

Manually merged

jabber.developer2 merged 1 commits from fix/autoping-warning-null-domain into master 2026-06-23 12:31:56 +00:00

Conversation 1 Commits 1 Files Changed 1 +2 -1

jabber.developer2 commented 2026-06-23 11:25:22 +00:00

Collaborator

Copy Link

Follow-up to the autoping availability warning.

The disco-onconnect gate uses g_ascii_strcasecmp(from, connection_get_domain()), which is not NULL-safe (unlike the g_strcmp0 it replaced). connection_get_domain() can return NULL (initialised to NULL, FREE_SET_NULL on teardown), so a disco#info response racing a disconnect could dereference NULL.

Capture the domain into a local and skip the check when it's NULL:

const char* domain = connection_get_domain();
if (from && domain && g_ascii_strcasecmp(from, domain) == 0) { ... }

from is already guarded; this just adds the domain side.

Follow-up to the autoping availability warning. The disco-onconnect gate uses `g_ascii_strcasecmp(from, connection_get_domain())`, which is not NULL-safe (unlike the `g_strcmp0` it replaced). `connection_get_domain()` can return NULL (initialised to NULL, `FREE_SET_NULL` on teardown), so a disco#info response racing a disconnect could dereference NULL. Capture the domain into a local and skip the check when it's NULL: const char* domain = connection_get_domain(); if (from && domain && g_ascii_strcasecmp(from, domain) == 0) { ... } `from` is already guarded; this just adds the domain side.

jabber.developer2 added 1 commit 2026-06-23 11:25:22 +00:00

fix(xmpp): guard NULL domain in autoping disco warning gate ... 15dfc2bdb4

g_ascii_strcasecmp() is not NULL-safe (unlike the g_strcmp0 it replaced), and connection_get_domain() can be NULL (init NULL, FREE_SET_NULL on teardown). A disco#info response racing a disconnect would dereference NULL. Capture the domain and skip the check when it is NULL.

jabber.developer2 manually merged commit 15dfc2bdb4 into master 2026-06-23 12:31:56 +00:00

jabber.developer reviewed 2026-06-23 12:32:05 +00:00

jabber.developer left a comment

Owner

Copy Link

LGTM

LGTM

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

Compat/Breaking

Breaking change that won't be backward compatible

Kind/Bug

Something is not working

Kind/Documentation

Documentation changes

Kind/Enhancement

Improve existing functionality

Kind/Feature

New functionality

Kind/Security

This is security issue

Kind/Testing

Issue or pull request related to testing

Priority

Critical

1

The priority is critical

Priority

High

2

The priority is high

Priority

Low

4

The priority is low

Priority

Medium

3

The priority is medium

Reviewed

Confirmed

1

Issue has been confirmed

Reviewed

Duplicate

2

This issue or pull request already exists

Reviewed

Invalid

3

Invalid issue

Reviewed

Won't Fix

3

This issue won't be fixed

Status

Abandoned

3

Somebody has started to work on this but abandoned work

Status

Blocked

1

Something is blocking this issue or pull request

Status

Need More Info

2

Feedback is required to reproduce issue or to continue work

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

admin jabber.developer jabber.developer2

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: devs/cproof#138

No description provided.