devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

Fix #14: Add features in caps_init to avoid redundant presence updates #15

Manually merged
jabber.developer merged 1 commits from fix/init-caps into master 2025-07-19 17:32:04 +00:00
Conversation 0 Commits 1 Files Changed 1 +8
jabber.developer commented 2025-07-19 16:44:07 +00:00
Owner
Copy Link

Fixes #14 by adding the features in the hash table early on.

  • I ran valgrind when using my new feature

How to test the functionality

  • step 1
  • step 2
Fixes #14 by adding the features in the hash table early on. - [ ] I ran valgrind when using my new feature ### How to test the functionality - step 1 - step 2
jabber.developer added 1 commit 2025-07-19 16:44:08 +00:00
fix(caps): Add features in caps_init to avoid redundant presence updates
All checks were successful
CI / Check spelling (pull_request) Successful in 1m26s
Details
CI / Check coding style (pull_request) Successful in 1m37s
Details
CI / Linux (debian) (pull_request) Successful in 9m54s
Details
CI / Linux (ubuntu) (pull_request) Successful in 10m11s
Details
CI / Linux (fedora) (pull_request) Successful in 14m56s
Details
CI / Linux (arch) (pull_request) Successful in 16m38s
Details
CI / Check spelling (push) Successful in 15s
Details
CI / Check coding style (push) Successful in 26s
Details
CI / Linux (debian) (push) Successful in 9m49s
Details
CI / Linux (ubuntu) (push) Successful in 10m1s
Details
CI / Linux (fedora) (push) Successful in 12m59s
Details
CI / Linux (arch) (push) Successful in 13m51s
Details
e1ce7ac630 
Previously, features like `XMPP_FEATURE_OMEMO_DEVICELIST_NOTIFY` were
added in separate init methods (e.g., `omemo_devicelist_subscribe`) via
`caps_add_feature`, triggering `cl_ev_presence_send` and sending multiple
"online" XMPP presence stanzas. This caused other clients to see users
as appearing "online" multiple times.

This change adds `STANZA_NS_MOOD_NOTIFY` and
`XMPP_FEATURE_OMEMO_DEVICELIST_NOTIFY` in `caps_init`, ensuring they are
in `prof_features` early. This allows `caps_add_feature` to exit early
when called for these features, avoiding redundant presence updates.
jabber.developer manually merged commit e1ce7ac630 into master 2025-07-19 17:32:04 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin jabber.developer jabber.developer2
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: devs/cproof#15
No description provided.
Delete Branch "fix/init-caps"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?